Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-3344

Fix warning - procfs stat file is not in the expected format

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.6.0
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      Although this doesn't appear to be causing any functional issues, it is spamming our log files quite a bit.

      It appears that the regex in ProcfsBasedProcessTree doesn't work for all /proc/<pid>/stat files.

      Here's the error I'm seeing:

          "source_host": "asdf",
          "method": "constructProcessInfo",
          "level": "WARN",
          "message": "Unexpected: procfs stat file is not in the expected format for process with pid 6953"
          "file": "ProcfsBasedProcessTree.java",
          "line_number": "514",
          "class": "org.apache.hadoop.yarn.util.ProcfsBasedProcessTree",
      

      And here's the basic info on process with pid 6953:

      [asdf ~]$ cat /proc/6953/stat
      6953 (python2.6 /expo) S 1871 1871 1871 0 -1 4202496 9364 1080 0 0 25 3 0 0 20 0 1 0 144918696 205295616 5856 18446744073709551615 1 1 0 0 0 0 0 16781312 2 18446744073709551615 0 0 17 13 0 0 0 0 0
      [asdf ~]$ ps aux|grep 6953
      root      6953  0.0  0.0 200484 23424 ?        S    21:44   0:00 python2.6 /export/apps/salt/minion-scripts/module-sync.py
      jbringhu 13481  0.0  0.0 105312   872 pts/0    S+   22:13   0:00 grep -i 6953
      [asdf ~]$ 
      

      This is using 2.6.32-431.11.2.el6.x86_64 in RHEL 6.5.

      1. YARN-3344.06.patch
        5 kB
        Akira Ajisaka
      2. YARN-3344.07.patch
        5 kB
        Akira Ajisaka
      3. YARN-3344.08.patch
        5 kB
        Akira Ajisaka
      4. YARN-3344.09.patch
        8 kB
        Akira Ajisaka
      5. YARN-3344-trunk.005.patch
        5 kB
        Ravindra Kumar Naik

        Activity

        Hide
        ravindra.naik Ravindra Kumar Naik added a comment -

        The second field in /proc/pid/stat file will be in parentheses but it can have spaces.
        Updated the PROCFS_STAT_FILE_FORMAT regex to extract the process name using parentheses. Updated unit tests to have space in process name.

        Show
        ravindra.naik Ravindra Kumar Naik added a comment - The second field in /proc/pid/stat file will be in parentheses but it can have spaces. Updated the PROCFS_STAT_FILE_FORMAT regex to extract the process name using parentheses. Updated unit tests to have space in process name.
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12704878/YARN-3344-branch-2.6.0.001.patch
        against trunk revision 2681ed9.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. There were no new javadoc warning messages.

        -1 eclipse:eclipse. The patch failed to build with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in .

        Test results: https://builds.apache.org/job/PreCommit-YARN-Build/6983//testReport/
        Console output: https://builds.apache.org/job/PreCommit-YARN-Build/6983//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12704878/YARN-3344-branch-2.6.0.001.patch against trunk revision 2681ed9. +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. -1 eclipse:eclipse . The patch failed to build with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-YARN-Build/6983//testReport/ Console output: https://builds.apache.org/job/PreCommit-YARN-Build/6983//console This message is automatically generated.
        Hide
        ravindra.naik Ravindra Kumar Naik added a comment -

        fixed formatting issue in patch

        Show
        ravindra.naik Ravindra Kumar Naik added a comment - fixed formatting issue in patch
        Hide
        hadoopqa Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12704906/YARN-3344-branch-trunk.002.patch
        against trunk revision 2681ed9.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. There were no new javadoc warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common.

        Test results: https://builds.apache.org/job/PreCommit-YARN-Build/6984//testReport/
        Console output: https://builds.apache.org/job/PreCommit-YARN-Build/6984//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12704906/YARN-3344-branch-trunk.002.patch against trunk revision 2681ed9. +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common. Test results: https://builds.apache.org/job/PreCommit-YARN-Build/6984//testReport/ Console output: https://builds.apache.org/job/PreCommit-YARN-Build/6984//console This message is automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12704909/YARN-3344-branch-trunk.003.patch
        against trunk revision 2681ed9.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. There were no new javadoc warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common.

        Test results: https://builds.apache.org/job/PreCommit-YARN-Build/6986//testReport/
        Console output: https://builds.apache.org/job/PreCommit-YARN-Build/6986//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12704909/YARN-3344-branch-trunk.003.patch against trunk revision 2681ed9. +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common. Test results: https://builds.apache.org/job/PreCommit-YARN-Build/6986//testReport/ Console output: https://builds.apache.org/job/PreCommit-YARN-Build/6986//console This message is automatically generated.
        Hide
        kartha Rajesh Kartha added a comment -

        I tried the patch in my env and did not see any new failures.

        Show
        kartha Rajesh Kartha added a comment - I tried the patch in my env and did not see any new failures.
        Hide
        djp Junping Du added a comment -

        Manually kick off Jenkins test again.

        Show
        djp Junping Du added a comment - Manually kick off Jenkins test again.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 15m 2s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 7m 47s There were no new javac warning messages.
        +1 javadoc 9m 50s There were no new javadoc warning messages.
        +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings.
        -1 checkstyle 0m 50s The applied patch generated 1 new checkstyle issues (total was 43, now 43).
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 37s mvn install still works.
        +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse.
        +1 findbugs 1m 25s The patch does not introduce any new Findbugs (version 2.0.3) warnings.
        +1 yarn tests 1m 59s Tests passed in hadoop-yarn-common.
            39m 29s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12704909/YARN-3344-branch-trunk.003.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 6471d18
        checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/7838/artifact/patchprocess/diffcheckstylehadoop-yarn-common.txt
        hadoop-yarn-common test log https://builds.apache.org/job/PreCommit-YARN-Build/7838/artifact/patchprocess/testrun_hadoop-yarn-common.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/7838/testReport/
        Java 1.7.0_55
        uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/7838/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 15m 2s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 47s There were no new javac warning messages. +1 javadoc 9m 50s There were no new javadoc warning messages. +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 0m 50s The applied patch generated 1 new checkstyle issues (total was 43, now 43). +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 37s mvn install still works. +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse. +1 findbugs 1m 25s The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 yarn tests 1m 59s Tests passed in hadoop-yarn-common.     39m 29s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12704909/YARN-3344-branch-trunk.003.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 6471d18 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/7838/artifact/patchprocess/diffcheckstylehadoop-yarn-common.txt hadoop-yarn-common test log https://builds.apache.org/job/PreCommit-YARN-Build/7838/artifact/patchprocess/testrun_hadoop-yarn-common.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/7838/testReport/ Java 1.7.0_55 uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-YARN-Build/7838/console This message was automatically generated.
        Hide
        ravindra.naik Ravindra Kumar Naik added a comment -

        updated patch with formatting issue fixed

        Show
        ravindra.naik Ravindra Kumar Naik added a comment - updated patch with formatting issue fixed
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 15m 1s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 7m 47s There were no new javac warning messages.
        +1 javadoc 9m 46s There were no new javadoc warning messages.
        +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
        -1 checkstyle 0m 57s The applied patch generated 2 new checkstyle issues (total was 43, now 42).
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 37s mvn install still works.
        +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
        +1 findbugs 1m 25s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 yarn tests 2m 4s Tests passed in hadoop-yarn-common.
            39m 39s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12734110/YARN-3344-trunk.004.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 4aa730c
        checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/8022/artifact/patchprocess/diffcheckstylehadoop-yarn-common.txt
        hadoop-yarn-common test log https://builds.apache.org/job/PreCommit-YARN-Build/8022/artifact/patchprocess/testrun_hadoop-yarn-common.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/8022/testReport/
        Java 1.7.0_55
        uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/8022/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 15m 1s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 47s There were no new javac warning messages. +1 javadoc 9m 46s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 0m 57s The applied patch generated 2 new checkstyle issues (total was 43, now 42). +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 37s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 1m 25s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 yarn tests 2m 4s Tests passed in hadoop-yarn-common.     39m 39s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12734110/YARN-3344-trunk.004.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 4aa730c checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/8022/artifact/patchprocess/diffcheckstylehadoop-yarn-common.txt hadoop-yarn-common test log https://builds.apache.org/job/PreCommit-YARN-Build/8022/artifact/patchprocess/testrun_hadoop-yarn-common.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/8022/testReport/ Java 1.7.0_55 uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-YARN-Build/8022/console This message was automatically generated.
        Hide
        ravindra.naik Ravindra Kumar Naik added a comment -

        updated patch with checkstyle issue handled

        Show
        ravindra.naik Ravindra Kumar Naik added a comment - updated patch with checkstyle issue handled
        Hide
        hadoopqa Hadoop QA added a comment -



        +1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 15m 2s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 7m 41s There were no new javac warning messages.
        +1 javadoc 10m 1s There were no new javadoc warning messages.
        +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 0m 24s There were no new checkstyle issues.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 34s mvn install still works.
        +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
        +1 findbugs 1m 23s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 yarn tests 1m 57s Tests passed in hadoop-yarn-common.
            39m 2s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12734126/YARN-3344-trunk.005.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 4aa730c
        hadoop-yarn-common test log https://builds.apache.org/job/PreCommit-YARN-Build/8024/artifact/patchprocess/testrun_hadoop-yarn-common.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/8024/testReport/
        Java 1.7.0_55
        uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/8024/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 pre-patch 15m 2s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 41s There were no new javac warning messages. +1 javadoc 10m 1s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 0m 24s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 34s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 1m 23s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 yarn tests 1m 57s Tests passed in hadoop-yarn-common.     39m 2s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12734126/YARN-3344-trunk.005.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 4aa730c hadoop-yarn-common test log https://builds.apache.org/job/PreCommit-YARN-Build/8024/artifact/patchprocess/testrun_hadoop-yarn-common.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/8024/testReport/ Java 1.7.0_55 uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-YARN-Build/8024/console This message was automatically generated.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        Hi Ravindra Kumar Naik, thank you for creating the patch. Mostly looks good to me.

              "^([0-9-]+)\\s\\((.*)\\)\\s[^\\s]\\s([0-9-]+)\\s([0-9-]+)\\s([0-9-]+)" +
        

        1. I'm thinking (.*) should be (.+).
        2. Can we replace [0-9] with \d for improving readability?

        Show
        ajisakaa Akira Ajisaka added a comment - Hi Ravindra Kumar Naik , thank you for creating the patch. Mostly looks good to me. "^([0-9-]+)\\s\\((.*)\\)\\s[^\\s]\\s([0-9-]+)\\s([0-9-]+)\\s([0-9-]+)" + 1. I'm thinking (.*) should be (.+) . 2. Can we replace [0-9] with \d for improving readability?
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        -1 pre-patch 19m 32s Pre-patch trunk has 3 extant Findbugs (version 3.0.0) warnings.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 8m 50s There were no new javac warning messages.
        +1 javadoc 11m 5s There were no new javadoc warning messages.
        +1 release audit 0m 25s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 1m 1s There were no new checkstyle issues.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 39s mvn install still works.
        +1 eclipse:eclipse 0m 38s The patch built with eclipse:eclipse.
        +1 findbugs 1m 45s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 yarn tests 2m 12s Tests passed in hadoop-yarn-common.
            47m 11s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12734126/YARN-3344-trunk.005.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 124a412
        Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-YARN-Build/9542/artifact/patchprocess/trunkFindbugsWarningshadoop-yarn-common.html
        hadoop-yarn-common test log https://builds.apache.org/job/PreCommit-YARN-Build/9542/artifact/patchprocess/testrun_hadoop-yarn-common.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9542/testReport/
        Java 1.7.0_55
        uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/9542/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 pre-patch 19m 32s Pre-patch trunk has 3 extant Findbugs (version 3.0.0) warnings. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 8m 50s There were no new javac warning messages. +1 javadoc 11m 5s There were no new javadoc warning messages. +1 release audit 0m 25s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 1m 1s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 39s mvn install still works. +1 eclipse:eclipse 0m 38s The patch built with eclipse:eclipse. +1 findbugs 1m 45s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 yarn tests 2m 12s Tests passed in hadoop-yarn-common.     47m 11s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12734126/YARN-3344-trunk.005.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 124a412 Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-YARN-Build/9542/artifact/patchprocess/trunkFindbugsWarningshadoop-yarn-common.html hadoop-yarn-common test log https://builds.apache.org/job/PreCommit-YARN-Build/9542/artifact/patchprocess/testrun_hadoop-yarn-common.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9542/testReport/ Java 1.7.0_55 uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-YARN-Build/9542/console This message was automatically generated.
        Hide
        vinodkv Vinod Kumar Vavilapalli added a comment -

        Looking good to me too, but canceling for addressing Akira Ajisaka's comments /cc Ravindra Kumar Naik.

        Show
        vinodkv Vinod Kumar Vavilapalli added a comment - Looking good to me too, but canceling for addressing Akira Ajisaka 's comments /cc Ravindra Kumar Naik .
        Hide
        vinodkv Vinod Kumar Vavilapalli added a comment -

        Moving out all non-critical / non-blocker issues that didn't make it out of 2.7.2 into 2.7.3.

        Show
        vinodkv Vinod Kumar Vavilapalli added a comment - Moving out all non-critical / non-blocker issues that didn't make it out of 2.7.2 into 2.7.3.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        Hi Ravindra Kumar Naik, how is this issue going? If you don't have time to update the patch, I'd like to take over your work.

        Show
        ajisakaa Akira Ajisaka added a comment - Hi Ravindra Kumar Naik , how is this issue going? If you don't have time to update the patch, I'd like to take over your work.
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 12s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 9m 28s trunk passed
        +1 compile 0m 39s trunk passed with JDK v1.8.0_72
        +1 compile 0m 37s trunk passed with JDK v1.7.0_95
        +1 checkstyle 0m 27s trunk passed
        +1 mvnsite 0m 44s trunk passed
        +1 mvneclipse 0m 16s trunk passed
        +1 findbugs 1m 30s trunk passed
        +1 javadoc 0m 48s trunk passed with JDK v1.8.0_72
        +1 javadoc 0m 48s trunk passed with JDK v1.7.0_95
        +1 mvninstall 0m 37s the patch passed
        +1 compile 0m 37s the patch passed with JDK v1.8.0_72
        +1 javac 0m 37s the patch passed
        +1 compile 0m 34s the patch passed with JDK v1.7.0_95
        +1 javac 0m 34s the patch passed
        +1 checkstyle 0m 24s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common: patch generated 0 new + 33 unchanged - 3 fixed = 33 total (was 36)
        +1 mvnsite 0m 40s the patch passed
        +1 mvneclipse 0m 14s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 1m 44s the patch passed
        +1 javadoc 0m 44s the patch passed with JDK v1.8.0_72
        +1 javadoc 0m 42s the patch passed with JDK v1.7.0_95
        +1 unit 2m 49s hadoop-yarn-common in the patch passed with JDK v1.8.0_72.
        +1 unit 2m 42s hadoop-yarn-common in the patch passed with JDK v1.7.0_95.
        +1 asflicense 0m 26s Patch does not generate ASF License warnings.
        29m 5s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12788521/YARN-3344.06.patch
        JIRA Issue YARN-3344
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 05b37b5acfb8 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / c7ac25e
        Default Java 1.7.0_95
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
        findbugs v3.0.0
        JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10582/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/10582/console
        Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 12s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 9m 28s trunk passed +1 compile 0m 39s trunk passed with JDK v1.8.0_72 +1 compile 0m 37s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 27s trunk passed +1 mvnsite 0m 44s trunk passed +1 mvneclipse 0m 16s trunk passed +1 findbugs 1m 30s trunk passed +1 javadoc 0m 48s trunk passed with JDK v1.8.0_72 +1 javadoc 0m 48s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 37s the patch passed +1 compile 0m 37s the patch passed with JDK v1.8.0_72 +1 javac 0m 37s the patch passed +1 compile 0m 34s the patch passed with JDK v1.7.0_95 +1 javac 0m 34s the patch passed +1 checkstyle 0m 24s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common: patch generated 0 new + 33 unchanged - 3 fixed = 33 total (was 36) +1 mvnsite 0m 40s the patch passed +1 mvneclipse 0m 14s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 1m 44s the patch passed +1 javadoc 0m 44s the patch passed with JDK v1.8.0_72 +1 javadoc 0m 42s the patch passed with JDK v1.7.0_95 +1 unit 2m 49s hadoop-yarn-common in the patch passed with JDK v1.8.0_72. +1 unit 2m 42s hadoop-yarn-common in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 26s Patch does not generate ASF License warnings. 29m 5s Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12788521/YARN-3344.06.patch JIRA Issue YARN-3344 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 05b37b5acfb8 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / c7ac25e Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10582/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common Console output https://builds.apache.org/job/PreCommit-YARN-Build/10582/console Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        Hi Vinod Kumar Vavilapalli, would you please review the latest patch?

        Show
        ajisakaa Akira Ajisaka added a comment - Hi Vinod Kumar Vavilapalli , would you please review the latest patch?
        Hide
        templedf Daniel Templeton added a comment -

        Looks good to me in general. Thanks for picking the torch back up, Akira Ajisaka.

        In the regex, should we tighten the . to [^)]? Since there is only one close paren in the format, . is technically fine, but I find it generally better to avoid . unless you really need it.

        Show
        templedf Daniel Templeton added a comment - Looks good to me in general. Thanks for picking the torch back up, Akira Ajisaka . In the regex, should we tighten the . to [^)] ? Since there is only one close paren in the format, . is technically fine, but I find it generally better to avoid . unless you really need it.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 16s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 6m 39s trunk passed
        +1 compile 0m 23s trunk passed with JDK v1.8.0_91
        +1 compile 0m 27s trunk passed with JDK v1.7.0_95
        +1 checkstyle 0m 21s trunk passed
        +1 mvnsite 0m 32s trunk passed
        +1 mvneclipse 0m 12s trunk passed
        -1 findbugs 1m 8s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common in trunk has 1 extant Findbugs warnings.
        +1 javadoc 0m 29s trunk passed with JDK v1.8.0_91
        +1 javadoc 0m 32s trunk passed with JDK v1.7.0_95
        +1 mvninstall 0m 26s the patch passed
        +1 compile 0m 21s the patch passed with JDK v1.8.0_91
        +1 javac 0m 21s the patch passed
        +1 compile 0m 25s the patch passed with JDK v1.7.0_95
        +1 javac 0m 25s the patch passed
        -1 checkstyle 0m 20s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common: patch generated 4 new + 153 unchanged - 7 fixed = 157 total (was 160)
        +1 mvnsite 0m 28s the patch passed
        +1 mvneclipse 0m 10s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 1m 19s the patch passed
        +1 javadoc 0m 25s the patch passed with JDK v1.8.0_91
        +1 javadoc 0m 30s the patch passed with JDK v1.7.0_95
        +1 unit 2m 4s hadoop-yarn-common in the patch passed with JDK v1.8.0_91.
        +1 unit 2m 20s hadoop-yarn-common in the patch passed with JDK v1.7.0_95.
        +1 asflicense 0m 18s Patch does not generate ASF License warnings.
        21m 2s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:cf2ee45
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12788521/YARN-3344.06.patch
        JIRA Issue YARN-3344
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 8e2c8b2af1d6 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / acb509b
        Default Java 1.7.0_95
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
        findbugs v3.0.0
        findbugs https://builds.apache.org/job/PreCommit-YARN-Build/11418/artifact/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-warnings.html
        checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/11418/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt
        JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/11418/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/11418/console
        Powered by Apache Yetus 0.2.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 6m 39s trunk passed +1 compile 0m 23s trunk passed with JDK v1.8.0_91 +1 compile 0m 27s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 21s trunk passed +1 mvnsite 0m 32s trunk passed +1 mvneclipse 0m 12s trunk passed -1 findbugs 1m 8s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common in trunk has 1 extant Findbugs warnings. +1 javadoc 0m 29s trunk passed with JDK v1.8.0_91 +1 javadoc 0m 32s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 26s the patch passed +1 compile 0m 21s the patch passed with JDK v1.8.0_91 +1 javac 0m 21s the patch passed +1 compile 0m 25s the patch passed with JDK v1.7.0_95 +1 javac 0m 25s the patch passed -1 checkstyle 0m 20s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common: patch generated 4 new + 153 unchanged - 7 fixed = 157 total (was 160) +1 mvnsite 0m 28s the patch passed +1 mvneclipse 0m 10s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 1m 19s the patch passed +1 javadoc 0m 25s the patch passed with JDK v1.8.0_91 +1 javadoc 0m 30s the patch passed with JDK v1.7.0_95 +1 unit 2m 4s hadoop-yarn-common in the patch passed with JDK v1.8.0_91. +1 unit 2m 20s hadoop-yarn-common in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 18s Patch does not generate ASF License warnings. 21m 2s Subsystem Report/Notes Docker Image:yetus/hadoop:cf2ee45 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12788521/YARN-3344.06.patch JIRA Issue YARN-3344 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 8e2c8b2af1d6 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / acb509b Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-YARN-Build/11418/artifact/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-warnings.html checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/11418/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/11418/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common Console output https://builds.apache.org/job/PreCommit-YARN-Build/11418/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        Nice catch, Daniel Templeton. Updated the patch to address the comment.

        Show
        ajisakaa Akira Ajisaka added a comment - Nice catch, Daniel Templeton . Updated the patch to address the comment.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 14s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 9m 35s trunk passed
        +1 compile 0m 41s trunk passed with JDK v1.8.0_91
        +1 compile 0m 35s trunk passed with JDK v1.7.0_95
        +1 checkstyle 0m 28s trunk passed
        +1 mvnsite 0m 42s trunk passed
        +1 mvneclipse 0m 16s trunk passed
        -1 findbugs 1m 34s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common in trunk has 1 extant Findbugs warnings.
        +1 javadoc 0m 45s trunk passed with JDK v1.8.0_91
        +1 javadoc 0m 47s trunk passed with JDK v1.7.0_95
        +1 mvninstall 0m 36s the patch passed
        +1 compile 0m 38s the patch passed with JDK v1.8.0_91
        +1 javac 0m 38s the patch passed
        +1 compile 0m 33s the patch passed with JDK v1.7.0_95
        +1 javac 0m 33s the patch passed
        -1 checkstyle 0m 27s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common: patch generated 4 new + 153 unchanged - 7 fixed = 157 total (was 160)
        +1 mvnsite 0m 39s the patch passed
        +1 mvneclipse 0m 14s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 1m 46s the patch passed
        +1 javadoc 0m 43s the patch passed with JDK v1.8.0_91
        +1 javadoc 0m 45s the patch passed with JDK v1.7.0_95
        +1 unit 3m 10s hadoop-yarn-common in the patch passed with JDK v1.8.0_91.
        +1 unit 2m 58s hadoop-yarn-common in the patch passed with JDK v1.7.0_95.
        +1 asflicense 0m 24s Patch does not generate ASF License warnings.
        29m 50s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:cf2ee45
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12803545/YARN-3344.07.patch
        JIRA Issue YARN-3344
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux bfe6eba973fb 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / d464f4d
        Default Java 1.7.0_95
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
        findbugs v3.0.0
        findbugs https://builds.apache.org/job/PreCommit-YARN-Build/11425/artifact/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-warnings.html
        checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/11425/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt
        JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/11425/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/11425/console
        Powered by Apache Yetus 0.2.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 14s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 9m 35s trunk passed +1 compile 0m 41s trunk passed with JDK v1.8.0_91 +1 compile 0m 35s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 28s trunk passed +1 mvnsite 0m 42s trunk passed +1 mvneclipse 0m 16s trunk passed -1 findbugs 1m 34s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common in trunk has 1 extant Findbugs warnings. +1 javadoc 0m 45s trunk passed with JDK v1.8.0_91 +1 javadoc 0m 47s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 36s the patch passed +1 compile 0m 38s the patch passed with JDK v1.8.0_91 +1 javac 0m 38s the patch passed +1 compile 0m 33s the patch passed with JDK v1.7.0_95 +1 javac 0m 33s the patch passed -1 checkstyle 0m 27s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common: patch generated 4 new + 153 unchanged - 7 fixed = 157 total (was 160) +1 mvnsite 0m 39s the patch passed +1 mvneclipse 0m 14s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 1m 46s the patch passed +1 javadoc 0m 43s the patch passed with JDK v1.8.0_91 +1 javadoc 0m 45s the patch passed with JDK v1.7.0_95 +1 unit 3m 10s hadoop-yarn-common in the patch passed with JDK v1.8.0_91. +1 unit 2m 58s hadoop-yarn-common in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 24s Patch does not generate ASF License warnings. 29m 50s Subsystem Report/Notes Docker Image:yetus/hadoop:cf2ee45 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12803545/YARN-3344.07.patch JIRA Issue YARN-3344 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux bfe6eba973fb 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / d464f4d Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-YARN-Build/11425/artifact/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-warnings.html checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/11425/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/11425/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common Console output https://builds.apache.org/job/PreCommit-YARN-Build/11425/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
        Hide
        templedf Daniel Templeton added a comment -

        Akira Ajisaka, I'm pretty sure you can get away with just [^)] instead of [^\\)].

        Show
        templedf Daniel Templeton added a comment - Akira Ajisaka , I'm pretty sure you can get away with just [^)] instead of [^\\)] .
        Hide
        ajisakaa Akira Ajisaka added a comment -

        Thanks Daniel. Updated the patch to address your comment.

        Show
        ajisakaa Akira Ajisaka added a comment - Thanks Daniel. Updated the patch to address your comment.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 12s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 7m 25s trunk passed
        +1 compile 0m 30s trunk passed
        +1 checkstyle 0m 22s trunk passed
        +1 mvnsite 0m 35s trunk passed
        +1 mvneclipse 0m 12s trunk passed
        -1 findbugs 1m 3s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common in trunk has 1 extant Findbugs warnings.
        +1 javadoc 0m 30s trunk passed
        +1 mvninstall 0m 28s the patch passed
        +1 compile 0m 28s the patch passed
        +1 javac 0m 28s the patch passed
        -1 checkstyle 0m 18s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common: patch generated 4 new + 154 unchanged - 7 fixed = 158 total (was 161)
        +1 mvnsite 0m 29s the patch passed
        +1 mvneclipse 0m 9s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 1m 6s the patch passed
        +1 javadoc 0m 29s the patch passed
        +1 unit 2m 18s hadoop-yarn-common in the patch passed.
        +1 asflicense 0m 21s Patch does not generate ASF License warnings.
        17m 35s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:2c91fd8
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12804351/YARN-3344.08.patch
        JIRA Issue YARN-3344
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux eb9c68c29c88 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 2c91fd8
        Default Java 1.8.0_91
        findbugs v3.0.0
        findbugs https://builds.apache.org/job/PreCommit-YARN-Build/11493/artifact/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-warnings.html
        checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/11493/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/11493/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/11493/console
        Powered by Apache Yetus 0.2.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 12s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 7m 25s trunk passed +1 compile 0m 30s trunk passed +1 checkstyle 0m 22s trunk passed +1 mvnsite 0m 35s trunk passed +1 mvneclipse 0m 12s trunk passed -1 findbugs 1m 3s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common in trunk has 1 extant Findbugs warnings. +1 javadoc 0m 30s trunk passed +1 mvninstall 0m 28s the patch passed +1 compile 0m 28s the patch passed +1 javac 0m 28s the patch passed -1 checkstyle 0m 18s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common: patch generated 4 new + 154 unchanged - 7 fixed = 158 total (was 161) +1 mvnsite 0m 29s the patch passed +1 mvneclipse 0m 9s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 1m 6s the patch passed +1 javadoc 0m 29s the patch passed +1 unit 2m 18s hadoop-yarn-common in the patch passed. +1 asflicense 0m 21s Patch does not generate ASF License warnings. 17m 35s Subsystem Report/Notes Docker Image:yetus/hadoop:2c91fd8 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12804351/YARN-3344.08.patch JIRA Issue YARN-3344 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux eb9c68c29c88 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 2c91fd8 Default Java 1.8.0_91 findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-YARN-Build/11493/artifact/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-warnings.html checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/11493/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/11493/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common Console output https://builds.apache.org/job/PreCommit-YARN-Build/11493/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
        Hide
        templedf Daniel Templeton added a comment -

        Awesome. Clean up your whitespace issues, and I think you're good to go.

        Show
        templedf Daniel Templeton added a comment - Awesome. Clean up your whitespace issues, and I think you're good to go.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        Clean up your whitespace issues

        Is there any trailing whitespaces in my patch? Jenkins says the patch has no whitespace issues.

        Show
        ajisakaa Akira Ajisaka added a comment - Clean up your whitespace issues Is there any trailing whitespaces in my patch? Jenkins says the patch has no whitespace issues.
        Show
        templedf Daniel Templeton added a comment - See https://builds.apache.org/job/PreCommit-YARN-Build/11493/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt
        Hide
        ajisakaa Akira Ajisaka added a comment -

        Fixed checkstyle issues. Thanks!

        Show
        ajisakaa Akira Ajisaka added a comment - Fixed checkstyle issues. Thanks!
        Hide
        templedf Daniel Templeton added a comment -

        LGTM. +1 (non-binding)

        Show
        templedf Daniel Templeton added a comment - LGTM. +1 (non-binding)
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 14s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 6m 22s trunk passed
        +1 compile 0m 27s trunk passed
        +1 checkstyle 0m 21s trunk passed
        +1 mvnsite 0m 31s trunk passed
        +1 mvneclipse 0m 13s trunk passed
        +1 findbugs 0m 54s trunk passed
        +1 javadoc 0m 29s trunk passed
        +1 mvninstall 0m 26s the patch passed
        +1 compile 0m 25s the patch passed
        +1 javac 0m 25s the patch passed
        +1 checkstyle 0m 18s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common: patch generated 0 new + 142 unchanged - 19 fixed = 142 total (was 161)
        +1 mvnsite 0m 28s the patch passed
        +1 mvneclipse 0m 9s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 1m 1s the patch passed
        +1 javadoc 0m 26s the patch passed
        +1 unit 2m 9s hadoop-yarn-common in the patch passed.
        +1 asflicense 0m 16s Patch does not generate ASF License warnings.
        15m 48s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:2c91fd8
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12804538/YARN-3344.09.patch
        JIRA Issue YARN-3344
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 501bb78d2c06 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 16c07cc
        Default Java 1.8.0_91
        findbugs v3.0.0
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/11518/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/11518/console
        Powered by Apache Yetus 0.2.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 14s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 6m 22s trunk passed +1 compile 0m 27s trunk passed +1 checkstyle 0m 21s trunk passed +1 mvnsite 0m 31s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 0m 54s trunk passed +1 javadoc 0m 29s trunk passed +1 mvninstall 0m 26s the patch passed +1 compile 0m 25s the patch passed +1 javac 0m 25s the patch passed +1 checkstyle 0m 18s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common: patch generated 0 new + 142 unchanged - 19 fixed = 142 total (was 161) +1 mvnsite 0m 28s the patch passed +1 mvneclipse 0m 9s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 1m 1s the patch passed +1 javadoc 0m 26s the patch passed +1 unit 2m 9s hadoop-yarn-common in the patch passed. +1 asflicense 0m 16s Patch does not generate ASF License warnings. 15m 48s Subsystem Report/Notes Docker Image:yetus/hadoop:2c91fd8 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12804538/YARN-3344.09.patch JIRA Issue YARN-3344 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 501bb78d2c06 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 16c07cc Default Java 1.8.0_91 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/11518/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common Console output https://builds.apache.org/job/PreCommit-YARN-Build/11518/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
        Hide
        kasha Karthik Kambatla added a comment -

        +1, checking this in.

        Show
        kasha Karthik Kambatla added a comment - +1, checking this in.
        Hide
        kasha Karthik Kambatla added a comment -

        Just committed this to trunk, branch-2 and branch-2.8.

        Thanks for the contribution, Ravindra Kumar Naik and Akira Ajisaka. Thanks Daniel Templeton and Vinod Kumar Vavilapalli for your reviews.

        Show
        kasha Karthik Kambatla added a comment - Just committed this to trunk, branch-2 and branch-2.8. Thanks for the contribution, Ravindra Kumar Naik and Akira Ajisaka . Thanks Daniel Templeton and Vinod Kumar Vavilapalli for your reviews.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-trunk-Commit #9859 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9859/)
        YARN-3344. Fix warning - procfs stat file is not in the expected format. (kasha: rev 77d5ce9069b9ad64673f04edac9b1b1beddfd403)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/util/TestProcfsBasedProcessTree.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/util/ProcfsBasedProcessTree.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-trunk-Commit #9859 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9859/ ) YARN-3344 . Fix warning - procfs stat file is not in the expected format. (kasha: rev 77d5ce9069b9ad64673f04edac9b1b1beddfd403) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/util/TestProcfsBasedProcessTree.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/util/ProcfsBasedProcessTree.java

          People

          • Assignee:
            ravindra.naik Ravindra Kumar Naik
            Reporter:
            jonbringhurst Jon Bringhurst
          • Votes:
            1 Vote for this issue
            Watchers:
            15 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development