Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-3339

TestDockerContainerExecutor should pull a single image and not the entire centos repository

    Details

    • Type: Test
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.6.0
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: test
    • Labels:
      None
    • Environment:

      Linux

    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      TestDockerContainerExecutor test pulls the entire centos repository which is time consuming.
      Pulling a specific image (e.g. centos7) will be sufficient to run the test successfully and will save time

      1. YARN-3339-trunk.001.patch
        1.0 kB
        Ravindra Kumar Naik
      2. YARN-3339-branch-2.6.0.001.patch
        1.0 kB
        Ravindra Kumar Naik

        Activity

        Hide
        ravindra.naik Ravindra Kumar Naik added a comment -

        Thanks ravi for reviewing and comitting.

        Show
        ravindra.naik Ravindra Kumar Naik added a comment - Thanks ravi for reviewing and comitting.
        Hide
        raviprak Ravi Prakash added a comment -

        Thanks a lot for your contribution Ravindra! I'm sorry I don't seem to have the rights to add you as a contributor on this project. I'll see what I can do to figure that out

        Show
        raviprak Ravi Prakash added a comment - Thanks a lot for your contribution Ravindra! I'm sorry I don't seem to have the rights to add you as a contributor on this project. I'll see what I can do to figure that out
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk #2085 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2085/)
        YARN-3339. TestDockerContainerExecutor should pull a single image and not the entire centos repository. (Ravindra Kumar Naik via raviprak) (raviprak: rev 56085203c43b8f2561bf3745910e03f8ac176a67)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/TestDockerContainerExecutor.java
        • hadoop-yarn-project/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2085 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2085/ ) YARN-3339 . TestDockerContainerExecutor should pull a single image and not the entire centos repository. (Ravindra Kumar Naik via raviprak) (raviprak: rev 56085203c43b8f2561bf3745910e03f8ac176a67) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/TestDockerContainerExecutor.java hadoop-yarn-project/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #135 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/135/)
        YARN-3339. TestDockerContainerExecutor should pull a single image and not the entire centos repository. (Ravindra Kumar Naik via raviprak) (raviprak: rev 56085203c43b8f2561bf3745910e03f8ac176a67)

        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/TestDockerContainerExecutor.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #135 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/135/ ) YARN-3339 . TestDockerContainerExecutor should pull a single image and not the entire centos repository. (Ravindra Kumar Naik via raviprak) (raviprak: rev 56085203c43b8f2561bf3745910e03f8ac176a67) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/TestDockerContainerExecutor.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #2067 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2067/)
        YARN-3339. TestDockerContainerExecutor should pull a single image and not the entire centos repository. (Ravindra Kumar Naik via raviprak) (raviprak: rev 56085203c43b8f2561bf3745910e03f8ac176a67)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/TestDockerContainerExecutor.java
        • hadoop-yarn-project/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2067 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2067/ ) YARN-3339 . TestDockerContainerExecutor should pull a single image and not the entire centos repository. (Ravindra Kumar Naik via raviprak) (raviprak: rev 56085203c43b8f2561bf3745910e03f8ac176a67) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/TestDockerContainerExecutor.java hadoop-yarn-project/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #126 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/126/)
        YARN-3339. TestDockerContainerExecutor should pull a single image and not the entire centos repository. (Ravindra Kumar Naik via raviprak) (raviprak: rev 56085203c43b8f2561bf3745910e03f8ac176a67)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/TestDockerContainerExecutor.java
        • hadoop-yarn-project/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #126 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/126/ ) YARN-3339 . TestDockerContainerExecutor should pull a single image and not the entire centos repository. (Ravindra Kumar Naik via raviprak) (raviprak: rev 56085203c43b8f2561bf3745910e03f8ac176a67) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/TestDockerContainerExecutor.java hadoop-yarn-project/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #135 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/135/)
        YARN-3339. TestDockerContainerExecutor should pull a single image and not the entire centos repository. (Ravindra Kumar Naik via raviprak) (raviprak: rev 56085203c43b8f2561bf3745910e03f8ac176a67)

        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/TestDockerContainerExecutor.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #135 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/135/ ) YARN-3339 . TestDockerContainerExecutor should pull a single image and not the entire centos repository. (Ravindra Kumar Naik via raviprak) (raviprak: rev 56085203c43b8f2561bf3745910e03f8ac176a67) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/TestDockerContainerExecutor.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk #869 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/869/)
        YARN-3339. TestDockerContainerExecutor should pull a single image and not the entire centos repository. (Ravindra Kumar Naik via raviprak) (raviprak: rev 56085203c43b8f2561bf3745910e03f8ac176a67)

        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/TestDockerContainerExecutor.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #869 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/869/ ) YARN-3339 . TestDockerContainerExecutor should pull a single image and not the entire centos repository. (Ravindra Kumar Naik via raviprak) (raviprak: rev 56085203c43b8f2561bf3745910e03f8ac176a67) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/TestDockerContainerExecutor.java
        Hide
        ravindra.naik Ravindra Kumar Naik added a comment -

        Thanks for the information.

        Show
        ravindra.naik Ravindra Kumar Naik added a comment - Thanks for the information.
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #7339 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7339/)
        YARN-3339. TestDockerContainerExecutor should pull a single image and not the entire centos repository. (Ravindra Kumar Naik via raviprak) (raviprak: rev 56085203c43b8f2561bf3745910e03f8ac176a67)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/TestDockerContainerExecutor.java
        • hadoop-yarn-project/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #7339 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7339/ ) YARN-3339 . TestDockerContainerExecutor should pull a single image and not the entire centos repository. (Ravindra Kumar Naik via raviprak) (raviprak: rev 56085203c43b8f2561bf3745910e03f8ac176a67) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/TestDockerContainerExecutor.java hadoop-yarn-project/CHANGES.txt
        Hide
        raviprak Ravi Prakash added a comment -

        Also, the fix version is set by the committer. Its the target version you should set (to one that has yet to be released) as a contributor, so that when a release manager looks at what is targeted to the next release, they'd see your JIRA

        Show
        raviprak Ravi Prakash added a comment - Also, the fix version is set by the committer. Its the target version you should set (to one that has yet to be released) as a contributor, so that when a release manager looks at what is targeted to the next release, they'd see your JIRA
        Hide
        raviprak Ravi Prakash added a comment -

        Thanks for the review Abin!

        Thanks a lot for the contribution Ravindra! I've merged this into trunk and branch-2 . Since branch-2.7 has already been cut, it'll only make it to 2.8

        Just fyi Ravindra, you need only provide a patch for a specific branch if the trunk patch doesn't apply cleanly. In this case the trunk patch was sufficient. Thanks again

        Show
        raviprak Ravi Prakash added a comment - Thanks for the review Abin! Thanks a lot for the contribution Ravindra! I've merged this into trunk and branch-2 . Since branch-2.7 has already been cut, it'll only make it to 2.8 Just fyi Ravindra, you need only provide a patch for a specific branch if the trunk patch doesn't apply cleanly. In this case the trunk patch was sufficient. Thanks again
        Hide
        ashahab Abin Shahab added a comment -

        Looks great! LGTM!

        Show
        ashahab Abin Shahab added a comment - Looks great! LGTM!
        Hide
        raviprak Ravi Prakash added a comment -

        Looks good to me. Will commit by EOD

        Show
        raviprak Ravi Prakash added a comment - Looks good to me. Will commit by EOD
        Hide
        ravindra.naik Ravindra Kumar Naik added a comment -

        Varun Vasudev Chen He Ravi Prakash its a small fix, could anyone please review it?

        Show
        ravindra.naik Ravindra Kumar Naik added a comment - Varun Vasudev Chen He Ravi Prakash its a small fix, could anyone please review it?
        Hide
        hadoopqa Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12704141/YARN-3339-branch-2.6.0.001.patch
        against trunk revision ff83ae7.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. There were no new javadoc warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager.

        Test results: https://builds.apache.org/job/PreCommit-YARN-Build/6937//testReport/
        Console output: https://builds.apache.org/job/PreCommit-YARN-Build/6937//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12704141/YARN-3339-branch-2.6.0.001.patch against trunk revision ff83ae7. +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager. Test results: https://builds.apache.org/job/PreCommit-YARN-Build/6937//testReport/ Console output: https://builds.apache.org/job/PreCommit-YARN-Build/6937//console This message is automatically generated.
        Hide
        ravindra.naik Ravindra Kumar Naik added a comment -

        pull the latest centos image (not all the centos images) for testing in TestDockerContainerExecutor

        Show
        ravindra.naik Ravindra Kumar Naik added a comment - pull the latest centos image (not all the centos images) for testing in TestDockerContainerExecutor
        Hide
        ravindra.naik Ravindra Kumar Naik added a comment -

        pull the latest centos image for testing (not all the centos images)

        Show
        ravindra.naik Ravindra Kumar Naik added a comment - pull the latest centos image for testing (not all the centos images)

          People

          • Assignee:
            ravindra.naik Ravindra Kumar Naik
            Reporter:
            ravindra.naik Ravindra Kumar Naik
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development