Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-3287

TimelineClient kerberos authentication failure uses wrong login context.

    Details

    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      TimelineClientImpl:doPosting is not wrapped in a doAs, which can cause failure for yarn clients to create timeline domains during job submission.

      1. YARN-3287.3.patch
        20 kB
        Jonathan Eagles
      2. YARN-3287.2.patch
        20 kB
        Jonathan Eagles
      3. YARN-3287.1.patch
        20 kB
        Jonathan Eagles
      4. timeline.patch
        7 kB
        Jonathan Eagles

        Issue Links

          Activity

          Hide
          vinodkv Vinod Kumar Vavilapalli added a comment -

          Pulled this into 2.6.1. Ran compilation and TestTimelineAuthenticationFilter before the push. Patch applied mostly cleanly, except for a minor conflict in TimelineClientImpl.

          Show
          vinodkv Vinod Kumar Vavilapalli added a comment - Pulled this into 2.6.1. Ran compilation and TestTimelineAuthenticationFilter before the push. Patch applied mostly cleanly, except for a minor conflict in TimelineClientImpl.
          Hide
          zjshen Zhijie Shen added a comment -

          Have filed YARN-3522 already.

          Show
          zjshen Zhijie Shen added a comment - Have filed YARN-3522 already.
          Hide
          jeagles Jonathan Eagles added a comment -

          Should I file a JIRA to correct the distributed shell.

          Show
          jeagles Jonathan Eagles added a comment - Should I file a JIRA to correct the distributed shell.
          Hide
          zjshen Zhijie Shen added a comment -

          It breaks the timeline access control of distributed shell. In distributed shell AM:

              if (conf.getBoolean(YarnConfiguration.TIMELINE_SERVICE_ENABLED,
                YarnConfiguration.DEFAULT_TIMELINE_SERVICE_ENABLED)) {
                // Creating the Timeline Client
                timelineClient = TimelineClient.createTimelineClient();
                timelineClient.init(conf);
                timelineClient.start();
              } else {
                timelineClient = null;
                LOG.warn("Timeline service is not enabled");
              }
          
                ugi.doAs(new PrivilegedExceptionAction<TimelinePutResponse>() {
                  @Override
                  public TimelinePutResponse run() throws Exception {
                    return timelineClient.putEntities(entity);
                  }
                });
          

          This Jira changes the timeline client to get the right ugi at serviceInit, but DS AM still doesn't use submitter ugi to init timeline client, but use the ugi for each put entity call. It result in the wrong user of the put request.

          Show
          zjshen Zhijie Shen added a comment - It breaks the timeline access control of distributed shell. In distributed shell AM: if (conf.getBoolean(YarnConfiguration.TIMELINE_SERVICE_ENABLED, YarnConfiguration.DEFAULT_TIMELINE_SERVICE_ENABLED)) { // Creating the Timeline Client timelineClient = TimelineClient.createTimelineClient(); timelineClient.init(conf); timelineClient.start(); } else { timelineClient = null ; LOG.warn( "Timeline service is not enabled" ); } ugi.doAs( new PrivilegedExceptionAction<TimelinePutResponse>() { @Override public TimelinePutResponse run() throws Exception { return timelineClient.putEntities(entity); } }); This Jira changes the timeline client to get the right ugi at serviceInit, but DS AM still doesn't use submitter ugi to init timeline client, but use the ugi for each put entity call. It result in the wrong user of the put request.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk #2078 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2078/)
          YARN-3287. Made TimelineClient put methods do as the correct login context. Contributed by Daryn Sharp and Jonathan Eagles. (zjshen: rev d6e05c5ee26feefc17267b7c9db1e2a3dbdef117)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/client/api/impl/TimelineClientImpl.java
          • hadoop-yarn-project/CHANGES.txt
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/test/java/org/apache/hadoop/yarn/server/timeline/security/TestTimelineAuthenticationFilter.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2078 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2078/ ) YARN-3287 . Made TimelineClient put methods do as the correct login context. Contributed by Daryn Sharp and Jonathan Eagles. (zjshen: rev d6e05c5ee26feefc17267b7c9db1e2a3dbdef117) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/client/api/impl/TimelineClientImpl.java hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/test/java/org/apache/hadoop/yarn/server/timeline/security/TestTimelineAuthenticationFilter.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #128 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/128/)
          YARN-3287. Made TimelineClient put methods do as the correct login context. Contributed by Daryn Sharp and Jonathan Eagles. (zjshen: rev d6e05c5ee26feefc17267b7c9db1e2a3dbdef117)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/test/java/org/apache/hadoop/yarn/server/timeline/security/TestTimelineAuthenticationFilter.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/client/api/impl/TimelineClientImpl.java
          • hadoop-yarn-project/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #128 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/128/ ) YARN-3287 . Made TimelineClient put methods do as the correct login context. Contributed by Daryn Sharp and Jonathan Eagles. (zjshen: rev d6e05c5ee26feefc17267b7c9db1e2a3dbdef117) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/test/java/org/apache/hadoop/yarn/server/timeline/security/TestTimelineAuthenticationFilter.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/client/api/impl/TimelineClientImpl.java hadoop-yarn-project/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #119 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/119/)
          YARN-3287. Made TimelineClient put methods do as the correct login context. Contributed by Daryn Sharp and Jonathan Eagles. (zjshen: rev d6e05c5ee26feefc17267b7c9db1e2a3dbdef117)

          • hadoop-yarn-project/CHANGES.txt
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/client/api/impl/TimelineClientImpl.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/test/java/org/apache/hadoop/yarn/server/timeline/security/TestTimelineAuthenticationFilter.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #119 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/119/ ) YARN-3287 . Made TimelineClient put methods do as the correct login context. Contributed by Daryn Sharp and Jonathan Eagles. (zjshen: rev d6e05c5ee26feefc17267b7c9db1e2a3dbdef117) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/client/api/impl/TimelineClientImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/test/java/org/apache/hadoop/yarn/server/timeline/security/TestTimelineAuthenticationFilter.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk #2060 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2060/)
          YARN-3287. Made TimelineClient put methods do as the correct login context. Contributed by Daryn Sharp and Jonathan Eagles. (zjshen: rev d6e05c5ee26feefc17267b7c9db1e2a3dbdef117)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/test/java/org/apache/hadoop/yarn/server/timeline/security/TestTimelineAuthenticationFilter.java
          • hadoop-yarn-project/CHANGES.txt
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/client/api/impl/TimelineClientImpl.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2060 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2060/ ) YARN-3287 . Made TimelineClient put methods do as the correct login context. Contributed by Daryn Sharp and Jonathan Eagles. (zjshen: rev d6e05c5ee26feefc17267b7c9db1e2a3dbdef117) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/test/java/org/apache/hadoop/yarn/server/timeline/security/TestTimelineAuthenticationFilter.java hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/client/api/impl/TimelineClientImpl.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk #862 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/862/)
          YARN-3287. Made TimelineClient put methods do as the correct login context. Contributed by Daryn Sharp and Jonathan Eagles. (zjshen: rev d6e05c5ee26feefc17267b7c9db1e2a3dbdef117)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/client/api/impl/TimelineClientImpl.java
          • hadoop-yarn-project/CHANGES.txt
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/test/java/org/apache/hadoop/yarn/server/timeline/security/TestTimelineAuthenticationFilter.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #862 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/862/ ) YARN-3287 . Made TimelineClient put methods do as the correct login context. Contributed by Daryn Sharp and Jonathan Eagles. (zjshen: rev d6e05c5ee26feefc17267b7c9db1e2a3dbdef117) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/client/api/impl/TimelineClientImpl.java hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/test/java/org/apache/hadoop/yarn/server/timeline/security/TestTimelineAuthenticationFilter.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #128 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/128/)
          YARN-3287. Made TimelineClient put methods do as the correct login context. Contributed by Daryn Sharp and Jonathan Eagles. (zjshen: rev d6e05c5ee26feefc17267b7c9db1e2a3dbdef117)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/client/api/impl/TimelineClientImpl.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/test/java/org/apache/hadoop/yarn/server/timeline/security/TestTimelineAuthenticationFilter.java
          • hadoop-yarn-project/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #128 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/128/ ) YARN-3287 . Made TimelineClient put methods do as the correct login context. Contributed by Daryn Sharp and Jonathan Eagles. (zjshen: rev d6e05c5ee26feefc17267b7c9db1e2a3dbdef117) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/client/api/impl/TimelineClientImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/test/java/org/apache/hadoop/yarn/server/timeline/security/TestTimelineAuthenticationFilter.java hadoop-yarn-project/CHANGES.txt
          Hide
          jeagles Jonathan Eagles added a comment -

          Thanks, Zhijie Shen

          Show
          jeagles Jonathan Eagles added a comment - Thanks, Zhijie Shen
          Hide
          zjshen Zhijie Shen added a comment -

          Merge it into branch-2.7 too.

          Show
          zjshen Zhijie Shen added a comment - Merge it into branch-2.7 too.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #7291 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7291/)
          YARN-3287. Made TimelineClient put methods do as the correct login context. Contributed by Daryn Sharp and Jonathan Eagles. (zjshen: rev d6e05c5ee26feefc17267b7c9db1e2a3dbdef117)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/test/java/org/apache/hadoop/yarn/server/timeline/security/TestTimelineAuthenticationFilter.java
          • hadoop-yarn-project/CHANGES.txt
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/client/api/impl/TimelineClientImpl.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #7291 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7291/ ) YARN-3287 . Made TimelineClient put methods do as the correct login context. Contributed by Daryn Sharp and Jonathan Eagles. (zjshen: rev d6e05c5ee26feefc17267b7c9db1e2a3dbdef117) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/test/java/org/apache/hadoop/yarn/server/timeline/security/TestTimelineAuthenticationFilter.java hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/client/api/impl/TimelineClientImpl.java
          Hide
          zjshen Zhijie Shen added a comment -

          Committed the patch to trunk and branch-2. Thanks for the patch, Daryn and Jonathan!

          Show
          zjshen Zhijie Shen added a comment - Committed the patch to trunk and branch-2. Thanks for the patch, Daryn and Jonathan!
          Hide
          zjshen Zhijie Shen added a comment -

          +1 for the last patch. Will commit it.

          Show
          zjshen Zhijie Shen added a comment - +1 for the last patch. Will commit it.
          Hide
          hadoopqa Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12703485/YARN-3287.3.patch
          against trunk revision 3241fc2.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 1 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice.

          Test results: https://builds.apache.org/job/PreCommit-YARN-Build/6896//testReport/
          Console output: https://builds.apache.org/job/PreCommit-YARN-Build/6896//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12703485/YARN-3287.3.patch against trunk revision 3241fc2. +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice. Test results: https://builds.apache.org/job/PreCommit-YARN-Build/6896//testReport/ Console output: https://builds.apache.org/job/PreCommit-YARN-Build/6896//console This message is automatically generated.
          Hide
          jeagles Jonathan Eagles added a comment -

          Zhijie Shen, trying to unwrap as before. Let me know if this is what you are intending.

          Show
          jeagles Jonathan Eagles added a comment - Zhijie Shen , trying to unwrap as before. Let me know if this is what you are intending.
          Hide
          zjshen Zhijie Shen added a comment -

          I double checked the oozie use case. It seems that for each individual job, oozie server will create a separate client to start the MR job. The change should be safe then.

          Thanks for the patch, Jon! It's almost fine to me. Just one nit.

          1. In private ClientResponse doPosting(Object obj, String path), doAs op will throw UndeclaredThrowableException, shall we capture and unwrap it as before.

          332	    } catch (InterruptedException ie) {
          333	      throw new IOException(ie);
          314	    }
          
          Show
          zjshen Zhijie Shen added a comment - I double checked the oozie use case. It seems that for each individual job, oozie server will create a separate client to start the MR job. The change should be safe then. Thanks for the patch, Jon! It's almost fine to me. Just one nit. 1. In private ClientResponse doPosting(Object obj, String path), doAs op will throw UndeclaredThrowableException, shall we capture and unwrap it as before. 332 } catch (InterruptedException ie) { 333 throw new IOException(ie); 314 }
          Hide
          zjshen Zhijie Shen added a comment -

          Sure, I'll take a look again.

          Show
          zjshen Zhijie Shen added a comment - Sure, I'll take a look again.
          Hide
          jeagles Jonathan Eagles added a comment -

          Zhijie Shen, can you have another looks now that I have up-merged and added sufficient tests to test this change?

          Show
          jeagles Jonathan Eagles added a comment - Zhijie Shen , can you have another looks now that I have up-merged and added sufficient tests to test this change?
          Hide
          hadoopqa Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12703213/YARN-3287.2.patch
          against trunk revision 608ebd5.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 1 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice.

          Test results: https://builds.apache.org/job/PreCommit-YARN-Build/6886//testReport/
          Console output: https://builds.apache.org/job/PreCommit-YARN-Build/6886//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12703213/YARN-3287.2.patch against trunk revision 608ebd5. +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice. Test results: https://builds.apache.org/job/PreCommit-YARN-Build/6886//testReport/ Console output: https://builds.apache.org/job/PreCommit-YARN-Build/6886//console This message is automatically generated.
          Hide
          jeagles Jonathan Eagles added a comment -

          Zhijie Shen, I have posted a patch that should apply successfully. Please have a review when you get a chance.

          Show
          jeagles Jonathan Eagles added a comment - Zhijie Shen , I have posted a patch that should apply successfully. Please have a review when you get a chance.
          Hide
          zjshen Zhijie Shen added a comment -

          Thanks for updating the patch. I'll check it out. BTW, I guess this patch has conflicted with YARN-3227.

          Show
          zjshen Zhijie Shen added a comment - Thanks for updating the patch. I'll check it out. BTW, I guess this patch has conflicted with YARN-3227 .
          Hide
          jeagles Jonathan Eagles added a comment -

          Zhijie Shen, the cache ugi is to mach the usage of other clients such as dfsclient. In this case, there is a latent bug that is fixed that prevents makes you think that reusing a client in different doAs contexts is correct. However, the delegation token is only valid for the initial connection. The tests are modified to show this correct usage. Daryn mentioned the realUgi != null can be a better check since the PROXY word can be manipulated by some scenarios that will cause it to fail.

          Patch is up and runs successfully on my box. I have reused the minikdc access the parameterized run to cut the test time down considerably.

          Jon

          Show
          jeagles Jonathan Eagles added a comment - Zhijie Shen , the cache ugi is to mach the usage of other clients such as dfsclient. In this case, there is a latent bug that is fixed that prevents makes you think that reusing a client in different doAs contexts is correct. However, the delegation token is only valid for the initial connection. The tests are modified to show this correct usage. Daryn mentioned the realUgi != null can be a better check since the PROXY word can be manipulated by some scenarios that will cause it to fail. Patch is up and runs successfully on my box. I have reused the minikdc access the parameterized run to cut the test time down considerably. Jon
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12703180/YARN-3287.1.patch
          against trunk revision 608ebd5.

          -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-YARN-Build/6885//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12703180/YARN-3287.1.patch against trunk revision 608ebd5. -1 patch . The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-YARN-Build/6885//console This message is automatically generated.
          Hide
          zjshen Zhijie Shen added a comment -

          Btw, getAuthenticationMethod() == UserGroupInformation.AuthenticationMethod.PROXY is equivalent to realUgi != null, right?

          Show
          zjshen Zhijie Shen added a comment - Btw, getAuthenticationMethod() == UserGroupInformation.AuthenticationMethod.PROXY is equivalent to realUgi != null , right?
          Hide
          zjshen Zhijie Shen added a comment - - edited

          One concern: moving ugi computation into init will make the client only work for the user who inits it. It cannot be shared with the other users. For example, if RM want to reuse one client to publish data on behalf of different application users.

          Show
          zjshen Zhijie Shen added a comment - - edited One concern: moving ugi computation into init will make the client only work for the user who inits it. It cannot be shared with the other users. For example, if RM want to reuse one client to publish data on behalf of different application users.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12702897/timeline.patch
          against trunk revision 952640f.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common.

          Test results: https://builds.apache.org/job/PreCommit-YARN-Build/6869//testReport/
          Console output: https://builds.apache.org/job/PreCommit-YARN-Build/6869//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12702897/timeline.patch against trunk revision 952640f. +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common. Test results: https://builds.apache.org/job/PreCommit-YARN-Build/6869//testReport/ Console output: https://builds.apache.org/job/PreCommit-YARN-Build/6869//console This message is automatically generated.
          Hide
          jeagles Jonathan Eagles added a comment -

          posting this file on daryn's behalf.

          Show
          jeagles Jonathan Eagles added a comment - posting this file on daryn's behalf.

            People

            • Assignee:
              daryn Daryn Sharp
              Reporter:
              jeagles Jonathan Eagles
            • Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development