[YARN-3241] FairScheduler handles "invalid" queue names inconsistently

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.8.0, 3.0.0-alpha1
• Component/s: fairscheduler
• Hadoop Flags: Incompatible change
• Release Note: FairScheduler does not allow queue names with leading or tailing spaces or empty sub-queue names anymore.
• Assignee: Zhihai Xu
• Reporter: Zhihai Xu
• Created: 21/Feb/15 06:18
• Updated: 30/Aug/16 01:27
• Resolved: 23/Mar/15 20:37

Description

Leading space, trailing space and empty sub queue name may cause MetricsException(Metrics source XXX already exists! ) when add application to FairScheduler.
The reason is because QueueMetrics parse the queue name different from the QueueManager.
QueueMetrics use Q_SPLITTER to parse queue name, it will remove Leading space and trailing space in the sub queue name, It will also remove empty sub queue name.

  static final Splitter Q_SPLITTER =
      Splitter.on('.').omitEmptyStrings().trimResults(); 

But QueueManager won't remove Leading space, trailing space and empty sub queue name.
This will cause out of sync between FSQueue and FSQueueMetrics.
QueueManager will think two queue names are different so it will try to create a new queue.
But FSQueueMetrics will treat these two queue names as same queue which will create "Metrics source XXX already exists!" MetricsException.

Issue Links

• duplicates: YARN-3843 Fair Scheduler should not accept apps with space keys as queue name