[YARN-3207] secondary filter matches entites which do not have the key being filtered for.

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.7.0, 2.6.1, 3.0.0-alpha1
• Component/s: timelineserver
• Labels: 2.6.1-candidate
• Assignee: Zhijie Shen
• Reporter: Prakash Ramachandran
• Created: 17/Feb/15 18:39
• Updated: 30/Aug/16 01:27
• Resolved: 22/Feb/15 00:24

Description

in the leveldb implementation of the TimelineStore the secondary filter matches entities where the key being searched for is not present.

ex query from tez ui
http://uvm:8188/ws/v1/timeline/TEZ_DAG_ID/?limit=1&secondaryFilter=foo:bar

will match and return the entity even though there is no entity with otherinfo.foo defined.

the issue seems to be in

LeveldbTimelineStore:675

if (vs != null && !vs.contains(filter.getValue())) {
  filterPassed = false;
  break;
}

this should be IMHO
vs == null || !vs.contains(filter.getValue())

Issue Links

• is depended upon by: TEZ-2094 TEZ-UI Running Task/TaskAttempt are not excluded when choosing other status in the Dropdownlist
• is duplicated by: YARN-1916 Leveldb timeline store applies secondary filters incorrectly