Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-3148

Allow CORS related headers to passthrough in WebAppProxyServlet

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.7.0
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      currently the WebAppProxyServlet filters the request headers as defined by passThroughHeaders. Tez UI is building a webapp which using rest api to fetch data from the am via the rm tracking url.

      for this purpose it would be nice to have additional headers allowed especially the ones related to CORS. A few of them that would help are

      • Origin
      • Access-Control-Request-Method
      • Access-Control-Request-Headers
      1. YARN-3148.001.patch
        1 kB
        Varun Saxena
      2. YARN-3148.02.patch
        5 kB
        Varun Saxena
      3. YARN-3148.03.patch
        5 kB
        Varun Saxena
      4. YARN-3148.04.patch
        5 kB
        Varun Saxena

        Activity

        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Hdfs-trunk #2159 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2159/)
        YARN-3148. Allow CORS related headers to passthrough in (devaraj: rev ebb9a82519c622bb898e1eec5798c2298c726694)

        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy/src/test/java/org/apache/hadoop/yarn/server/webproxy/TestWebAppProxyServlet.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy/src/main/java/org/apache/hadoop/yarn/server/webproxy/WebAppProxyServlet.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Hdfs-trunk #2159 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2159/ ) YARN-3148 . Allow CORS related headers to passthrough in (devaraj: rev ebb9a82519c622bb898e1eec5798c2298c726694) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy/src/test/java/org/apache/hadoop/yarn/server/webproxy/TestWebAppProxyServlet.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy/src/main/java/org/apache/hadoop/yarn/server/webproxy/WebAppProxyServlet.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk #2177 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2177/)
        YARN-3148. Allow CORS related headers to passthrough in (devaraj: rev ebb9a82519c622bb898e1eec5798c2298c726694)

        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy/src/main/java/org/apache/hadoop/yarn/server/webproxy/WebAppProxyServlet.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy/src/test/java/org/apache/hadoop/yarn/server/webproxy/TestWebAppProxyServlet.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2177 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2177/ ) YARN-3148 . Allow CORS related headers to passthrough in (devaraj: rev ebb9a82519c622bb898e1eec5798c2298c726694) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy/src/main/java/org/apache/hadoop/yarn/server/webproxy/WebAppProxyServlet.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy/src/test/java/org/apache/hadoop/yarn/server/webproxy/TestWebAppProxyServlet.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #229 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/229/)
        YARN-3148. Allow CORS related headers to passthrough in (devaraj: rev ebb9a82519c622bb898e1eec5798c2298c726694)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy/src/main/java/org/apache/hadoop/yarn/server/webproxy/WebAppProxyServlet.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy/src/test/java/org/apache/hadoop/yarn/server/webproxy/TestWebAppProxyServlet.java
        • hadoop-yarn-project/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #229 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/229/ ) YARN-3148 . Allow CORS related headers to passthrough in (devaraj: rev ebb9a82519c622bb898e1eec5798c2298c726694) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy/src/main/java/org/apache/hadoop/yarn/server/webproxy/WebAppProxyServlet.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy/src/test/java/org/apache/hadoop/yarn/server/webproxy/TestWebAppProxyServlet.java hadoop-yarn-project/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #220 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/220/)
        YARN-3148. Allow CORS related headers to passthrough in (devaraj: rev ebb9a82519c622bb898e1eec5798c2298c726694)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy/src/main/java/org/apache/hadoop/yarn/server/webproxy/WebAppProxyServlet.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy/src/test/java/org/apache/hadoop/yarn/server/webproxy/TestWebAppProxyServlet.java
        • hadoop-yarn-project/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #220 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/220/ ) YARN-3148 . Allow CORS related headers to passthrough in (devaraj: rev ebb9a82519c622bb898e1eec5798c2298c726694) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy/src/main/java/org/apache/hadoop/yarn/server/webproxy/WebAppProxyServlet.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy/src/test/java/org/apache/hadoop/yarn/server/webproxy/TestWebAppProxyServlet.java hadoop-yarn-project/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #231 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/231/)
        YARN-3148. Allow CORS related headers to passthrough in (devaraj: rev ebb9a82519c622bb898e1eec5798c2298c726694)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy/src/main/java/org/apache/hadoop/yarn/server/webproxy/WebAppProxyServlet.java
        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy/src/test/java/org/apache/hadoop/yarn/server/webproxy/TestWebAppProxyServlet.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #231 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/231/ ) YARN-3148 . Allow CORS related headers to passthrough in (devaraj: rev ebb9a82519c622bb898e1eec5798c2298c726694) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy/src/main/java/org/apache/hadoop/yarn/server/webproxy/WebAppProxyServlet.java hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy/src/test/java/org/apache/hadoop/yarn/server/webproxy/TestWebAppProxyServlet.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk #961 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/961/)
        YARN-3148. Allow CORS related headers to passthrough in (devaraj: rev ebb9a82519c622bb898e1eec5798c2298c726694)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy/src/test/java/org/apache/hadoop/yarn/server/webproxy/TestWebAppProxyServlet.java
        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy/src/main/java/org/apache/hadoop/yarn/server/webproxy/WebAppProxyServlet.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #961 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/961/ ) YARN-3148 . Allow CORS related headers to passthrough in (devaraj: rev ebb9a82519c622bb898e1eec5798c2298c726694) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy/src/test/java/org/apache/hadoop/yarn/server/webproxy/TestWebAppProxyServlet.java hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy/src/main/java/org/apache/hadoop/yarn/server/webproxy/WebAppProxyServlet.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #8033 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8033/)
        YARN-3148. Allow CORS related headers to passthrough in (devaraj: rev ebb9a82519c622bb898e1eec5798c2298c726694)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy/src/test/java/org/apache/hadoop/yarn/server/webproxy/TestWebAppProxyServlet.java
        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy/src/main/java/org/apache/hadoop/yarn/server/webproxy/WebAppProxyServlet.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8033 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8033/ ) YARN-3148 . Allow CORS related headers to passthrough in (devaraj: rev ebb9a82519c622bb898e1eec5798c2298c726694) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy/src/test/java/org/apache/hadoop/yarn/server/webproxy/TestWebAppProxyServlet.java hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy/src/main/java/org/apache/hadoop/yarn/server/webproxy/WebAppProxyServlet.java
        Hide
        varun_saxena Varun Saxena added a comment -

        Thanks Devaraj K for the commit

        Show
        varun_saxena Varun Saxena added a comment - Thanks Devaraj K for the commit
        Hide
        devaraj.k Devaraj K added a comment -

        Thanks Varun Saxena for the patch and Prakash Ramachandran for reporting.

        Thanks Li Lu (inactive) and Robert Joseph Evans for your review/comments.

        Committed to trunk and branch-2.

        Show
        devaraj.k Devaraj K added a comment - Thanks Varun Saxena for the patch and Prakash Ramachandran for reporting. Thanks Li Lu (inactive) and Robert Joseph Evans for your review/comments. Committed to trunk and branch-2.
        Hide
        devaraj.k Devaraj K added a comment -

        +1 for the latest patch, will commit it shortly.

        Show
        devaraj.k Devaraj K added a comment - +1 for the latest patch, will commit it shortly.
        Hide
        hadoopqa Hadoop QA added a comment -



        +1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 14m 37s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 7m 35s There were no new javac warning messages.
        +1 javadoc 9m 37s There were no new javadoc warning messages.
        +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 0m 22s There were no new checkstyle issues.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 36s mvn install still works.
        +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
        +1 findbugs 0m 37s The patch does not introduce any new Findbugs (version 2.0.3) warnings.
        +1 yarn tests 0m 21s Tests passed in hadoop-yarn-server-web-proxy.
            35m 44s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12731578/YARN-3148.04.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 4536399
        hadoop-yarn-server-web-proxy test log https://builds.apache.org/job/PreCommit-YARN-Build/7852/artifact/patchprocess/testrun_hadoop-yarn-server-web-proxy.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/7852/testReport/
        Java 1.7.0_55
        uname Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/7852/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 pre-patch 14m 37s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 35s There were no new javac warning messages. +1 javadoc 9m 37s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 0m 22s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 36s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 0m 37s The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 yarn tests 0m 21s Tests passed in hadoop-yarn-server-web-proxy.     35m 44s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12731578/YARN-3148.04.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 4536399 hadoop-yarn-server-web-proxy test log https://builds.apache.org/job/PreCommit-YARN-Build/7852/artifact/patchprocess/testrun_hadoop-yarn-server-web-proxy.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/7852/testReport/ Java 1.7.0_55 uname Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-YARN-Build/7852/console This message was automatically generated.
        Hide
        varun_saxena Varun Saxena added a comment -

        One extra warning added. Will upload a new patch

        Show
        varun_saxena Varun Saxena added a comment - One extra warning added. Will upload a new patch
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 15m 2s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        -1 javac 7m 51s The applied patch generated 122 additional warning messages.
        +1 javadoc 9m 52s There were no new javadoc warning messages.
        +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 0m 21s There were no new checkstyle issues.
        +1 whitespace 0m 1s The patch has no lines that end in whitespace.
        +1 install 1m 38s mvn install still works.
        +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
        +1 findbugs 0m 37s The patch does not introduce any new Findbugs (version 2.0.3) warnings.
        +1 yarn tests 0m 22s Tests passed in hadoop-yarn-server-web-proxy.
            36m 44s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12731492/YARN-3148.03.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 3cefc02
        javac https://builds.apache.org/job/PreCommit-YARN-Build/7816/artifact/patchprocess/diffJavacWarnings.txt
        hadoop-yarn-server-web-proxy test log https://builds.apache.org/job/PreCommit-YARN-Build/7816/artifact/patchprocess/testrun_hadoop-yarn-server-web-proxy.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/7816/testReport/
        Java 1.7.0_55
        uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/7816/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 15m 2s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. -1 javac 7m 51s The applied patch generated 122 additional warning messages. +1 javadoc 9m 52s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 0m 21s There were no new checkstyle issues. +1 whitespace 0m 1s The patch has no lines that end in whitespace. +1 install 1m 38s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 0m 37s The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 yarn tests 0m 22s Tests passed in hadoop-yarn-server-web-proxy.     36m 44s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12731492/YARN-3148.03.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 3cefc02 javac https://builds.apache.org/job/PreCommit-YARN-Build/7816/artifact/patchprocess/diffJavacWarnings.txt hadoop-yarn-server-web-proxy test log https://builds.apache.org/job/PreCommit-YARN-Build/7816/artifact/patchprocess/testrun_hadoop-yarn-server-web-proxy.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/7816/testReport/ Java 1.7.0_55 uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-YARN-Build/7816/console This message was automatically generated.
        Hide
        varun_saxena Varun Saxena added a comment -

        Robert Joseph Evans, I had updated a new patch after above failure. New patch should apply.. Waiting for result from Jenkins

        Show
        varun_saxena Varun Saxena added a comment - Robert Joseph Evans , I had updated a new patch after above failure. New patch should apply.. Waiting for result from Jenkins
        Hide
        revans2 Robert Joseph Evans added a comment -

        The changes look fine to me. Not sure why the patch could not apply. The queue is full right now, so I will try to run things manually.

        Show
        revans2 Robert Joseph Evans added a comment - The changes look fine to me. Not sure why the patch could not apply. The queue is full right now, so I will try to run things manually.
        Hide
        varun_saxena Varun Saxena added a comment -

        Yes. It doesnt happen for response headers

        Show
        varun_saxena Varun Saxena added a comment - Yes. It doesnt happen for response headers
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        -1 patch 0m 0s The patch command could not apply the patch during dryrun.



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12731429/YARN-3148.02.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 241a72a
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/7805/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 patch 0m 0s The patch command could not apply the patch during dryrun. Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12731429/YARN-3148.02.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 241a72a Console output https://builds.apache.org/job/PreCommit-YARN-Build/7805/console This message was automatically generated.
        Hide
        pramachandran Prakash Ramachandran added a comment -

        Varun Saxena just to clarify. I believe the header filtering does not happen for the response headers. is that right?

        Show
        pramachandran Prakash Ramachandran added a comment - Varun Saxena just to clarify. I believe the header filtering does not happen for the response headers. is that right?
        Hide
        varun_saxena Varun Saxena added a comment -

        Thanks Li Lu (inactive) for looking at this. Will update the patch ASAP.

        Show
        varun_saxena Varun Saxena added a comment - Thanks Li Lu (inactive) for looking at this. Will update the patch ASAP.
        Hide
        gtCarrera9 Li Lu added a comment -

        Hi Varun Saxena, thanks for working on this! For the current patch, since we're supporting more fields, maybe it's helpful to add some tests?

        BTW, I checked and the current patch would not apply. I'm canceling this patch for now. Thanks.

        Show
        gtCarrera9 Li Lu added a comment - Hi Varun Saxena , thanks for working on this! For the current patch, since we're supporting more fields, maybe it's helpful to add some tests? BTW, I checked and the current patch would not apply. I'm canceling this patch for now. Thanks.
        Hide
        varun_saxena Varun Saxena added a comment -

        eclipse:eclipse passing in local

        Show
        varun_saxena Varun Saxena added a comment - eclipse:eclipse passing in local
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12696820/YARN-3148.001.patch
        against trunk revision c4980a2.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. There were no new javadoc warning messages.

        -1 eclipse:eclipse. The patch failed to build with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in .

        Test results: https://builds.apache.org/job/PreCommit-YARN-Build/6522//testReport/
        Console output: https://builds.apache.org/job/PreCommit-YARN-Build/6522//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12696820/YARN-3148.001.patch against trunk revision c4980a2. +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. -1 eclipse:eclipse . The patch failed to build with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-YARN-Build/6522//testReport/ Console output: https://builds.apache.org/job/PreCommit-YARN-Build/6522//console This message is automatically generated.

          People

          • Assignee:
            varun_saxena Varun Saxena
            Reporter:
            pramachandran Prakash Ramachandran
          • Votes:
            0 Vote for this issue
            Watchers:
            11 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development