[YARN-3114] It would be better to consider integer(long) overflow when compare the time in DelegationTokenRenewer.

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Not A Problem
• Component/s: resourcemanager
• Assignee: Zhihai Xu
• Reporter: Zhihai Xu
• Created: 29/Jan/15 20:50
• Updated: 01/May/15 07:28
• Resolved: 01/May/15 07:28

Description

It would be better to consider integer(long) overflow when compare the time in DelegationTokenRenewer.
When compare time in DelegationTokenRenewer#DelayedTokenRemovalRunnable to cancel token , it will have problem when currentTimeMillis is close to Long.MAX_VALUE.
The safer way to compare time will compare the time difference:
change

if (e.getValue() < System.currentTimeMillis()) {

to

if (e.getValue() - System.currentTimeMillis() < 0) {