Hadoop YARN
  1. Hadoop YARN
  2. YARN-294

Fixup YARN-2 naming and other nits in comments

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Won't Fix
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      In YARN-2, a number of naming-related and other nits have been proposed. This JIRA is to fix them.

      1. yarn-294.patch
        5 kB
        Karthik Kambatla

        Issue Links

          Activity

          Hide
          Karthik Kambatla added a comment -

          Went through the suggestions on YARN-2, most of them were already addressed.

          Uploading a patch to address few of the remaining.

          Leaving out physical core/ virtual core out of this, as that needs more discussion and a concrete proposal.

          Show
          Karthik Kambatla added a comment - Went through the suggestions on YARN-2 , most of them were already addressed. Uploading a patch to address few of the remaining. Leaving out physical core/ virtual core out of this, as that needs more discussion and a concrete proposal.
          Hide
          Vinod Kumar Vavilapalli added a comment -

          Can you summarize your patch? Thanks.

          Show
          Vinod Kumar Vavilapalli added a comment - Can you summarize your patch? Thanks.
          Hide
          Karthik Kambatla added a comment -

          The patch

          1. modifies DominantResourceCalculator#getResourceAsValue (renamed to #getResourceAsNormalizedValue) to take an int dominanceLevel as opposed to boolean dominant to allow extending to more than two resources.
          2. Changes ResourceCalculator#divideAndCeil to LOG.debug() from LOG.info()

          The changes are to address the minor comments from YARN-2.

          Show
          Karthik Kambatla added a comment - The patch modifies DominantResourceCalculator#getResourceAsValue (renamed to #getResourceAsNormalizedValue ) to take an int dominanceLevel as opposed to boolean dominant to allow extending to more than two resources. Changes ResourceCalculator#divideAndCeil to LOG.debug() from LOG.info() The changes are to address the minor comments from YARN-2 .
          Hide
          Arun C Murthy added a comment -

          modifies DominantResourceCalculator#getResourceAsValue (renamed to #getResourceAsNormalizedValue) to take an int dominanceLevel as opposed to boolean dominant to allow extending to more than two resources

          Karthik Kambatla I think I may have commented on YARN-2 about this, IAC, adding dominance level of 2 or 3 won't work performance-wise... we'll have to completely re-implement that function.

          Show
          Arun C Murthy added a comment - modifies DominantResourceCalculator#getResourceAsValue (renamed to #getResourceAsNormalizedValue) to take an int dominanceLevel as opposed to boolean dominant to allow extending to more than two resources Karthik Kambatla I think I may have commented on YARN-2 about this, IAC, adding dominance level of 2 or 3 won't work performance-wise... we'll have to completely re-implement that function.
          Hide
          Karthik Kambatla added a comment -

          The issues pointed have been mostly addressed by other patches.

          Show
          Karthik Kambatla added a comment - The issues pointed have been mostly addressed by other patches.

            People

            • Assignee:
              Karthik Kambatla
              Reporter:
              Karthik Kambatla
            • Votes:
              0 Vote for this issue
              Watchers:
              10 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development