Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-2799

cleanup TestLogAggregationService based on the change in YARN-90

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.7.0
    • Component/s: test
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      cleanup TestLogAggregationService based on the change in YARN-90.
      The following code is added to setup in YARN-90,

          dispatcher = createDispatcher();
          appEventHandler = mock(EventHandler.class);
          dispatcher.register(ApplicationEventType.class, appEventHandler);
      

      In this case, we should remove all these code from each test function to avoid duplicate code.

      Same for dispatcher.stop() which is in tearDown,
      we can remove dispatcher.stop() from from each test function also because it will always be called from tearDown for each test.

        Attachments

        1. YARN-2799.000.patch
          5 kB
          Zhihai Xu
        2. YARN-2799.001.patch
          5 kB
          Zhihai Xu
        3. YARN-2799.002.patch
          5 kB
          Zhihai Xu

          Issue Links

            Activity

              People

              • Assignee:
                zxu Zhihai Xu
                Reporter:
                zxu Zhihai Xu
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: