XMLWordPrintableJSON

Details

    • Sub-task
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 2.6.0
    • None
    • None
    • Reviewed

    Description

      Issues include:

      • CommonNodeLabelsManager#addToCluserNodeLabels should not change the value in labelCollections if the key already exists otherwise the Label.resource will be changed(reset).
      • potential NPE(NullPointerException) in checkRemoveLabelsFromNode of CommonNodeLabelsManager.
        • because when a Node is created, Node.labels can be null.
        • In this case, nm.labels; may be null. So we need check originalLabels not null before use it(originalLabels.containsAll).
      • addToCluserNodeLabels should be protected by writeLock in RMNodeLabelsManager.java. because we should protect labelCollections in RMNodeLabelsManager.
      • Fix a potential bug in CommonsNodeLabelsManager, after serviceStop(...) is invoked, some event may not be processed, see comment

      Attachments

        1. YARN-2753.000.patch
          0.9 kB
          Zhihai Xu
        2. YARN-2753.001.patch
          1 kB
          Zhihai Xu
        3. YARN-2753.002.patch
          3 kB
          Zhihai Xu
        4. YARN-2753.003.patch
          4 kB
          Zhihai Xu
        5. YARN-2753.004.patch
          6 kB
          Zhihai Xu
        6. YARN-2753.005.patch
          6 kB
          Zhihai Xu
        7. YARN-2753.006.patch
          5 kB
          Zhihai Xu
        8. YARN-2753.007.patch
          5 kB
          Zhihai Xu
        9. YARN-2753.008.patch
          5 kB
          Zhihai Xu

        Issue Links

          Activity

            People

              zxu Zhihai Xu
              zxu Zhihai Xu
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: