[YARN-2723] rmadmin -replaceLabelsOnNode does not correctly parse port

• Type: Sub-task
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.6.0
• Component/s: client
• Assignee: Naganarasimha G R
• Reporter: Phil D'Amore
• Created: 22/Oct/14 00:23
• Updated: 01/Dec/14 03:07
• Resolved: 25/Oct/14 00:59

Description

There is an off-by-one issue in RMAdminCLI.java (line 457):

port = Integer.valueOf(nodeIdStr.substring(nodeIdStr.indexOf(":")));

should probably be:

port = Integer.valueOf(nodeIdStr.substring(nodeIdStr.indexOf(":")+1));

Currently attempting to add a label to a node with a port specified looks like this:

[yarn@ip-10-0-0-66 ~]$ yarn rmadmin -replaceLabelsOnNode node.example.com:45454,test-label
replaceLabelsOnNode: For input string: ":45454"
Usage: yarn rmadmin [-replaceLabelsOnNode [node1:port,label1,label2 node2:port,label1,label2]]

It appears to be trying to parse the ':' as part of the integer because the substring index is off.