[YARN-2708] Potential null dereference in CommonNodeLabelsManager#internalRemoveLabelsFromNode()

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Not A Problem
• Assignee: Unassigned
• Reporter: Ted Yu
• Created: 17/Oct/14 21:17
• Updated: 17/Oct/14 23:51
• Resolved: 17/Oct/14 21:52

Description

Here is the code (around line 475):

      if (nodeId.getPort() == WILDCARD_PORT) {
        Host host = nodeCollections.get(nodeId.getHost());
        host.labels.removeAll(labels);
        newNMToLabels.put(nodeId, host.labels);
      } else {
        Node nm = getNMInNodeSet(nodeId);
        if (nm.labels != null) {

nm may be null in else block.
In other places, node is created if non-existent:

      } else {
        createNodeIfNonExisted(nodeId);
        Node nm = getNMInNodeSet(nodeId);