[YARN-2707] Potential null dereference in FSDownload

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 2.6.0
• Hadoop Flags: Reviewed
• Assignee: Gera Shegalov
• Reporter: Ted Yu
• Created: 17/Oct/14 21:04
• Updated: 01/Dec/14 03:10
• Resolved: 31/Oct/14 23:01

Description

Here is related code in call():

      Pattern pattern = null;
      String p = resource.getPattern();
      if (p != null) {
        pattern = Pattern.compile(p);
      }
      unpack(new File(dTmp.toUri()), new File(dFinal.toUri()), pattern);

In unpack():

        RunJar.unJar(localrsrc, dst, pattern);

unJar() would dereference the pattern without checking whether it is null.