Hadoop YARN
  1. Hadoop YARN
  2. YARN-269

Resource Manager not logging the health_check_script result when taking it out

        Details

        • Type: Bug Bug
        • Status: Closed
        • Priority: Major Major
        • Resolution: Fixed
        • Affects Version/s: 0.23.5
        • Fix Version/s: 0.23.7, 2.1.0-beta
        • Component/s: resourcemanager
        • Labels:
          None

          Description

          The Resource Manager not logging the health_check_script result when taking it out. This was added to jobtracker in 1.x with MAPREDUCE-2451, we should do the same thing for RM.

          1. Text File
            YARN-269.patch
            1 kB
            Jason Lowe
          2. Text File
            YARN-269.patch
            1 kB
            Jason Lowe

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            Jason Lowe added a comment -

            Straightforward patch. No unit test since it's a simple logging change which I manually tested.

            Show
            Jason Lowe added a comment - Straightforward patch. No unit test since it's a simple logging change which I manually tested.
            Hide
            Permalink
            Hadoop QA added a comment -

            -1 overall. Here are the results of testing the latest attachment
            http://issues.apache.org/jira/secure/attachment/12563635/YARN-269.patch
            against trunk revision .

            +1 @author. The patch does not contain any @author tags.

            -1 tests included. The patch doesn't appear to include any new or modified tests.
            Please justify why no new tests are needed for this patch.
            Also please list what manual steps were performed to verify this patch.

            +1 javac. The applied patch does not increase the total number of javac compiler warnings.

            +1 javadoc. The javadoc tool did not generate any warning messages.

            +1 eclipse:eclipse. The patch built with eclipse:eclipse.

            +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

            +1 release audit. The applied patch does not increase the total number of release audit warnings.

            +1 core tests. The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager.

            +1 contrib tests. The patch passed contrib unit tests.

            Test results: https://builds.apache.org/job/PreCommit-YARN-Build/322//testReport/
            Console output: https://builds.apache.org/job/PreCommit-YARN-Build/322//console

            This message is automatically generated.

            Show
            Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12563635/YARN-269.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-YARN-Build/322//testReport/ Console output: https://builds.apache.org/job/PreCommit-YARN-Build/322//console This message is automatically generated.
            Hide
            Permalink
            Kihwal Lee added a comment -

            +1 The patch is straightforward addition of a log message and the log level of info seems fine since this is more for later analyses than alerting system events.

            Show
            Kihwal Lee added a comment - +1 The patch is straightforward addition of a log message and the log level of info seems fine since this is more for later analyses than alerting system events.
            Hide
            Permalink
            Kihwal Lee added a comment -

            please rebase.

            Show
            Kihwal Lee added a comment - please rebase.
            Hide
            Permalink
            Jason Lowe added a comment -

            Thanks for the review, Kihwal. Here's an updated patch.

            Show
            Jason Lowe added a comment - Thanks for the review, Kihwal. Here's an updated patch.
            Hide
            Permalink
            Hadoop QA added a comment -

            -1 overall. Here are the results of testing the latest attachment
            http://issues.apache.org/jira/secure/attachment/12571462/YARN-269.patch
            against trunk revision .

            +1 @author. The patch does not contain any @author tags.

            -1 tests included. The patch doesn't appear to include any new or modified tests.
            Please justify why no new tests are needed for this patch.
            Also please list what manual steps were performed to verify this patch.

            +1 javac. The applied patch does not increase the total number of javac compiler warnings.

            +1 javadoc. The javadoc tool did not generate any warning messages.

            +1 eclipse:eclipse. The patch built with eclipse:eclipse.

            +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

            +1 release audit. The applied patch does not increase the total number of release audit warnings.

            +1 core tests. The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager.

            +1 contrib tests. The patch passed contrib unit tests.

            Test results: https://builds.apache.org/job/PreCommit-YARN-Build/447//testReport/
            Console output: https://builds.apache.org/job/PreCommit-YARN-Build/447//console

            This message is automatically generated.

            Show
            Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12571462/YARN-269.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-YARN-Build/447//testReport/ Console output: https://builds.apache.org/job/PreCommit-YARN-Build/447//console This message is automatically generated.
            Hide
            Permalink
            Kihwal Lee added a comment -

            I've committed this to branch-0.23 and branch-2. Thank you for contributing the patch, Jason.

            Show
            Kihwal Lee added a comment - I've committed this to branch-0.23 and branch-2. Thank you for contributing the patch, Jason.
            Hide
            Permalink
            Hudson added a comment -

            Integrated in Hadoop-trunk-Commit #3398 (See https://builds.apache.org/job/Hadoop-trunk-Commit/3398/)
            YARN-269. Resource Manager not logging the health_check_script result when taking it out. Contributed by Jason Lowe (Revision 1451341)

            Result = SUCCESS
            kihwal : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1451341
            Files :

            • /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt
            • /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmnode/RMNodeImpl.java
            Show
            Hudson added a comment - Integrated in Hadoop-trunk-Commit #3398 (See https://builds.apache.org/job/Hadoop-trunk-Commit/3398/ ) YARN-269 . Resource Manager not logging the health_check_script result when taking it out. Contributed by Jason Lowe (Revision 1451341) Result = SUCCESS kihwal : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1451341 Files : /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmnode/RMNodeImpl.java
            Hide
            Permalink
            Hudson added a comment -

            Integrated in Hadoop-Yarn-trunk #142 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/142/)
            YARN-269. Resource Manager not logging the health_check_script result when taking it out. Contributed by Jason Lowe (Revision 1451341)

            Result = SUCCESS
            kihwal : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1451341
            Files :

            • /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt
            • /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmnode/RMNodeImpl.java
            Show
            Hudson added a comment - Integrated in Hadoop-Yarn-trunk #142 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/142/ ) YARN-269 . Resource Manager not logging the health_check_script result when taking it out. Contributed by Jason Lowe (Revision 1451341) Result = SUCCESS kihwal : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1451341 Files : /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmnode/RMNodeImpl.java
            Hide
            Permalink
            Hudson added a comment -

            Integrated in Hadoop-Hdfs-0.23-Build #540 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/540/)
            YARN-269. Resource Manager not logging the health_check_script result when taking it out. Contributed by Jason Lowe (Revision 1451343)

            Result = SUCCESS
            kihwal : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1451343
            Files :

            • /hadoop/common/branches/branch-0.23/hadoop-yarn-project/CHANGES.txt
            • /hadoop/common/branches/branch-0.23/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmnode/RMNodeImpl.java
            Show
            Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Build #540 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/540/ ) YARN-269 . Resource Manager not logging the health_check_script result when taking it out. Contributed by Jason Lowe (Revision 1451343) Result = SUCCESS kihwal : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1451343 Files : /hadoop/common/branches/branch-0.23/hadoop-yarn-project/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmnode/RMNodeImpl.java
            Hide
            Permalink
            Hudson added a comment -

            Integrated in Hadoop-Hdfs-trunk #1331 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1331/)
            YARN-269. Resource Manager not logging the health_check_script result when taking it out. Contributed by Jason Lowe (Revision 1451341)

            Result = FAILURE
            kihwal : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1451341
            Files :

            • /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt
            • /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmnode/RMNodeImpl.java
            Show
            Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1331 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1331/ ) YARN-269 . Resource Manager not logging the health_check_script result when taking it out. Contributed by Jason Lowe (Revision 1451341) Result = FAILURE kihwal : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1451341 Files : /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmnode/RMNodeImpl.java
            Hide
            Permalink
            Hudson added a comment -

            Integrated in Hadoop-Mapreduce-trunk #1359 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1359/)
            YARN-269. Resource Manager not logging the health_check_script result when taking it out. Contributed by Jason Lowe (Revision 1451341)

            Result = SUCCESS
            kihwal : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1451341
            Files :

            • /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt
            • /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmnode/RMNodeImpl.java
            Show
            Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1359 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1359/ ) YARN-269 . Resource Manager not logging the health_check_script result when taking it out. Contributed by Jason Lowe (Revision 1451341) Result = SUCCESS kihwal : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1451341 Files : /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmnode/RMNodeImpl.java

              People

              • Assignee:
                Jason Lowe
                Reporter:
                Thomas Graves
              • Votes:
                0 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Development