[YARN-2432] RMStateStore should process the pending events before close

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.7.0
• Component/s: resourcemanager
• Target Version/s: 2.7.0
• Assignee: Varun Saxena
• Reporter: Varun Saxena
• Created: 20/Aug/14 08:33
• Updated: 10/Apr/15 20:10
• Resolved: 15/Nov/14 01:26

Description

Refer to discussion on YARN-2136 (https://issues.apache.org/jira/browse/YARN-2136?focusedCommentId=14097266&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14097266).

As pointed out by jianhe, we should process the dispatcher event queue before closing the state store by flipping over the following statements in code.

RMStateStore.java

 protected void serviceStop() throws Exception {
    closeInternal();
    dispatcher.stop();
  }

Currently, if the state store is being stopped on events such as switching to standby, it will first close the state store(in case of ZKRMStateStore, close connection with ZK) and then process the pending events. Instead, we should first process the pending events and then call close.

Issue Links

• relates to: YARN-2136 RMStateStore can explicitly handle store/update events when fenced