[YARN-2354] DistributedShell may allocate more containers than client specified after it restarts

• Type: Sub-task
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.6.0
• Target Version/s: 2.6.0
• Hadoop Flags: Reviewed
• Assignee: Li Lu
• Reporter: Jian He
• Created: 24/Jul/14 19:53
• Updated: 01/Dec/14 03:07
• Resolved: 30/Jul/14 04:01

Description

To reproduce, run distributed shell with -num_containers option,
In ApplicationMaster.java, the following code has some issue.

  int numTotalContainersToRequest =
        numTotalContainers - previousAMRunningContainers.size();
    for (int i = 0; i < numTotalContainersToRequest; ++i) {
      ContainerRequest containerAsk = setupContainerAskForRM();
      amRMClient.addContainerRequest(containerAsk);
    }
    numRequestedContainers.set(numTotalContainersToRequest);

numRequestedContainers doesn't account for previous AM's requested containers. so numRequestedContainers should be set to numTotalContainers