Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-2148

TestNMClient failed due more exit code values added and passed to AM

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.5.0, 3.0.0-alpha1
    • Fix Version/s: 2.5.0
    • Component/s: client
    • Labels:
      None

      Description

      Currently, TestNMClient will be failed in trunk, see https://builds.apache.org/job/PreCommit-YARN-Build/3959/testReport/junit/org.apache.hadoop.yarn.client.api.impl/TestNMClient/testNMClient/

      java.lang.AssertionError: null
      	at org.junit.Assert.fail(Assert.java:86)
      	at org.junit.Assert.assertTrue(Assert.java:41)
      	at org.junit.Assert.assertTrue(Assert.java:52)
      	at org.apache.hadoop.yarn.client.api.impl.TestNMClient.testGetContainerStatus(TestNMClient.java:385)
      	at org.apache.hadoop.yarn.client.api.impl.TestNMClient.testContainerManagement(TestNMClient.java:347)
      	at org.apache.hadoop.yarn.client.api.impl.TestNMClient.testNMClient(TestNMClient.java:226)
      

      Test cases in TestNMClient uses following code to verify exit code of COMPLETED containers

                testGetContainerStatus(container, i, ContainerState.COMPLETE,
                    "Container killed by the ApplicationMaster.", Arrays.asList(
                        new Integer[] {137, 143, 0}));
      

      But YARN-2091 added logic to make exit code reflecting the actual status, so exit code of the "killed by ApplicationMaster" will be -105,

            if (container.hasDefaultExitCode()) {
              container.exitCode = exitEvent.getExitCode();
            }
      

      We should update test case as well.

        Attachments

          Activity

            People

            • Assignee:
              leftnoteasy Wangda Tan
              Reporter:
              leftnoteasy Wangda Tan
            • Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: