[YARN-2117] Close of Reader in TimelineAuthenticationFilterInitializer#initFilter() should be enclosed in finally block

• Type: Sub-task
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 2.5.0
• Labels: newbie
• Target Version/s: 2.5.0
• Hadoop Flags: Reviewed
• Assignee: Chen He
• Reporter: Ted Yu
• Created: 31/May/14 00:14
• Updated: 15/Aug/14 05:44
• Resolved: 06/Jun/14 20:11

Description

Here is related code:

        Reader reader = new FileReader(signatureSecretFile);
        int c = reader.read();
        while (c > -1) {
          secret.append((char) c);
          c = reader.read();
        }
        reader.close();

If IOException is thrown out of reader.read(), reader would be left unclosed.