[YARN-2103] Inconsistency between viaProto flag and initial value of SerializedExceptionProto.Builder

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.5.0
• Hadoop Flags: Reviewed
• Assignee: Binglin Chang
• Reporter: Binglin Chang
• Created: 26/May/14 06:36
• Updated: 25/Oct/19 20:26
• Resolved: 02/Jun/14 08:28

Description

Bug 1:

  SerializedExceptionProto proto = SerializedExceptionProto
      .getDefaultInstance();
  SerializedExceptionProto.Builder builder = null;
  boolean viaProto = false;

Since viaProto is false, we should initiate build rather than proto

Bug 2:
the class does not provide hashcode() and equals() like other PBImpl records, this class is used in other records, it may affect other records' behavior.

Issue Links

• relates to: YARN-2051 Fix bug in PBimpls and add more unit tests with reflection