Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-2046

Out of band heartbeats are sent only on container kill and possibly too early

    Details

    • Hadoop Flags:
      Reviewed

      Description

      Ming Ma pointed out in the review discussion for MAPREDUCE-5465 that the NM is currently sending out of band heartbeats only when stopContainer is called. In addition those heartbeats might be sent too early because the container kill event is asynchronously posted then the heartbeat monitor is notified.

      1. YARN-2046.patch
        20 kB
        Ming Ma
      2. YARN-2046-2.patch
        21 kB
        Ming Ma
      3. YARN-2046-3.patch
        23 kB
        Ming Ma
      4. YARN-2046-4.patch
        23 kB
        Ming Ma
      5. YARN-2046-5.patch
        26 kB
        Ming Ma
      6. YARN-2046-branch-2.6.patch
        24 kB
        Ming Ma
      7. YARN-2046-branch-2.7.patch
        24 kB
        Ming Ma

        Activity

        Hide
        jlowe Jason Lowe added a comment -

        We should consider sending out of band heartbeats after a container completes rather than when a container is killed. For a cluster running MapReduce this should be almost equivalent in terms of number of OOB heartbeats sent since the MR AM always kills completed task attempts until MAPREDUCE-5465 is addressed.

        Show
        jlowe Jason Lowe added a comment - We should consider sending out of band heartbeats after a container completes rather than when a container is killed. For a cluster running MapReduce this should be almost equivalent in terms of number of OOB heartbeats sent since the MR AM always kills completed task attempts until MAPREDUCE-5465 is addressed.
        Hide
        mingma Ming Ma added a comment -

        In the patch, the container asks NodeStatusUpdater to send out of band heartbeats when it exits. The definition of "exit" also includes special cases where the container is killed before it is launched. This allows RM to know about completed containers via out of band heartbeats under different scenarios.

        Show
        mingma Ming Ma added a comment - In the patch, the container asks NodeStatusUpdater to send out of band heartbeats when it exits. The definition of "exit" also includes special cases where the container is killed before it is launched. This allows RM to know about completed containers via out of band heartbeats under different scenarios.
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12665191/YARN-2046.patch
        against trunk revision d8774cc.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 8 new or modified test files.

        -1 javac. The applied patch generated 1298 javac compiler warnings (more than the trunk's current 1275 warnings).

        +1 javadoc. There were no new javadoc warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient:

        org.apache.hadoop.mapreduce.v2.app.webapp.TestAMWebServicesAttempts
        org.apache.hadoop.mapreduce.v2.app.webapp.TestAMWebServices
        org.apache.hadoop.mapreduce.v2.hs.webapp.TestHsWebServices
        org.apache.hadoop.mapreduce.v2.hs.webapp.TestHsWebServicesAttempts
        org.apache.hadoop.mapreduce.v2.hs.webapp.TestHsWebServicesTasks
        org.apache.hadoop.mapreduce.v2.hs.webapp.TestHsWebServicesJobsQuery
        org.apache.hadoop.mapred.TestMiniMRClientCluster
        org.apache.hadoop.mapred.TestMiniMRChildTask

        The following test timeouts occurred in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient:

        org.apache.hadoopTests
        org.apache.hadoop.mapreducTests
        org.apache.hadoop.mapreTests
        org.apache.haTests
        org.apache.hadoop.maTests
        org.apache.hadoop.mapreduce.v2.appTests
        org.apache.hadoop.mapred.TestMultipleLevelCaching
        org.apache.hadoop.mapred.TestReporter
        org.apache.hadoop.mapreduce.TestLargeSort

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-YARN-Build/4762//testReport/
        Javac warnings: https://builds.apache.org/job/PreCommit-YARN-Build/4762//artifact/trunk/patchprocess/diffJavacWarnings.txt
        Console output: https://builds.apache.org/job/PreCommit-YARN-Build/4762//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12665191/YARN-2046.patch against trunk revision d8774cc. +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 8 new or modified test files. -1 javac . The applied patch generated 1298 javac compiler warnings (more than the trunk's current 1275 warnings). +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient: org.apache.hadoop.mapreduce.v2.app.webapp.TestAMWebServicesAttempts org.apache.hadoop.mapreduce.v2.app.webapp.TestAMWebServices org.apache.hadoop.mapreduce.v2.hs.webapp.TestHsWebServices org.apache.hadoop.mapreduce.v2.hs.webapp.TestHsWebServicesAttempts org.apache.hadoop.mapreduce.v2.hs.webapp.TestHsWebServicesTasks org.apache.hadoop.mapreduce.v2.hs.webapp.TestHsWebServicesJobsQuery org.apache.hadoop.mapred.TestMiniMRClientCluster org.apache.hadoop.mapred.TestMiniMRChildTask The following test timeouts occurred in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient: org.apache.hadoopTests org.apache.hadoop.mapreducTests org.apache.hadoop.mapreTests org.apache.haTests org.apache.hadoop.maTests org.apache.hadoop.mapreduce.v2.appTests org.apache.hadoop.mapred.TestMultipleLevelCaching org.apache.hadoop.mapred.TestReporter org.apache.hadoop.mapreduce.TestLargeSort +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-YARN-Build/4762//testReport/ Javac warnings: https://builds.apache.org/job/PreCommit-YARN-Build/4762//artifact/trunk/patchprocess/diffJavacWarnings.txt Console output: https://builds.apache.org/job/PreCommit-YARN-Build/4762//console This message is automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12666320/YARN-2046.patch
        against trunk revision 1dcaba9.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 6 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. There were no new javadoc warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-YARN-Build/4817//testReport/
        Console output: https://builds.apache.org/job/PreCommit-YARN-Build/4817//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12666320/YARN-2046.patch against trunk revision 1dcaba9. +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 6 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-YARN-Build/4817//testReport/ Console output: https://builds.apache.org/job/PreCommit-YARN-Build/4817//console This message is automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        -1 patch 0m 0s The patch command could not apply the patch during dryrun.



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12666320/YARN-2046.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / f1a152c
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/7625/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 patch 0m 0s The patch command could not apply the patch during dryrun. Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12666320/YARN-2046.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / f1a152c Console output https://builds.apache.org/job/PreCommit-YARN-Build/7625/console This message was automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        -1 patch 0m 0s The patch command could not apply the patch during dryrun.



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12666320/YARN-2046.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / f1a152c
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/7629/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 patch 0m 0s The patch command could not apply the patch during dryrun. Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12666320/YARN-2046.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / f1a152c Console output https://builds.apache.org/job/PreCommit-YARN-Build/7629/console This message was automatically generated.
        Hide
        xgong Xuan Gong added a comment -

        Cancel the patch since it does not apply anymore.
        Ming Ma Could you re-base the patch, please ?

        Show
        xgong Xuan Gong added a comment - Cancel the patch since it does not apply anymore. Ming Ma Could you re-base the patch, please ?
        Hide
        mingma Ming Ma added a comment -

        Thanks Xuan Gong. Here is the rebased patch.

        Show
        mingma Ming Ma added a comment - Thanks Xuan Gong . Here is the rebased patch.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 14m 56s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 6 new or modified test files.
        +1 javac 7m 46s There were no new javac warning messages.
        +1 javadoc 9m 51s There were no new javadoc warning messages.
        +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
        -1 checkstyle 0m 36s The applied patch generated 4 new checkstyle issues (total was 181, now 183).
        +1 whitespace 0m 1s The patch has no lines that end in whitespace.
        +1 install 1m 37s mvn install still works.
        +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse.
        +1 findbugs 1m 2s The patch does not introduce any new Findbugs (version 2.0.3) warnings.
        +1 yarn tests 6m 0s Tests passed in hadoop-yarn-server-nodemanager.
            42m 48s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12731512/YARN-2046-2.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / f55d21d
        checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/7818/artifact/patchprocess/diffcheckstylehadoop-yarn-server-nodemanager.txt
        hadoop-yarn-server-nodemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/7818/artifact/patchprocess/testrun_hadoop-yarn-server-nodemanager.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/7818/testReport/
        Java 1.7.0_55
        uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/7818/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 14m 56s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 6 new or modified test files. +1 javac 7m 46s There were no new javac warning messages. +1 javadoc 9m 51s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 0m 36s The applied patch generated 4 new checkstyle issues (total was 181, now 183). +1 whitespace 0m 1s The patch has no lines that end in whitespace. +1 install 1m 37s mvn install still works. +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse. +1 findbugs 1m 2s The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 yarn tests 6m 0s Tests passed in hadoop-yarn-server-nodemanager.     42m 48s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12731512/YARN-2046-2.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / f55d21d checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/7818/artifact/patchprocess/diffcheckstylehadoop-yarn-server-nodemanager.txt hadoop-yarn-server-nodemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/7818/artifact/patchprocess/testrun_hadoop-yarn-server-nodemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/7818/testReport/ Java 1.7.0_55 uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-YARN-Build/7818/console This message was automatically generated.
        Hide
        mingma Ming Ma added a comment -

        With out-of-band heartbeat we can afford to set larger NM -> RM heartbeat interval. That is useful when you have a large cluster and large NM -> RM heartbeat interval can reduce the load on RM. Here is the rebased patch.

        Show
        mingma Ming Ma added a comment - With out-of-band heartbeat we can afford to set larger NM -> RM heartbeat interval. That is useful when you have a large cluster and large NM -> RM heartbeat interval can reduce the load on RM. Here is the rebased patch.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 20s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 7 new or modified test files.
        0 mvndep 0m 16s Maven dependency ordering for branch
        +1 mvninstall 9m 38s trunk passed
        +1 compile 0m 49s trunk passed with JDK v1.8.0_66
        +1 compile 0m 39s trunk passed with JDK v1.7.0_91
        +1 checkstyle 0m 25s trunk passed
        +1 mvnsite 0m 42s trunk passed
        +1 mvneclipse 0m 17s trunk passed
        +1 findbugs 1m 10s trunk passed
        +1 javadoc 0m 33s trunk passed with JDK v1.8.0_66
        +1 javadoc 0m 32s trunk passed with JDK v1.7.0_91
        0 mvndep 0m 10s Maven dependency ordering for patch
        +1 mvninstall 0m 34s the patch passed
        +1 compile 0m 44s the patch passed with JDK v1.8.0_66
        +1 javac 0m 44s the patch passed
        +1 compile 0m 36s the patch passed with JDK v1.7.0_91
        +1 javac 0m 36s the patch passed
        -1 checkstyle 0m 22s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager: patch generated 4 new + 173 unchanged - 1 fixed = 177 total (was 174)
        +1 mvnsite 0m 40s the patch passed
        +1 mvneclipse 0m 14s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 1m 25s the patch passed
        +1 javadoc 0m 32s the patch passed with JDK v1.8.0_66
        +1 javadoc 0m 24s the patch passed with JDK v1.7.0_91
        -1 unit 10m 46s hadoop-yarn-server-nodemanager in the patch failed with JDK v1.8.0_66.
        +1 unit 10m 23s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.7.0_91.
        +1 asflicense 0m 25s Patch does not generate ASF License warnings.
        43m 57s



        Reason Tests
        JDK v1.8.0_66 Failed junit tests hadoop.yarn.server.nodemanager.containermanager.logaggregation.TestLogAggregationService



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12786402/YARN-2046-3.patch
        JIRA Issue YARN-2046
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 23d004ed014c 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 1bcfab8
        Default Java 1.7.0_91
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/10498/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/10498/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.8.0_66.txt
        unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10498/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.8.0_66.txt
        JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10498/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager
        Max memory used 76MB
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/10498/console
        Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 20s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 7 new or modified test files. 0 mvndep 0m 16s Maven dependency ordering for branch +1 mvninstall 9m 38s trunk passed +1 compile 0m 49s trunk passed with JDK v1.8.0_66 +1 compile 0m 39s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 25s trunk passed +1 mvnsite 0m 42s trunk passed +1 mvneclipse 0m 17s trunk passed +1 findbugs 1m 10s trunk passed +1 javadoc 0m 33s trunk passed with JDK v1.8.0_66 +1 javadoc 0m 32s trunk passed with JDK v1.7.0_91 0 mvndep 0m 10s Maven dependency ordering for patch +1 mvninstall 0m 34s the patch passed +1 compile 0m 44s the patch passed with JDK v1.8.0_66 +1 javac 0m 44s the patch passed +1 compile 0m 36s the patch passed with JDK v1.7.0_91 +1 javac 0m 36s the patch passed -1 checkstyle 0m 22s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager: patch generated 4 new + 173 unchanged - 1 fixed = 177 total (was 174) +1 mvnsite 0m 40s the patch passed +1 mvneclipse 0m 14s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 1m 25s the patch passed +1 javadoc 0m 32s the patch passed with JDK v1.8.0_66 +1 javadoc 0m 24s the patch passed with JDK v1.7.0_91 -1 unit 10m 46s hadoop-yarn-server-nodemanager in the patch failed with JDK v1.8.0_66. +1 unit 10m 23s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.7.0_91. +1 asflicense 0m 25s Patch does not generate ASF License warnings. 43m 57s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.yarn.server.nodemanager.containermanager.logaggregation.TestLogAggregationService Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12786402/YARN-2046-3.patch JIRA Issue YARN-2046 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 23d004ed014c 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 1bcfab8 Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/10498/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10498/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.8.0_66.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10498/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.8.0_66.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10498/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager Max memory used 76MB Console output https://builds.apache.org/job/PreCommit-YARN-Build/10498/console Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        mingma Ming Ma added a comment -

        The TestLogAggregationService failure is unrelated. It passes locally. The update patch has fixed one of the checkstyle issues. For the rest of checkstyle issues, there is not much to do. If we want to make sure not to pass too many parameters to constructors, we need to use the builder pattern.

        Show
        mingma Ming Ma added a comment - The TestLogAggregationService failure is unrelated. It passes locally. The update patch has fixed one of the checkstyle issues. For the rest of checkstyle issues, there is not much to do. If we want to make sure not to pass too many parameters to constructors, we need to use the builder pattern.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 16s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 7 new or modified test files.
        +1 mvninstall 6m 31s trunk passed
        +1 compile 0m 22s trunk passed with JDK v1.8.0_72
        +1 compile 0m 26s trunk passed with JDK v1.7.0_95
        +1 checkstyle 0m 17s trunk passed
        +1 mvnsite 0m 28s trunk passed
        +1 mvneclipse 0m 13s trunk passed
        +1 findbugs 0m 48s trunk passed
        +1 javadoc 0m 17s trunk passed with JDK v1.8.0_72
        +1 javadoc 0m 21s trunk passed with JDK v1.7.0_95
        +1 mvninstall 0m 24s the patch passed
        +1 compile 0m 19s the patch passed with JDK v1.8.0_72
        +1 javac 0m 19s the patch passed
        +1 compile 0m 24s the patch passed with JDK v1.7.0_95
        +1 javac 0m 24s the patch passed
        -1 checkstyle 0m 15s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager: patch generated 3 new + 173 unchanged - 1 fixed = 176 total (was 174)
        +1 mvnsite 0m 25s the patch passed
        +1 mvneclipse 0m 10s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 0m 57s the patch passed
        +1 javadoc 0m 15s the patch passed with JDK v1.8.0_72
        +1 javadoc 0m 19s the patch passed with JDK v1.7.0_95
        +1 unit 8m 49s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.8.0_72.
        +1 unit 9m 19s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.7.0_95.
        +1 asflicense 0m 18s Patch does not generate ASF License warnings.
        32m 55s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12787003/YARN-2046-4.patch
        JIRA Issue YARN-2046
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 745da6fcf63c 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / acac729
        Default Java 1.7.0_95
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/10531/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt
        JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10531/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager
        Max memory used 77MB
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/10531/console
        Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 7 new or modified test files. +1 mvninstall 6m 31s trunk passed +1 compile 0m 22s trunk passed with JDK v1.8.0_72 +1 compile 0m 26s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 17s trunk passed +1 mvnsite 0m 28s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 0m 48s trunk passed +1 javadoc 0m 17s trunk passed with JDK v1.8.0_72 +1 javadoc 0m 21s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 24s the patch passed +1 compile 0m 19s the patch passed with JDK v1.8.0_72 +1 javac 0m 19s the patch passed +1 compile 0m 24s the patch passed with JDK v1.7.0_95 +1 javac 0m 24s the patch passed -1 checkstyle 0m 15s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager: patch generated 3 new + 173 unchanged - 1 fixed = 176 total (was 174) +1 mvnsite 0m 25s the patch passed +1 mvneclipse 0m 10s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 0m 57s the patch passed +1 javadoc 0m 15s the patch passed with JDK v1.8.0_72 +1 javadoc 0m 19s the patch passed with JDK v1.7.0_95 +1 unit 8m 49s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.8.0_72. +1 unit 9m 19s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 18s Patch does not generate ASF License warnings. 32m 55s Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12787003/YARN-2046-4.patch JIRA Issue YARN-2046 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 745da6fcf63c 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / acac729 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/10531/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10531/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager Max memory used 77MB Console output https://builds.apache.org/job/PreCommit-YARN-Build/10531/console Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        jlowe Jason Lowe added a comment -

        Thanks for updating the patch! Looks good to me overall.

        Now that we're passing the context, seems like we could avoid passing the state store and simply retrieve it from the context. There might be other parameters that could also be derived from the context, but that would be a simple one to help avoid adding yet another parameter.

        Show
        jlowe Jason Lowe added a comment - Thanks for updating the patch! Looks good to me overall. Now that we're passing the context, seems like we could avoid passing the state store and simply retrieve it from the context. There might be other parameters that could also be derived from the context, but that would be a simple one to help avoid adding yet another parameter.
        Hide
        mingma Ming Ma added a comment -

        Thanks Jason Lowe! Here is the updated patch with your suggestion.

        Show
        mingma Ming Ma added a comment - Thanks Jason Lowe ! Here is the updated patch with your suggestion.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 18s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 7 new or modified test files.
        +1 mvninstall 7m 37s trunk passed
        +1 compile 0m 29s trunk passed with JDK v1.8.0_72
        +1 compile 0m 31s trunk passed with JDK v1.7.0_95
        +1 checkstyle 0m 20s trunk passed
        +1 mvnsite 0m 34s trunk passed
        +1 mvneclipse 0m 14s trunk passed
        +1 findbugs 0m 53s trunk passed
        +1 javadoc 0m 23s trunk passed with JDK v1.8.0_72
        +1 javadoc 0m 30s trunk passed with JDK v1.7.0_95
        +1 mvninstall 0m 29s the patch passed
        +1 compile 0m 25s the patch passed with JDK v1.8.0_72
        +1 javac 0m 25s the patch passed
        +1 compile 0m 27s the patch passed with JDK v1.7.0_95
        +1 javac 0m 27s the patch passed
        -1 checkstyle 0m 18s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager: patch generated 1 new + 174 unchanged - 0 fixed = 175 total (was 174)
        +1 mvnsite 0m 31s the patch passed
        +1 mvneclipse 0m 13s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 1m 5s the patch passed
        +1 javadoc 0m 19s the patch passed with JDK v1.8.0_72
        +1 javadoc 0m 22s the patch passed with JDK v1.7.0_95
        +1 unit 9m 15s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.8.0_72.
        +1 unit 9m 48s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.7.0_95.
        +1 asflicense 0m 18s Patch does not generate ASF License warnings.
        36m 32s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12787615/YARN-2046-5.patch
        JIRA Issue YARN-2046
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux af852b9ccdde 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 9b959f3
        Default Java 1.7.0_95
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/10562/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt
        JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10562/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager
        Max memory used 77MB
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/10562/console
        Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 7 new or modified test files. +1 mvninstall 7m 37s trunk passed +1 compile 0m 29s trunk passed with JDK v1.8.0_72 +1 compile 0m 31s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 20s trunk passed +1 mvnsite 0m 34s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 0m 53s trunk passed +1 javadoc 0m 23s trunk passed with JDK v1.8.0_72 +1 javadoc 0m 30s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 29s the patch passed +1 compile 0m 25s the patch passed with JDK v1.8.0_72 +1 javac 0m 25s the patch passed +1 compile 0m 27s the patch passed with JDK v1.7.0_95 +1 javac 0m 27s the patch passed -1 checkstyle 0m 18s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager: patch generated 1 new + 174 unchanged - 0 fixed = 175 total (was 174) +1 mvnsite 0m 31s the patch passed +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 1m 5s the patch passed +1 javadoc 0m 19s the patch passed with JDK v1.8.0_72 +1 javadoc 0m 22s the patch passed with JDK v1.7.0_95 +1 unit 9m 15s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.8.0_72. +1 unit 9m 48s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 18s Patch does not generate ASF License warnings. 36m 32s Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12787615/YARN-2046-5.patch JIRA Issue YARN-2046 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux af852b9ccdde 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 9b959f3 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/10562/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10562/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager Max memory used 77MB Console output https://builds.apache.org/job/PreCommit-YARN-Build/10562/console Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        jlowe Jason Lowe added a comment -

        Thanks, Ming! +1 for the latest patch.

        I think this would be useful to get into branch-2.7 and branch-2.6. If you agree, would you mind porting the patch to those branches?

        Show
        jlowe Jason Lowe added a comment - Thanks, Ming! +1 for the latest patch. I think this would be useful to get into branch-2.7 and branch-2.6. If you agree, would you mind porting the patch to those branches?
        Hide
        mingma Ming Ma added a comment -

        Thanks Jason Lowe. Agree it is useful to for branch-2.7 and branch 2.6. Here are the specific patches for those two branches.

        Show
        mingma Ming Ma added a comment - Thanks Jason Lowe . Agree it is useful to for branch-2.7 and branch 2.6. Here are the specific patches for those two branches.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 24m 13s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 6 new or modified test files.
        -1 mvninstall 1m 57s root in branch-2.6 failed.
        -1 compile 0m 16s hadoop-yarn-server-nodemanager in branch-2.6 failed with JDK v1.8.0_72.
        -1 compile 0m 6s hadoop-yarn-server-nodemanager in branch-2.6 failed with JDK v1.7.0_95.
        +1 checkstyle 0m 12s branch-2.6 passed
        -1 mvnsite 0m 6s hadoop-yarn-server-nodemanager in branch-2.6 failed.
        -1 mvneclipse 0m 13s hadoop-yarn-server-nodemanager in branch-2.6 failed.
        -1 findbugs 0m 7s hadoop-yarn-server-nodemanager in branch-2.6 failed.
        -1 javadoc 0m 6s hadoop-yarn-server-nodemanager in branch-2.6 failed with JDK v1.8.0_72.
        -1 javadoc 0m 7s hadoop-yarn-server-nodemanager in branch-2.6 failed with JDK v1.7.0_95.
        -1 mvninstall 0m 7s hadoop-yarn-server-nodemanager in the patch failed.
        -1 compile 0m 6s hadoop-yarn-server-nodemanager in the patch failed with JDK v1.8.0_72.
        -1 javac 0m 6s hadoop-yarn-server-nodemanager in the patch failed with JDK v1.8.0_72.
        -1 compile 0m 6s hadoop-yarn-server-nodemanager in the patch failed with JDK v1.7.0_95.
        -1 javac 0m 6s hadoop-yarn-server-nodemanager in the patch failed with JDK v1.7.0_95.
        +1 checkstyle 0m 7s the patch passed
        -1 mvnsite 0m 6s hadoop-yarn-server-nodemanager in the patch failed.
        -1 mvneclipse 0m 7s hadoop-yarn-server-nodemanager in the patch failed.
        -1 whitespace 0m 1s The patch has 1734 line(s) that end in whitespace. Use git apply --whitespace=fix.
        -1 whitespace 0m 41s The patch has 41 line(s) with tabs.
        -1 findbugs 0m 7s hadoop-yarn-server-nodemanager in the patch failed.
        -1 javadoc 0m 7s hadoop-yarn-server-nodemanager in the patch failed with JDK v1.8.0_72.
        -1 javadoc 0m 7s hadoop-yarn-server-nodemanager in the patch failed with JDK v1.7.0_95.
        -1 unit 0m 6s hadoop-yarn-server-nodemanager in the patch failed with JDK v1.8.0_72.
        -1 unit 0m 7s hadoop-yarn-server-nodemanager in the patch failed with JDK v1.7.0_95.
        -1 asflicense 0m 32s Patch generated 59 ASF License warnings.
        30m 55s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:date2016-02-13
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12787782/YARN-2046-branch-2.6.patch
        JIRA Issue YARN-2046
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 968a378ff25f 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision branch-2.6 / 1b013a4
        Default Java 1.7.0_95
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
        mvninstall https://builds.apache.org/job/PreCommit-YARN-Build/10565/artifact/patchprocess/branch-mvninstall-root.txt
        compile https://builds.apache.org/job/PreCommit-YARN-Build/10565/artifact/patchprocess/branch-compile-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.8.0_72.txt
        compile https://builds.apache.org/job/PreCommit-YARN-Build/10565/artifact/patchprocess/branch-compile-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.7.0_95.txt
        mvnsite https://builds.apache.org/job/PreCommit-YARN-Build/10565/artifact/patchprocess/branch-mvnsite-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt
        mvneclipse https://builds.apache.org/job/PreCommit-YARN-Build/10565/artifact/patchprocess/branch-mvneclipse-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt
        findbugs https://builds.apache.org/job/PreCommit-YARN-Build/10565/artifact/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt
        javadoc https://builds.apache.org/job/PreCommit-YARN-Build/10565/artifact/patchprocess/branch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.8.0_72.txt
        javadoc https://builds.apache.org/job/PreCommit-YARN-Build/10565/artifact/patchprocess/branch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.7.0_95.txt
        mvninstall https://builds.apache.org/job/PreCommit-YARN-Build/10565/artifact/patchprocess/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt
        compile https://builds.apache.org/job/PreCommit-YARN-Build/10565/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.8.0_72.txt
        javac https://builds.apache.org/job/PreCommit-YARN-Build/10565/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.8.0_72.txt
        compile https://builds.apache.org/job/PreCommit-YARN-Build/10565/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.7.0_95.txt
        javac https://builds.apache.org/job/PreCommit-YARN-Build/10565/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.7.0_95.txt
        mvnsite https://builds.apache.org/job/PreCommit-YARN-Build/10565/artifact/patchprocess/patch-mvnsite-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt
        mvneclipse https://builds.apache.org/job/PreCommit-YARN-Build/10565/artifact/patchprocess/patch-mvneclipse-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt
        whitespace https://builds.apache.org/job/PreCommit-YARN-Build/10565/artifact/patchprocess/whitespace-eol.txt
        whitespace https://builds.apache.org/job/PreCommit-YARN-Build/10565/artifact/patchprocess/whitespace-tabs.txt
        findbugs https://builds.apache.org/job/PreCommit-YARN-Build/10565/artifact/patchprocess/patch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt
        javadoc https://builds.apache.org/job/PreCommit-YARN-Build/10565/artifact/patchprocess/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.8.0_72.txt
        javadoc https://builds.apache.org/job/PreCommit-YARN-Build/10565/artifact/patchprocess/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.7.0_95.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/10565/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.8.0_72.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/10565/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.7.0_95.txt
        JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10565/testReport/
        asflicense https://builds.apache.org/job/PreCommit-YARN-Build/10565/artifact/patchprocess/patch-asflicense-problems.txt
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/10565/console
        Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 24m 13s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 6 new or modified test files. -1 mvninstall 1m 57s root in branch-2.6 failed. -1 compile 0m 16s hadoop-yarn-server-nodemanager in branch-2.6 failed with JDK v1.8.0_72. -1 compile 0m 6s hadoop-yarn-server-nodemanager in branch-2.6 failed with JDK v1.7.0_95. +1 checkstyle 0m 12s branch-2.6 passed -1 mvnsite 0m 6s hadoop-yarn-server-nodemanager in branch-2.6 failed. -1 mvneclipse 0m 13s hadoop-yarn-server-nodemanager in branch-2.6 failed. -1 findbugs 0m 7s hadoop-yarn-server-nodemanager in branch-2.6 failed. -1 javadoc 0m 6s hadoop-yarn-server-nodemanager in branch-2.6 failed with JDK v1.8.0_72. -1 javadoc 0m 7s hadoop-yarn-server-nodemanager in branch-2.6 failed with JDK v1.7.0_95. -1 mvninstall 0m 7s hadoop-yarn-server-nodemanager in the patch failed. -1 compile 0m 6s hadoop-yarn-server-nodemanager in the patch failed with JDK v1.8.0_72. -1 javac 0m 6s hadoop-yarn-server-nodemanager in the patch failed with JDK v1.8.0_72. -1 compile 0m 6s hadoop-yarn-server-nodemanager in the patch failed with JDK v1.7.0_95. -1 javac 0m 6s hadoop-yarn-server-nodemanager in the patch failed with JDK v1.7.0_95. +1 checkstyle 0m 7s the patch passed -1 mvnsite 0m 6s hadoop-yarn-server-nodemanager in the patch failed. -1 mvneclipse 0m 7s hadoop-yarn-server-nodemanager in the patch failed. -1 whitespace 0m 1s The patch has 1734 line(s) that end in whitespace. Use git apply --whitespace=fix. -1 whitespace 0m 41s The patch has 41 line(s) with tabs. -1 findbugs 0m 7s hadoop-yarn-server-nodemanager in the patch failed. -1 javadoc 0m 7s hadoop-yarn-server-nodemanager in the patch failed with JDK v1.8.0_72. -1 javadoc 0m 7s hadoop-yarn-server-nodemanager in the patch failed with JDK v1.7.0_95. -1 unit 0m 6s hadoop-yarn-server-nodemanager in the patch failed with JDK v1.8.0_72. -1 unit 0m 7s hadoop-yarn-server-nodemanager in the patch failed with JDK v1.7.0_95. -1 asflicense 0m 32s Patch generated 59 ASF License warnings. 30m 55s Subsystem Report/Notes Docker Image:yetus/hadoop:date2016-02-13 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12787782/YARN-2046-branch-2.6.patch JIRA Issue YARN-2046 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 968a378ff25f 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2.6 / 1b013a4 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 mvninstall https://builds.apache.org/job/PreCommit-YARN-Build/10565/artifact/patchprocess/branch-mvninstall-root.txt compile https://builds.apache.org/job/PreCommit-YARN-Build/10565/artifact/patchprocess/branch-compile-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.8.0_72.txt compile https://builds.apache.org/job/PreCommit-YARN-Build/10565/artifact/patchprocess/branch-compile-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.7.0_95.txt mvnsite https://builds.apache.org/job/PreCommit-YARN-Build/10565/artifact/patchprocess/branch-mvnsite-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt mvneclipse https://builds.apache.org/job/PreCommit-YARN-Build/10565/artifact/patchprocess/branch-mvneclipse-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt findbugs https://builds.apache.org/job/PreCommit-YARN-Build/10565/artifact/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt javadoc https://builds.apache.org/job/PreCommit-YARN-Build/10565/artifact/patchprocess/branch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.8.0_72.txt javadoc https://builds.apache.org/job/PreCommit-YARN-Build/10565/artifact/patchprocess/branch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.7.0_95.txt mvninstall https://builds.apache.org/job/PreCommit-YARN-Build/10565/artifact/patchprocess/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt compile https://builds.apache.org/job/PreCommit-YARN-Build/10565/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.8.0_72.txt javac https://builds.apache.org/job/PreCommit-YARN-Build/10565/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.8.0_72.txt compile https://builds.apache.org/job/PreCommit-YARN-Build/10565/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.7.0_95.txt javac https://builds.apache.org/job/PreCommit-YARN-Build/10565/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.7.0_95.txt mvnsite https://builds.apache.org/job/PreCommit-YARN-Build/10565/artifact/patchprocess/patch-mvnsite-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt mvneclipse https://builds.apache.org/job/PreCommit-YARN-Build/10565/artifact/patchprocess/patch-mvneclipse-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt whitespace https://builds.apache.org/job/PreCommit-YARN-Build/10565/artifact/patchprocess/whitespace-eol.txt whitespace https://builds.apache.org/job/PreCommit-YARN-Build/10565/artifact/patchprocess/whitespace-tabs.txt findbugs https://builds.apache.org/job/PreCommit-YARN-Build/10565/artifact/patchprocess/patch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt javadoc https://builds.apache.org/job/PreCommit-YARN-Build/10565/artifact/patchprocess/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.8.0_72.txt javadoc https://builds.apache.org/job/PreCommit-YARN-Build/10565/artifact/patchprocess/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.7.0_95.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10565/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.8.0_72.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10565/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10565/testReport/ asflicense https://builds.apache.org/job/PreCommit-YARN-Build/10565/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager Console output https://builds.apache.org/job/PreCommit-YARN-Build/10565/console Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        jlowe Jason Lowe added a comment -

        +1 for the 2.7 and 2.6 patches as well. Committing this.

        Show
        jlowe Jason Lowe added a comment - +1 for the 2.7 and 2.6 patches as well. Committing this.
        Hide
        jlowe Jason Lowe added a comment -

        Thanks, Ming! I committed this to trunk, branch-2, branch-2.8, branch-2.7, and branch-2.6.

        Show
        jlowe Jason Lowe added a comment - Thanks, Ming! I committed this to trunk, branch-2, branch-2.8, branch-2.7, and branch-2.6.
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #9354 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9354/)
        YARN-2046. Out of band heartbeats are sent only on container kill and (jlowe: rev d284e187b8db43056236032ebc2114ee462c27f6)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/container/TestContainer.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/amrmproxy/BaseAMRMProxyTest.java
        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/webapp/TestNMWebServer.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/BaseContainerManagerTest.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/TestNodeStatusUpdater.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/container/ContainerImpl.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/NodeManager.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/Context.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/TestAuxServices.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/TestEventFlow.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/ContainerManagerImpl.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9354 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9354/ ) YARN-2046 . Out of band heartbeats are sent only on container kill and (jlowe: rev d284e187b8db43056236032ebc2114ee462c27f6) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/container/TestContainer.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/amrmproxy/BaseAMRMProxyTest.java hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/webapp/TestNMWebServer.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/BaseContainerManagerTest.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/TestNodeStatusUpdater.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/container/ContainerImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/NodeManager.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/Context.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/TestAuxServices.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/TestEventFlow.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/ContainerManagerImpl.java
        Hide
        mingma Ming Ma added a comment -

        Thanks Jason Lowe and Xuan Gong!

        Show
        mingma Ming Ma added a comment - Thanks Jason Lowe and Xuan Gong !
        Hide
        vinodkv Vinod Kumar Vavilapalli added a comment -

        Closing the JIRA as part of 2.7.3 release.

        Show
        vinodkv Vinod Kumar Vavilapalli added a comment - Closing the JIRA as part of 2.7.3 release.

          People

          • Assignee:
            mingma Ming Ma
            Reporter:
            jlowe Jason Lowe
          • Votes:
            0 Vote for this issue
            Watchers:
            15 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development