[YARN-1873] TestDistributedShell#testDSShell fails when the test cases are out of order

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.4.0, 3.0.0-alpha1
• Fix Version/s: 2.4.0
• Labels: test
• Hadoop Flags: Reviewed
• Assignee: Mit Desai
• Reporter: Mit Desai
• Created: 25/Mar/14 18:20
• Updated: 12/May/16 18:30
• Resolved: 26/Mar/14 21:26

Description

testDSShell fails when the tests are run in random order. I see a cleanup issue here.

Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 72.222 sec <<< FAILURE! - in org.apache.hadoop.yarn.applications.distributedshell.TestDistributedShell
testOrder(org.apache.hadoop.yarn.applications.distributedshell.TestDistributedShell)  Time elapsed: 44.127 sec  <<< FAILURE!
java.lang.AssertionError: expected:<1> but was:<6>
	at org.junit.Assert.fail(Assert.java:93)
	at org.junit.Assert.failNotEquals(Assert.java:647)
	at org.junit.Assert.assertEquals(Assert.java:128)
	at org.junit.Assert.assertEquals(Assert.java:472)
	at org.junit.Assert.assertEquals(Assert.java:456)
	at org.apache.hadoop.yarn.applications.distributedshell.TestDistributedShell.testDSShell(TestDistributedShell.java:204)
	at org.apache.hadoop.yarn.applications.distributedshell.TestDistributedShell.testOrder(TestDistributedShell.java:134)


Results :

Failed tests: 
  TestDistributedShell.testOrder:134->testDSShell:204 expected:<1> but was:<6>

The Line numbers will be little deviated because I was trying to reproduce the error by running the tests in specific order. But the Line that causes the assert fail is Assert.assertEquals(1, entitiesAttempts.getEntities().size());