[YARN-1750] TestNodeStatusUpdater#testNMRegistration is incorrect in test case

• Type: Test
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.4.1
• Component/s: nodemanager
• Assignee: Wangda Tan
• Reporter: Ming Ma
• Created: 22/Feb/14 00:53
• Updated: 25/Oct/19 20:25
• Resolved: 17/Apr/14 19:16

Description

This test case passes. However, the test output log has

java.lang.AssertionError: Number of applications should only be one! expected:<1> but was:<2>
at org.junit.Assert.fail(Assert.java:93)
at org.junit.Assert.failNotEquals(Assert.java:647)
at org.junit.Assert.assertEquals(Assert.java:128)
at org.junit.Assert.assertEquals(Assert.java:472)
at org.apache.hadoop.yarn.server.nodemanager.TestNodeStatusUpdater$MyResourceTracker.nodeHeartbeat(TestNodeStatusUpdater.java:267)
at org.apache.hadoop.yarn.server.nodemanager.NodeStatusUpdaterImpl$1.run(NodeStatusUpdaterImpl.java:469)
at java.lang.Thread.run(Thread.java:695)

TestNodeStatusUpdater.java has invalid asserts.

} else if (heartBeatID == 3) {
// Checks on the RM end
Assert.assertEquals("Number of applications should only be one!", 1,
appToContainers.size());
Assert.assertEquals("Number of container for the app should be two!",
2, appToContainers.get(appId2).size());

We should fix the assert and add more check to the test.