[YARN-170] NodeManager stop() gets called twice on shutdown

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.0.2-alpha
• Fix Version/s: 2.0.3-alpha, 0.23.6
• Component/s: nodemanager
• Assignee: Sandy Ryza
• Reporter: Sandy Ryza
• Created: 18/Oct/12 20:34
• Updated: 02/May/13 02:29
• Resolved: 07/Jan/13 13:46

Description

The stop method in the NodeManager gets called twice when the NodeManager is shut down via the shutdown hook.

The first is the stop that gets called directly by the shutdown hook. The second occurs when the NodeStatusUpdaterImpl is stopped. The NodeManager responds to the NodeStatusUpdaterImpl stop stateChanged event by stopping itself. This is so that NodeStatusUpdaterImpl can notify the NodeManager to stop, by stopping itself in response to a request from the ResourceManager

This could be avoided if the NodeStatusUpdaterImpl were to stop the NodeManager by calling its stop method directly.

Issue Links

• is depended upon by: YARN-72 NM should handle cleaning up containers when it shuts down