Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-1297

FairScheduler: Move some logs to debug and check if debug logging is enabled

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 2.9.0, 3.0.0-alpha1
    • fairscheduler
    • None
    • Reviewed

    Description

      I ran the Fair Scheduler's core scheduling loop through a profiler tool and identified a bunch of minimally invasive changes that can shave off a few milliseconds.

      The main one is demoting a couple INFO log messages to DEBUG, which brought my benchmark down from 16000 ms to 6000.

      A few others (which had way less of an impact) were

      • Most of the time in comparisons was being spent in Math.signum. I switched this to direct ifs and elses and it halved the percent of time spent in comparisons.
      • I removed some unnecessary instantiations of Resource objects
      • I made it so that queues' usage wasn't calculated from the applications up each time getResourceUsage was called.

      Attachments

        1. YARN-1297-2.patch
          12 kB
          Sandy Ryza
        2. YARN-1297-1.patch
          17 kB
          Sandy Ryza
        3. YARN-1297.patch
          18 kB
          Sandy Ryza
        4. YARN-1297.patch
          17 kB
          Sandy Ryza
        5. YARN-1297.4.patch
          16 kB
          Arun Suresh
        6. YARN-1297.4.patch
          16 kB
          Arun Suresh
        7. YARN-1297.3.patch
          13 kB
          Arun Suresh
        8. YARN-1297.006.patch
          8 kB
          Yufei Gu
        9. YARN-1297.005.patch
          16 kB
          Yufei Gu

        Issue Links

          Activity

            People

              yufeigu Yufei Gu
              sandyr Sandy Ryza
              Votes:
              0 Vote for this issue
              Watchers:
              10 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: