Details

    • Type: Improvement Improvement
    • Status: Patch Available
    • Priority: Major Major
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:

      Description

      A bunch of different tests have near-identical implementations of MockClock. TestFairScheduler, TestFSSchedulerApp, and TestCgroupsLCEResourcesHandler for example. They should be consolidated into a single MockClock.

      1. YARN-1287-3.patch
        8 kB
        Sebastian Wong

        Activity

        Sandy Ryza created issue -
        Hide
        Sebastian Wong added a comment -

        Where should the new MockClock class be placed directory wise?

        Show
        Sebastian Wong added a comment - Where should the new MockClock class be placed directory wise?
        Hide
        Sandy Ryza added a comment -

        It should be placed in the corresponding test directory to Yarn's Clock class, i.e. ./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/util/

        Show
        Sandy Ryza added a comment - It should be placed in the corresponding test directory to Yarn's Clock class, i.e. ./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/util/
        Hide
        Sebastian Wong added a comment -

        Unit tests pass on my machine for the affected files.

        Show
        Sebastian Wong added a comment - Unit tests pass on my machine for the affected files.
        Sebastian Wong made changes -
        Field Original Value New Value
        Attachment YARN-1287.patch [ 12617798 ]
        Sandy Ryza made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Assignee Sebastian Wong [ swong15 ]
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12617798/YARN-1287.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified test files.

        -1 javac. The patch appears to cause the build to fail.

        Console output: https://builds.apache.org/job/PreCommit-YARN-Build/2627//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12617798/YARN-1287.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 3 new or modified test files. -1 javac . The patch appears to cause the build to fail. Console output: https://builds.apache.org/job/PreCommit-YARN-Build/2627//console This message is automatically generated.
        Sebastian Wong made changes -
        Attachment YARN-1287.patch [ 12617798 ]
        Sebastian Wong made changes -
        Attachment YARN-1287-2.patch [ 12617855 ]
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12617855/YARN-1287-2.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 4 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-YARN-Build/2628//testReport/
        Console output: https://builds.apache.org/job/PreCommit-YARN-Build/2628//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12617855/YARN-1287-2.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 4 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-YARN-Build/2628//testReport/ Console output: https://builds.apache.org/job/PreCommit-YARN-Build/2628//console This message is automatically generated.
        Hide
        Sandy Ryza added a comment -

        +1

        Show
        Sandy Ryza added a comment - +1
        Hide
        Sandy Ryza added a comment -

        Actually just noticed - the MockClock class should go into the test directory, not the main source directory, i.e. it should be under src/test/java. Otherwise the patch LGTM.

        Show
        Sandy Ryza added a comment - Actually just noticed - the MockClock class should go into the test directory, not the main source directory, i.e. it should be under src/test/java. Otherwise the patch LGTM.
        Sebastian Wong made changes -
        Attachment YARN-1287-2.patch [ 12617855 ]
        Sebastian Wong made changes -
        Attachment YARN-1287-3.patch [ 12621778 ]
        Sebastian Wong made changes -
        Attachment YARN-1287-3.patch [ 12621778 ]
        Sebastian Wong made changes -
        Attachment YARN-1287-3.patch [ 12621781 ]
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12621778/YARN-1287-3.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 4 new or modified test files.

        -1 javac. The patch appears to cause the build to fail.

        Console output: https://builds.apache.org/job/PreCommit-YARN-Build/2812//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12621778/YARN-1287-3.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 4 new or modified test files. -1 javac . The patch appears to cause the build to fail. Console output: https://builds.apache.org/job/PreCommit-YARN-Build/2812//console This message is automatically generated.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12621781/YARN-1287-3.patch
        against trunk revision .

        -1 patch. Trunk compilation may be broken.

        Console output: https://builds.apache.org/job/PreCommit-YARN-Build/2813//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12621781/YARN-1287-3.patch against trunk revision . -1 patch . Trunk compilation may be broken. Console output: https://builds.apache.org/job/PreCommit-YARN-Build/2813//console This message is automatically generated.

          People

          • Assignee:
            Sebastian Wong
            Reporter:
            Sandy Ryza
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:

              Development