Hadoop YARN
  1. Hadoop YARN
  2. YARN-117 Enhance YARN service model
  3. YARN-122

CompositeService should clone the Configurations it passes to children

    Details

    • Type: Sub-task Sub-task
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Invalid
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      CompositeService.init(Configuration) saves the configuration passed in and passes the same instance down to all managed services. This means a change in the configuration of one child could propagate to all the others.

      Unless this is desired, the configuration should be cloned for each child.

      Fast and easy fix; tests can be added to those coming in MAPREDUCE-4014

        Issue Links

          Activity

          Gavin made changes -
          Link This issue depends upon YARN-120 [ YARN-120 ]
          Gavin made changes -
          Link This issue depends on YARN-120 [ YARN-120 ]
          Steve Loughran made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Resolution Invalid [ 6 ]
          Hide
          Steve Loughran added a comment -

          Resolving as INVALID as some composite services (e.g. MiniYARNCluster use shared config object as way of sharing information -such as allocated ports.

          Show
          Steve Loughran added a comment - Resolving as INVALID as some composite services (e.g. MiniYARNCluster use shared config object as way of sharing information -such as allocated ports.
          Steve Loughran made changes -
          Priority Major [ 3 ] Minor [ 4 ]
          Hide
          Steve Loughran added a comment -

          This requires Configuration to implement clone() as a public method, so that any subclass of it, such as YarnConfiguration will still be passed down to the children

          Show
          Steve Loughran added a comment - This requires Configuration to implement clone() as a public method, so that any subclass of it, such as YarnConfiguration will still be passed down to the children
          Vinod Kumar Vavilapalli made changes -
          Project Hadoop Map/Reduce [ 12310941 ] Hadoop YARN [ 12313722 ]
          Key MAPREDUCE-4016 YARN-122
          Affects Version/s 0.24.0 [ 12317654 ]
          Affects Version/s 0.23.1 [ 12318883 ]
          Component/s mrv2 [ 12314301 ]
          Steve Loughran made changes -
          Field Original Value New Value
          Link This issue depends on MAPREDUCE-4014 [ MAPREDUCE-4014 ]
          Steve Loughran created issue -

            People

            • Assignee:
              Unassigned
              Reporter:
              Steve Loughran
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 0.5h
                0.5h
                Remaining:
                Remaining Estimate - 0.5h
                0.5h
                Logged:
                Time Spent - Not Specified
                Not Specified

                  Development