Hadoop YARN
  1. Hadoop YARN
  2. YARN-1157

ResourceManager UI has invalid tracking URL link for distributed shell application

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.2.0
    • Component/s: resourcemanager
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Submit YARN distributed shell application. Goto ResourceManager Web UI. The application definitely appears. In Tracking UI column, there will be history link. Click on that link. Instead of showing application master web UI, HTTP error 500 would appear.

      1. YARN-1157.8.patch
        18 kB
        Xuan Gong
      2. YARN-1157.8.patch
        18 kB
        Vinod Kumar Vavilapalli
      3. YARN-1157.7.patch
        18 kB
        Vinod Kumar Vavilapalli
      4. YARN-1157.6.patch
        17 kB
        Xuan Gong
      5. YARN-1157.5.patch
        17 kB
        Xuan Gong
      6. YARN-1157.4.patch
        17 kB
        Xuan Gong
      7. YARN-1157.3.patch
        14 kB
        Xuan Gong
      8. YARN-1157.2.patch
        14 kB
        Xuan Gong
      9. YARN-1157.2.patch
        14 kB
        Xuan Gong
      10. YARN-1157.1.patch
        1 kB
        Xuan Gong

        Activity

        Hide
        Xuan Gong added a comment -

        Trivial patch, no test cases added

        Show
        Xuan Gong added a comment - Trivial patch, no test cases added
        Hide
        Xuan Gong added a comment -

        The reason is: At RMAppAttemptImpl::generateProxyUriWithoutScheme(String)

              return result.toASCIIString().substring(HttpConfig.getSchemePrefix().length());
        

        can return an empty String,

        But at WebAppProxyServlet, it only check whether the urlString is null or not, we should also check the empty string.

        Show
        Xuan Gong added a comment - The reason is: At RMAppAttemptImpl::generateProxyUriWithoutScheme(String) return result.toASCIIString().substring(HttpConfig.getSchemePrefix().length()); can return an empty String, But at WebAppProxyServlet, it only check whether the urlString is null or not, we should also check the empty string.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12603030/YARN-1157.1.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-YARN-Build/1915//testReport/
        Console output: https://builds.apache.org/job/PreCommit-YARN-Build/1915//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12603030/YARN-1157.1.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-YARN-Build/1915//testReport/ Console output: https://builds.apache.org/job/PreCommit-YARN-Build/1915//console This message is automatically generated.
        Hide
        Jian He added a comment -

        can return an empty String

        looks like it returns empty string because Distributed Shell registered the URL as empty string.
        we probably can sanity check in AMRegisteredTransition/AMUnregisteredTransition that if it's empty String, leave the appAttempt.origTrackingUrl still as "N/A".
        Then we don't need to special case the empty string in WebAppProxyServlet

        Also, In fact in RegisterApplicationMasterRequest's comment, users are already instructed to use 'null' as default value, but in FinishApplicationMasterRequest, we don't have, we can also add that in the comment.

        Show
        Jian He added a comment - can return an empty String looks like it returns empty string because Distributed Shell registered the URL as empty string. we probably can sanity check in AMRegisteredTransition/AMUnregisteredTransition that if it's empty String, leave the appAttempt.origTrackingUrl still as "N/A". Then we don't need to special case the empty string in WebAppProxyServlet Also, In fact in RegisterApplicationMasterRequest's comment, users are already instructed to use 'null' as default value, but in FinishApplicationMasterRequest, we don't have, we can also add that in the comment.
        Hide
        Vinod Kumar Vavilapalli added a comment -

        Tx guys, couple of comments:

        • Agree with Jian, all users of the trackingUrl, for e.g. ApplicationReport will have the same issue. So let's make sure that once registration and finish-app is done, the url in RM's memory is always "N/A" if not explicitly set by AM.
        • Let's document RegisterApplicationMasterRequest.getTrackingUrl() and setTrackingUrl() to describe that empty, null, "N/A" strings are all valid besides a real URL.
        • Similarly FinishApplicationMasterRequest.

        The real underlying problem is that tracking URL is a string and not a URL Too late to make incompatible changes, but I'll file a ticket.

        Show
        Vinod Kumar Vavilapalli added a comment - Tx guys, couple of comments: Agree with Jian, all users of the trackingUrl, for e.g. ApplicationReport will have the same issue. So let's make sure that once registration and finish-app is done, the url in RM's memory is always "N/A" if not explicitly set by AM. Let's document RegisterApplicationMasterRequest.getTrackingUrl() and setTrackingUrl() to describe that empty, null, "N/A" strings are all valid besides a real URL. Similarly FinishApplicationMasterRequest. The real underlying problem is that tracking URL is a string and not a URL Too late to make incompatible changes, but I'll file a ticket.
        Hide
        Vinod Kumar Vavilapalli added a comment -

        The real underlying problem is that tracking URL is a string and not a URL Too late to make incompatible changes, but I'll file a ticket.

        Filed YARN-1211.

        Show
        Vinod Kumar Vavilapalli added a comment - The real underlying problem is that tracking URL is a string and not a URL Too late to make incompatible changes, but I'll file a ticket. Filed YARN-1211 .
        Hide
        Xuan Gong added a comment -

        Thanks, Vinod Kumar Vavilapalli and Jian He for the comments.

        I agree with all your comments. We can definitely fix this problem by adding check in AMRegisteredTransition/AMUnregisteredTransition as Jian mentioned. But just for this ticket, when the yarn application (distributed shell) is finished, the applicationMaster will do

        resourceManager.unregisterApplicationMaster(appStatus, appMessage, null)
        

        And at RMAppAttempt::AMUnregisteredTransition(), the orginalUrl will overwritten by

              appAttempt.origTrackingUrl = unregisterEvent.getTrackingUrl();
        

        Here, we can find that ApplicationMaster has already set url as null. But why can we still get the orginalUrl as empty string ?
        I think that the real problem happens in FinishApplicationMasterRequestPBImpl::setTrackingUrl(String)

          @Override
          public void setTrackingUrl(String url) {
            maybeInitBuilder();
            if (url == null) {
              builder.clearTrackingUrl();
              return;
            }
            builder.setTrackingUrl(url);
          }
        

        So, even we already set the url as Null, when we create the FinishApplicationMasterRequest, the url will be as empty string.

        Anyway, I think adding the check should solve this issue.

        Show
        Xuan Gong added a comment - Thanks, Vinod Kumar Vavilapalli and Jian He for the comments. I agree with all your comments. We can definitely fix this problem by adding check in AMRegisteredTransition/AMUnregisteredTransition as Jian mentioned. But just for this ticket, when the yarn application (distributed shell) is finished, the applicationMaster will do resourceManager.unregisterApplicationMaster(appStatus, appMessage, null ) And at RMAppAttempt::AMUnregisteredTransition(), the orginalUrl will overwritten by appAttempt.origTrackingUrl = unregisterEvent.getTrackingUrl(); Here, we can find that ApplicationMaster has already set url as null. But why can we still get the orginalUrl as empty string ? I think that the real problem happens in FinishApplicationMasterRequestPBImpl::setTrackingUrl(String) @Override public void setTrackingUrl( String url) { maybeInitBuilder(); if (url == null ) { builder.clearTrackingUrl(); return ; } builder.setTrackingUrl(url); } So, even we already set the url as Null, when we create the FinishApplicationMasterRequest, the url will be as empty string. Anyway, I think adding the check should solve this issue.
        Hide
        Xuan Gong added a comment -

        all users of the trackingUrl, for e.g. ApplicationReport will have the same issue. So let's make sure that once registration and finish-app is done, the url in RM's memory is always "N/A" if not explicitly set by AM.

        Adding this logic in both AMRegisteredTransition/AMUnregisteredTransition

              String url = registrationEvent.getTrackingurl();
              if (url == null || url.trim().isEmpty()) {
                appAttempt.origTrackingUrl = "N/A";
              } else {
                appAttempt.origTrackingUrl = url;
              }
        

        Let's document RegisterApplicationMasterRequest.getTrackingUrl() and setTrackingUrl() to describe that empty, null, "N/A" strings are all valid besides a real URL.

        Done

        Similarly FinishApplicationMasterRequest.

        Done

        Also added a new testcase, fixed the testcase failure

        Show
        Xuan Gong added a comment - all users of the trackingUrl, for e.g. ApplicationReport will have the same issue. So let's make sure that once registration and finish-app is done, the url in RM's memory is always "N/A" if not explicitly set by AM. Adding this logic in both AMRegisteredTransition/AMUnregisteredTransition String url = registrationEvent.getTrackingurl(); if (url == null || url.trim().isEmpty()) { appAttempt.origTrackingUrl = "N/A" ; } else { appAttempt.origTrackingUrl = url; } Let's document RegisterApplicationMasterRequest.getTrackingUrl() and setTrackingUrl() to describe that empty, null, "N/A" strings are all valid besides a real URL. Done Similarly FinishApplicationMasterRequest. Done Also added a new testcase, fixed the testcase failure
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12603734/YARN-1157.2.patch
        against trunk revision .

        -1 patch. Trunk compilation may be broken.

        Console output: https://builds.apache.org/job/PreCommit-YARN-Build/1951//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12603734/YARN-1157.2.patch against trunk revision . -1 patch . Trunk compilation may be broken. Console output: https://builds.apache.org/job/PreCommit-YARN-Build/1951//console This message is automatically generated.
        Hide
        Xuan Gong added a comment -

        Kick off the Jenkins again

        Show
        Xuan Gong added a comment - Kick off the Jenkins again
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12603749/YARN-1157.2.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 2 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-YARN-Build/1952//testReport/
        Console output: https://builds.apache.org/job/PreCommit-YARN-Build/1952//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12603749/YARN-1157.2.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 2 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-YARN-Build/1952//testReport/ Console output: https://builds.apache.org/job/PreCommit-YARN-Build/1952//console This message is automatically generated.
        Hide
        Vinod Kumar Vavilapalli added a comment -

        The patch is not applying more, can you please update? Tx.

        Show
        Vinod Kumar Vavilapalli added a comment - The patch is not applying more, can you please update? Tx.
        Hide
        Xuan Gong added a comment -

        Update patch based on latest trunk

        Show
        Xuan Gong added a comment - Update patch based on latest trunk
        Hide
        Jian He added a comment -

        For the following code, we may create a common function for both AMRegisteredTransition and AMUnregisteredTransition

              String url = unregisterEvent.getTrackingUrl();
              if (url == null || url.trim().isEmpty()) {
                appAttempt.origTrackingUrl = "N/A";
              } else {
                appAttempt.origTrackingUrl = url;
              }
              appAttempt.proxiedTrackingUrl = 
                appAttempt.generateProxyUriWithoutScheme(appAttempt.origTrackingUrl);
        

        Let's document RegisterApplicationMasterRequest.getTrackingUrl() and setTrackingUrl()

        Can you also document in the specific method comments ? for both registerRequest and unregisterRequest. And also say something like for those default values, will fallback to ResourceManager's app page

        Typo in RegisterApplicationMasterRequest: are all "values"

        The tests can probably be done with TestRMAppAttemptTransitions.runApplicationAttempt, In fact,the earlier tests in TestRMAppAttemptImpl can probably also be merged into TestRMAppAttemptTransitions. and so we don't need to change the visibility of AMregisteredTransition and AMUnregisteredTransition.

        Show
        Jian He added a comment - For the following code, we may create a common function for both AMRegisteredTransition and AMUnregisteredTransition String url = unregisterEvent.getTrackingUrl(); if (url == null || url.trim().isEmpty()) { appAttempt.origTrackingUrl = "N/A" ; } else { appAttempt.origTrackingUrl = url; } appAttempt.proxiedTrackingUrl = appAttempt.generateProxyUriWithoutScheme(appAttempt.origTrackingUrl); Let's document RegisterApplicationMasterRequest.getTrackingUrl() and setTrackingUrl() Can you also document in the specific method comments ? for both registerRequest and unregisterRequest. And also say something like for those default values, will fallback to ResourceManager's app page Typo in RegisterApplicationMasterRequest: are all "values" The tests can probably be done with TestRMAppAttemptTransitions.runApplicationAttempt, In fact,the earlier tests in TestRMAppAttemptImpl can probably also be merged into TestRMAppAttemptTransitions. and so we don't need to change the visibility of AMregisteredTransition and AMUnregisteredTransition.
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12604637/YARN-1157.3.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 2 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-YARN-Build/1987//testReport/
        Console output: https://builds.apache.org/job/PreCommit-YARN-Build/1987//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12604637/YARN-1157.3.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 2 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-YARN-Build/1987//testReport/ Console output: https://builds.apache.org/job/PreCommit-YARN-Build/1987//console This message is automatically generated.
        Hide
        Xuan Gong added a comment -

        For the following code, we may create a common function for both AMRegisteredTransition and AMUnregisteredTransition

        Done

        Can you also document in the specific method comments ? for both registerRequest and unregisterRequest. And also say something like for those default values, will fallback to ResourceManager's app page

        Added

        Typo in RegisterApplicationMasterRequest: are all "values"

        Fixed

        The tests can probably be done with TestRMAppAttemptTransitions.runApplicationAttempt, In fact,the earlier tests in TestRMAppAttemptImpl can probably also be merged into TestRMAppAttemptTransitions. and so we don't need to change the visibility of AMregisteredTransition and AMUnregisteredTransition.

        Removed TestRMAppAttemptImpl. We will cover all its tests in TestRMAppAttemptTransitions. Change the visibility of AMregisteredTransition and AMUnregisteredTransition back to private.

        Show
        Xuan Gong added a comment - For the following code, we may create a common function for both AMRegisteredTransition and AMUnregisteredTransition Done Can you also document in the specific method comments ? for both registerRequest and unregisterRequest. And also say something like for those default values, will fallback to ResourceManager's app page Added Typo in RegisterApplicationMasterRequest: are all "values" Fixed The tests can probably be done with TestRMAppAttemptTransitions.runApplicationAttempt, In fact,the earlier tests in TestRMAppAttemptImpl can probably also be merged into TestRMAppAttemptTransitions. and so we don't need to change the visibility of AMregisteredTransition and AMUnregisteredTransition. Removed TestRMAppAttemptImpl. We will cover all its tests in TestRMAppAttemptTransitions. Change the visibility of AMregisteredTransition and AMUnregisteredTransition back to private.
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12604723/YARN-1157.4.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-YARN-Build/1994//testReport/
        Console output: https://builds.apache.org/job/PreCommit-YARN-Build/1994//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12604723/YARN-1157.4.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-YARN-Build/1994//testReport/ Console output: https://builds.apache.org/job/PreCommit-YARN-Build/1994//console This message is automatically generated.
        Hide
        Xuan Gong added a comment -

        create the patch based on the latest trunk

        Show
        Xuan Gong added a comment - create the patch based on the latest trunk
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12604851/YARN-1157.5.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-YARN-Build/2003//testReport/
        Console output: https://builds.apache.org/job/PreCommit-YARN-Build/2003//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12604851/YARN-1157.5.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-YARN-Build/2003//testReport/ Console output: https://builds.apache.org/job/PreCommit-YARN-Build/2003//console This message is automatically generated.
        Hide
        Xuan Gong added a comment -

        Adding more comments in RegisterApplicationMasterRequest and FinishApplicationMasterRequest

        Show
        Xuan Gong added a comment - Adding more comments in RegisterApplicationMasterRequest and FinishApplicationMasterRequest
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12604859/YARN-1157.6.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-YARN-Build/2004//testReport/
        Console output: https://builds.apache.org/job/PreCommit-YARN-Build/2004//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12604859/YARN-1157.6.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-YARN-Build/2004//testReport/ Console output: https://builds.apache.org/job/PreCommit-YARN-Build/2004//console This message is automatically generated.
        Hide
        Jian He added a comment -

        Tests look much clean, thanks for the update, patch looks good, + 1

        Show
        Jian He added a comment - Tests look much clean, thanks for the update, patch looks good, + 1
        Hide
        Vinod Kumar Vavilapalli added a comment -

        Patch looks good to me too, except for the javadoc. Will upload the javadoc fixes myself.

        Show
        Vinod Kumar Vavilapalli added a comment - Patch looks good to me too, except for the javadoc. Will upload the javadoc fixes myself.
        Hide
        Vinod Kumar Vavilapalli added a comment -

        Same patch with javadoc fixes and a method rename.

        Show
        Vinod Kumar Vavilapalli added a comment - Same patch with javadoc fixes and a method rename.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12605142/YARN-1157.7.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        -1 javadoc. The javadoc tool appears to have generated 1 warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-YARN-Build/2019//testReport/
        Console output: https://builds.apache.org/job/PreCommit-YARN-Build/2019//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12605142/YARN-1157.7.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. -1 javadoc . The javadoc tool appears to have generated 1 warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-YARN-Build/2019//testReport/ Console output: https://builds.apache.org/job/PreCommit-YARN-Build/2019//console This message is automatically generated.
        Hide
        Xuan Gong added a comment -

        fix -1 on javadoc warning

        Show
        Xuan Gong added a comment - fix -1 on javadoc warning
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12605160/YARN-1157.8.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-YARN-Build/2021//testReport/
        Console output: https://builds.apache.org/job/PreCommit-YARN-Build/2021//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12605160/YARN-1157.8.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-YARN-Build/2021//testReport/ Console output: https://builds.apache.org/job/PreCommit-YARN-Build/2021//console This message is automatically generated.
        Hide
        Vinod Kumar Vavilapalli added a comment -

        Committed this to trunk, branch-2 and branch-2.1. Thanks Xuan!

        Show
        Vinod Kumar Vavilapalli added a comment - Committed this to trunk, branch-2 and branch-2.1. Thanks Xuan!
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in Hadoop-trunk-Commit #4470 (See https://builds.apache.org/job/Hadoop-trunk-Commit/4470/)
        YARN-1157. Fixed ResourceManager UI to behave correctly when apps like distributed-shell do not set tracking urls. Contributed by Xuan Gong. (vinodkv: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1526371)

        • /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/FinishApplicationMasterRequest.java
        • /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/RegisterApplicationMasterRequest.java
        • /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/attempt/RMAppAttemptImpl.java
        • /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/attempt/TestRMAppAttemptImpl.java
        • /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/attempt/TestRMAppAttemptTransitions.java
        Show
        Hudson added a comment - SUCCESS: Integrated in Hadoop-trunk-Commit #4470 (See https://builds.apache.org/job/Hadoop-trunk-Commit/4470/ ) YARN-1157 . Fixed ResourceManager UI to behave correctly when apps like distributed-shell do not set tracking urls. Contributed by Xuan Gong. (vinodkv: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1526371 ) /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/FinishApplicationMasterRequest.java /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/RegisterApplicationMasterRequest.java /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/attempt/RMAppAttemptImpl.java /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/attempt/TestRMAppAttemptImpl.java /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/attempt/TestRMAppAttemptTransitions.java
        Hide
        Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk #344 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/344/)
        YARN-1157. Fixed ResourceManager UI to behave correctly when apps like distributed-shell do not set tracking urls. Contributed by Xuan Gong. (vinodkv: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1526371)

        • /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/FinishApplicationMasterRequest.java
        • /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/RegisterApplicationMasterRequest.java
        • /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/attempt/RMAppAttemptImpl.java
        • /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/attempt/TestRMAppAttemptImpl.java
        • /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/attempt/TestRMAppAttemptTransitions.java
        Show
        Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #344 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/344/ ) YARN-1157 . Fixed ResourceManager UI to behave correctly when apps like distributed-shell do not set tracking urls. Contributed by Xuan Gong. (vinodkv: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1526371 ) /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/FinishApplicationMasterRequest.java /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/RegisterApplicationMasterRequest.java /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/attempt/RMAppAttemptImpl.java /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/attempt/TestRMAppAttemptImpl.java /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/attempt/TestRMAppAttemptTransitions.java
        Hide
        Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk #1560 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1560/)
        YARN-1157. Fixed ResourceManager UI to behave correctly when apps like distributed-shell do not set tracking urls. Contributed by Xuan Gong. (vinodkv: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1526371)

        • /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/FinishApplicationMasterRequest.java
        • /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/RegisterApplicationMasterRequest.java
        • /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/attempt/RMAppAttemptImpl.java
        • /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/attempt/TestRMAppAttemptImpl.java
        • /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/attempt/TestRMAppAttemptTransitions.java
        Show
        Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #1560 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1560/ ) YARN-1157 . Fixed ResourceManager UI to behave correctly when apps like distributed-shell do not set tracking urls. Contributed by Xuan Gong. (vinodkv: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1526371 ) /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/FinishApplicationMasterRequest.java /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/RegisterApplicationMasterRequest.java /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/attempt/RMAppAttemptImpl.java /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/attempt/TestRMAppAttemptImpl.java /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/attempt/TestRMAppAttemptTransitions.java
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Hdfs-trunk #1534 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1534/)
        YARN-1157. Fixed ResourceManager UI to behave correctly when apps like distributed-shell do not set tracking urls. Contributed by Xuan Gong. (vinodkv: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1526371)

        • /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/FinishApplicationMasterRequest.java
        • /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/RegisterApplicationMasterRequest.java
        • /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/attempt/RMAppAttemptImpl.java
        • /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/attempt/TestRMAppAttemptImpl.java
        • /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/attempt/TestRMAppAttemptTransitions.java
        Show
        Hudson added a comment - SUCCESS: Integrated in Hadoop-Hdfs-trunk #1534 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1534/ ) YARN-1157 . Fixed ResourceManager UI to behave correctly when apps like distributed-shell do not set tracking urls. Contributed by Xuan Gong. (vinodkv: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1526371 ) /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/FinishApplicationMasterRequest.java /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/RegisterApplicationMasterRequest.java /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/attempt/RMAppAttemptImpl.java /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/attempt/TestRMAppAttemptImpl.java /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/attempt/TestRMAppAttemptTransitions.java

          People

          • Assignee:
            Xuan Gong
            Reporter:
            Tassapol Athiapinya
          • Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development