[YARN-11334] [Federation] Improve SubClusterState#fromString parameter and LogMessage

• Type: Sub-task
• Status: Resolved
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 3.4.0
• Fix Version/s: 3.4.0
• Component/s: federation
• Labels: pull-request-available
• Target Version/s: 3.4.0
• Hadoop Flags: Reviewed
• Assignee: Shilun Fan
• Reporter: Shilun Fan
• Created: 09/Oct/22 07:05
• Updated: 16/Sep/23 02:09
• Resolved: 13/Oct/22 06:37

Description

The SubClusterState object has a fromString method, which can be improved in the following 2 places

/**
 * Convert a string into {@code SubClusterState}.
 *
 * @param x the string to convert in SubClusterState
 * @return the respective {@code SubClusterState}
 */
public static SubClusterState fromString(String x) {
  try {
    return SubClusterState.valueOf(x);
  } catch (Exception e) {
    LOG.error("Invalid SubCluster State value in the StateStore does not"
        + " match with the YARN Federation standard.");
    return null;
  }
} 

• The parameter is named x, which cannot well express the meaning of the input parameter.
• The error log does not print the error value.

Issue Links

• links to: GitHub Pull Request #4988