Hadoop YARN
  1. Hadoop YARN
  2. YARN-108

FSDownload can create cache directories with the wrong permissions

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 0.23.3, 2.0.0-alpha
    • Fix Version/s: 2.0.2-alpha, 0.23.4
    • Component/s: nodemanager
    • Labels:
      None

      Description

      When the cluster is configured with a restrictive umask, e.g.: fs.permissions.umask-mode=0077, the nodemanager can end up creating directory entries in the public cache with the wrong permissions. The permissions can end up where only the nodemanager user can access files in the public cache, preventing jobs from running properly.

        Issue Links

          Activity

          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk #1200 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1200/)
          YARN-108. FSDownload can create cache directories with the wrong permissions (Jason Lowe via bobby) (Revision 1386838)

          Result = SUCCESS
          bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1386838
          Files :

          • /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt
          • /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/util/FSDownload.java
          • /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/util/TestFSDownload.java
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1200 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1200/ ) YARN-108 . FSDownload can create cache directories with the wrong permissions (Jason Lowe via bobby) (Revision 1386838) Result = SUCCESS bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1386838 Files : /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/util/FSDownload.java /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/util/TestFSDownload.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk #1169 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1169/)
          YARN-108. FSDownload can create cache directories with the wrong permissions (Jason Lowe via bobby) (Revision 1386838)

          Result = SUCCESS
          bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1386838
          Files :

          • /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt
          • /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/util/FSDownload.java
          • /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/util/TestFSDownload.java
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1169 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1169/ ) YARN-108 . FSDownload can create cache directories with the wrong permissions (Jason Lowe via bobby) (Revision 1386838) Result = SUCCESS bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1386838 Files : /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/util/FSDownload.java /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/util/TestFSDownload.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-0.23-Build #378 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/378/)
          svn merge -c 1386838 FIXES: YARN-108. FSDownload can create cache directories with the wrong permissions (Jason Lowe via bobby) (Revision 1386844)

          Result = UNSTABLE
          bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1386844
          Files :

          • /hadoop/common/branches/branch-0.23/hadoop-yarn-project/CHANGES.txt
          • /hadoop/common/branches/branch-0.23/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/util/FSDownload.java
          • /hadoop/common/branches/branch-0.23/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/util/TestFSDownload.java
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Build #378 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/378/ ) svn merge -c 1386838 FIXES: YARN-108 . FSDownload can create cache directories with the wrong permissions (Jason Lowe via bobby) (Revision 1386844) Result = UNSTABLE bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1386844 Files : /hadoop/common/branches/branch-0.23/hadoop-yarn-project/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/util/FSDownload.java /hadoop/common/branches/branch-0.23/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/util/TestFSDownload.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk-Commit #2762 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2762/)
          YARN-108. FSDownload can create cache directories with the wrong permissions (Jason Lowe via bobby) (Revision 1386838)

          Result = FAILURE
          bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1386838
          Files :

          • /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt
          • /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/util/FSDownload.java
          • /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/util/TestFSDownload.java
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #2762 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2762/ ) YARN-108 . FSDownload can create cache directories with the wrong permissions (Jason Lowe via bobby) (Revision 1386838) Result = FAILURE bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1386838 Files : /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/util/FSDownload.java /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/util/TestFSDownload.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk-Commit #2801 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2801/)
          YARN-108. FSDownload can create cache directories with the wrong permissions (Jason Lowe via bobby) (Revision 1386838)

          Result = SUCCESS
          bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1386838
          Files :

          • /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt
          • /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/util/FSDownload.java
          • /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/util/TestFSDownload.java
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #2801 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2801/ ) YARN-108 . FSDownload can create cache directories with the wrong permissions (Jason Lowe via bobby) (Revision 1386838) Result = SUCCESS bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1386838 Files : /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/util/FSDownload.java /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/util/TestFSDownload.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #2738 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2738/)
          YARN-108. FSDownload can create cache directories with the wrong permissions (Jason Lowe via bobby) (Revision 1386838)

          Result = SUCCESS
          bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1386838
          Files :

          • /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt
          • /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/util/FSDownload.java
          • /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/util/TestFSDownload.java
          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #2738 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2738/ ) YARN-108 . FSDownload can create cache directories with the wrong permissions (Jason Lowe via bobby) (Revision 1386838) Result = SUCCESS bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1386838 Files : /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/util/FSDownload.java /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/util/TestFSDownload.java
          Hide
          Robert Joseph Evans added a comment -

          Thanks Jason,

          I put this into trunk, branch-2, and branch-0.23

          Show
          Robert Joseph Evans added a comment - Thanks Jason, I put this into trunk, branch-2, and branch-0.23
          Hide
          Robert Joseph Evans added a comment -

          The change looks good to me and Jenkis is OK with it +1. I'll check it in.

          Show
          Robert Joseph Evans added a comment - The change looks good to me and Jenkis is OK with it +1. I'll check it in.
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12545462/YARN-108.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 1 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-YARN-Build/40//testReport/
          Console output: https://builds.apache.org/job/PreCommit-YARN-Build/40//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12545462/YARN-108.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The javadoc tool did not generate any warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-YARN-Build/40//testReport/ Console output: https://builds.apache.org/job/PreCommit-YARN-Build/40//console This message is automatically generated.
          Hide
          Jason Lowe added a comment -

          Patch to have FSDownload explicitly set the permissions of directories after creating them if the umask is too restrictive to set the requested permissions on create.

          Show
          Jason Lowe added a comment - Patch to have FSDownload explicitly set the permissions of directories after creating them if the umask is too restrictive to set the requested permissions on create.

            People

            • Assignee:
              Jason Lowe
              Reporter:
              Jason Lowe
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development