[YARN-10648] NM local logs are not cleared after uploading to hdfs

• Type: Bug
• Status: Patch Available
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: 3.2.0
• Component/s: log-aggregation
• Assignee: D M Murali Krishna Reddy
• Reporter: D M Murali Krishna Reddy
• Created: 23/Feb/21 06:59
• Updated: 04/May/21 23:26

Description

YARN-8273 has induced the following issues.

1. The delService.delete(deletionTask) has been removed from the for loop, and added at the end in finally block. Inside the for loop  we are creating FileDeletionTask for each container, but not storing it, due to this, only the last container log files will be present in the deletionTask and only those files will be removed. Ideally all the container log files which are uploaded must be deleted.
2. The LogAggregationDFSException is caught in the closeswriter, but when we configure LogAggregationTFileController as logAggregationFileController,  this.logAggregationFileController.closeWriter()  itself calls closeWriter, which throws LogAggregationDFSException if any, and the exception is not saved. Again when we try to do closeWriter we dont get any exception and, we are not throwing the LogAggregationDFSException in this scenario.

Issue Links

• is broken by: YARN-8273 Log aggregation does not warn if HDFS quota in target directory is exceeded