Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-10889 [Umbrella] Queue Creation in Capacity Scheduler - Tech debts
  3. YARN-10590

Consider legacy auto queue creation absolute resource template to avoid rounding errors

    XMLWordPrintableJSON

Details

    • Reviewed

    Description

      "Because as we discussed in YARN-10504 , the initialization of auto created queues from template was changed (see comment and comment)."

      1. As the comment we discussed, we found the effective core is different(the gap), because the update effective  will override the absolute auto created leaf queue.

      2. But actually, the new logic in YARN-10504 override is right, the difference is caused by test case , don't consider the calculation loss of multi resource type, the cap/absolute are all calculated by one type, (memory) in DefaultResourceCalculator, (dominant type) in DominantResourceCalculator. As we known in the comment, the absolute auto created leaf queue will merge the effective resource by cap/absolute calculated result, this caused the gap.

      2. In other case(not absolute case) in the auto created leaf queue, the merge will not cause the gap, in update effective resource override will also use the one type calculated result. 

      3. So this jira just make the test right, the calculation result is already right.

      Attachments

        1. YARN-10590.001.patch
          3 kB
          Qi Zhu
        2. YARN-10590.002.patch
          3 kB
          Qi Zhu

        Issue Links

          Activity

            People

              gandras Andras Gyori
              zhuqi Qi Zhu
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 40m
                  40m