Details
-
Improvement
-
Status: Resolved
-
Minor
-
Resolution: Fixed
-
3.4.0
-
None
-
Reviewed
Description
SLSRunner has too many responsibilities.
One of them is to parse the job details from the SLS input formats and launch the AMs and task containers.
As a first step, the job parser logic could be decoupled from this class.
There are 3 types of inputs:
- SLS trace
- Synth
- Rumen
Their job parsing method are:
- SLS trace: https://github.com/apache/hadoop/blob/005b854f6bad66defafae0abf95dabc6c36ca8b1/hadoop-tools/hadoop-sls/src/main/java/org/apache/hadoop/yarn/sls/SLSRunner.java#L479-L526
- Synth: https://github.com/apache/hadoop/blob/005b854f6bad66defafae0abf95dabc6c36ca8b1/hadoop-tools/hadoop-sls/src/main/java/org/apache/hadoop/yarn/sls/SLSRunner.java#L722-L790
- Rumen: https://github.com/apache/hadoop/blob/005b854f6bad66defafae0abf95dabc6c36ca8b1/hadoop-tools/hadoop-sls/src/main/java/org/apache/hadoop/yarn/sls/SLSRunner.java#L651-L716
Attachments
Attachments
Issue Links
- Dependency
-
YARN-10548 Decouple AM runner logic from SLSRunner
- Resolved
-
YARN-10549 Decouple RM runner logic from SLSRunner
- Resolved
-
YARN-10550 Decouple NM runner logic from SLSRunner
- Resolved
- is related to
-
YARN-11094 Follow up changes for YARN-10547
- Resolved