[YARN-10198] [managedParent].%primary_group mapping rule doesn't work after YARN-9868

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 3.3.0
• Component/s: capacity scheduler
• Hadoop Flags: Reviewed
• Assignee: Peter Bacsko
• Reporter: Peter Bacsko
• Created: 13/Mar/20 14:51
• Updated: 08/Apr/20 13:56
• Resolved: 23/Mar/20 12:32

Description

YARN-9868 introduced an unnecessary check if we have the following placement rule:

[managedParentQueue].%primary_group

Here, %primary_group is expected to be created if it doesn't exist. However, there is this validation code which is not necessary:

          } else if (mapping.getQueue().equals(PRIMARY_GROUP_MAPPING)) {
            if (this.queueManager
                .getQueue(groups.getGroups(user).get(0)) != null) {
              return getPlacementContext(mapping,
                  groups.getGroups(user).get(0));
            } else {
              return null;
            }

We should revert this part to the original version:

          } else if (mapping.queue.equals(PRIMARY_GROUP_MAPPING)) {
            return getPlacementContext(mapping, groups.getGroups(user).get(0));
        }

Issue Links

• is related to: YARN-10199 Simplify UserGroupMappingPlacementRule#getPlacementForUser
• relates to: YARN-10226 NPE in Capacity Scheduler while using %primary_group queue mapping