[YARN-10108] FS-CS converter: nestedUserQueue with default rule results in invalid queue mapping

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.3.0
• Fix Version/s: 3.4.0, 3.3.1
• Component/s: capacity scheduler, fs-cs
• Labels: fs2cs
• Target Version/s: 3.4.0, 3.3.1
• Hadoop Flags: Reviewed
• Assignee: Gergely Pollák
• Reporter: Prabhu Joseph
• Created: 28/Jan/20 10:54
• Updated: 12/Feb/24 00:10
• Resolved: 27/May/20 11:09

Description

FS Queue Placement Policy

<queuePlacementPolicy>
<rule name="nestedUserQueue">
<rule name="default" queue="users"/>
</rule>
</queuePlacementPolicy>
 

gets mapped to an invalid CS queue mapping "u:%user:root.users.%user"

RM fails to start with above queue mapping in CS

2020-01-28 00:19:12,889 FATAL org.apache.hadoop.yarn.server.resourcemanager.ResourceManager: Error starting ResourceManager
org.apache.hadoop.service.ServiceStateException: java.io.IOException: mapping contains invalid or non-leaf queue [%user] and invalid parent queue [root.users]
	at org.apache.hadoop.service.ServiceStateException.convert(ServiceStateException.java:105)
	at org.apache.hadoop.service.AbstractService.init(AbstractService.java:173)
	at org.apache.hadoop.service.CompositeService.serviceInit(CompositeService.java:108)
	at org.apache.hadoop.yarn.server.resourcemanager.ResourceManager$RMActiveServices.serviceInit(ResourceManager.java:829)
	at org.apache.hadoop.service.AbstractService.init(AbstractService.java:164)
	at org.apache.hadoop.yarn.server.resourcemanager.ResourceManager.createAndInitActiveServices(ResourceManager.java:1247)
	at org.apache.hadoop.yarn.server.resourcemanager.ResourceManager.serviceInit(ResourceManager.java:324)
	at org.apache.hadoop.service.AbstractService.init(AbstractService.java:164)
	at org.apache.hadoop.yarn.server.resourcemanager.ResourceManager.main(ResourceManager.java:1534)
Caused by: java.io.IOException: mapping contains invalid or non-leaf queue [%user] and invalid parent queue [root.users]
	at org.apache.hadoop.yarn.server.resourcemanager.placement.QueuePlacementRuleUtils.validateQueueMappingUnderParentQueue(QueuePlacementRuleUtils.java:48)
	at org.apache.hadoop.yarn.server.resourcemanager.placement.UserGroupMappingPlacementRule.validateAndGetAutoCreatedQueueMapping(UserGroupMappingPlacementRule.java:363)
	at org.apache.hadoop.yarn.server.resourcemanager.placement.UserGroupMappingPlacementRule.initialize(UserGroupMappingPlacementRule.java:300)
	at org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.CapacityScheduler.getUserGroupMappingPlacementRule(CapacityScheduler.java:671)
	at org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.CapacityScheduler.updatePlacementRules(CapacityScheduler.java:712)
	at org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.CapacityScheduler.initializeQueues(CapacityScheduler.java:753)
	at org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.CapacityScheduler.initScheduler(CapacityScheduler.java:361)
	at org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.CapacityScheduler.serviceInit(CapacityScheduler.java:426)
	at org.apache.hadoop.service.AbstractService.init(AbstractService.java:164)
	... 7 more

QueuePlacementConverter#handleNestedRule has to be fixed.

else if (pr instanceof DefaultPlacementRule) {
      DefaultPlacementRule defaultRule = (DefaultPlacementRule) pr;
      mapping.append("u:" + USER + ":")
        .append(defaultRule.defaultQueueName)
        .append("." + USER);
    }

Issue Links

• Dependent: YARN-9879 Allow multiple leaf queues with the same name in CapacityScheduler
• is blocked by: YARN-10254 CapacityScheduler incorrect User Group Mapping after leaf queue change