[YARN-10018] container-executor: possible -1 return value of fork() is not always checked

• Type: Bug
• Status: Patch Available
• Priority: Major
• Resolution: Unresolved
• Component/s: nodemanager
• Assignee: Peter Bacsko
• Reporter: Peter Bacsko
• Created: 07/Dec/19 12:36
• Updated: 16/Jan/20 22:43

Description

There are some places in the container-executor native, where the fork() call is not handled properly. This operation can fail with -1, but sometimes the necessary if branch is missing to validate that it's been successful.

Also, at one location, the return value is defined as an int, not pid_t. It's better to handle this transparently and change it.