XWork
  1. XWork
  2. XW-935

Create an InterceptorManager to cache interceptors

    Details

    • Type: Improvement Improvement
    • Status: Open
    • Priority: Minor Minor
    • Resolution: Unresolved
    • Affects Version/s: 1.0.1
    • Fix Version/s: 1.2
    • Component/s: Interceptors
    • Labels:
      None

      Description

      Interceptors are currently instantiated, with parameters, for every ActionConfig.

      This is inefficient as the same interceptor could be instantiated hundreds of times.

      To solve this, we need to create an InterceptorManager which caches instantiated interceptors by name & parameters.

        Activity

        Hide
        Patrick Lightbody added a comment -

        Mike – IM me if you think this is important enough to put back to 1.1

        Show
        Patrick Lightbody added a comment - Mike – IM me if you think this is important enough to put back to 1.1
        Hide
        Patrick Lightbody added a comment -

        This sounds post-2.0. And also XWork... BAD MIKE

        Show
        Patrick Lightbody added a comment - This sounds post-2.0. And also XWork... BAD MIKE
        Hide
        Anders Engstr?m added a comment -

        I suppose naming conventions are kinda personal But IMO [InterceptorFactory -> InterceptorCache] or even [InterceptorFactory -> ObjectCache] is better.

        Show
        Anders Engstr?m added a comment - I suppose naming conventions are kinda personal But IMO [InterceptorFactory -> InterceptorCache] or even [InterceptorFactory -> ObjectCache] is better.

          People

          • Assignee:
            Unassigned
            Reporter:
            Mike Cannon-Brookes
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:

              Development