XWork
  1. XWork
  2. XW-935

Create an InterceptorManager to cache interceptors

    Details

    • Type: Improvement Improvement
    • Status: Open
    • Priority: Minor Minor
    • Resolution: Unresolved
    • Affects Version/s: 1.0.1
    • Fix Version/s: 1.2
    • Component/s: Interceptors
    • Labels:
      None

      Description

      Interceptors are currently instantiated, with parameters, for every ActionConfig.

      This is inefficient as the same interceptor could be instantiated hundreds of times.

      To solve this, we need to create an InterceptorManager which caches instantiated interceptors by name & parameters.

        Activity

        Mike Cannon-Brookes created issue -
        Hide
        Anders Engstr?m added a comment -

        I suppose naming conventions are kinda personal But IMO [InterceptorFactory -> InterceptorCache] or even [InterceptorFactory -> ObjectCache] is better.

        Show
        Anders Engstr?m added a comment - I suppose naming conventions are kinda personal But IMO [InterceptorFactory -> InterceptorCache] or even [InterceptorFactory -> ObjectCache] is better.
        Jason Carreira made changes -
        Field Original Value New Value
        Fix Version/s 2.0-alpha2 [ 21214 ]
        Affects Version/s 2.0-alpha2 [ 21214 ]
        Fix Version/s 2.0-alpha1 [ 21130 ]
        Jason Carreira made changes -
        Fix Version/s 2.0 [ 21230 ]
        Fix Version/s 2.0-beta2 [ 21214 ]
        Matt Ho made changes -
        Priority Major [ 3 ] Minor [ 4 ]
        Hide
        Patrick Lightbody added a comment -

        This sounds post-2.0. And also XWork... BAD MIKE

        Show
        Patrick Lightbody added a comment - This sounds post-2.0. And also XWork... BAD MIKE
        Patrick Lightbody made changes -
        Fix Version/s 2.0 [ 21230 ]
        Fix Version/s 2.1 [ 21215 ]
        Jason Carreira made changes -
        Fix Version/s 2.0.1 [ 21215 ]
        Mathias Bogaert made changes -
        Affects Version/s 2.0-beta2 [ 21214 ]
        Component/s Interceptors [ 21101 ]
        Affects Version/s 2.0-beta1 [ 21130 ]
        Affects Version/s 1.0.1 [ 21213 ]
        Fix Version/s 1.1 [ 21330 ]
        Key WW-171 XW-176
        Project WebWork [ 10030 ] XWork [ 10050 ]
        Hide
        Patrick Lightbody added a comment -

        Mike – IM me if you think this is important enough to put back to 1.1

        Show
        Patrick Lightbody added a comment - Mike – IM me if you think this is important enough to put back to 1.1
        Patrick Lightbody made changes -
        Fix Version/s 1.1 [ 21330 ]
        Fix Version/s 1.2 [ 21531 ]
        Assignee Mike Cannon-Brookes [ mike@atlassian.com ]
        Jeff Turner made changes -
        Project Import Mon Feb 01 01:36:33 UTC 2010 [ 1264988193038 ]
        Tony Stevenson made changes -
        Project XWork [ 12311042 ] XW STAGING [ 12313522 ]
        Key XW-176 XWSTAG-345
        Affects Version/s 1.0.1 [ 12321793 ]
        Affects Version/s 1.0.1 [ 12314709 ]
        Component/s Interceptors [ 12319176 ]
        Component/s Interceptors [ 12313372 ]
        Fix Version/s 1.2 [ 12321783 ]
        Fix Version/s 1.2 [ 12314719 ]
        Tony Stevenson made changes -
        Project XW STAGING [ 12313522 ] XWork [ 12313523 ]
        Key XWSTAG-345 XW-935
        Affects Version/s 1.0.1 [ 12321800 ]
        Affects Version/s 1.0.1 [ 12321793 ]
        Component/s Interceptors [ 12319181 ]
        Component/s Interceptors [ 12319176 ]
        Fix Version/s 1.2 [ 12321810 ]
        Fix Version/s 1.2 [ 12321783 ]

          People

          • Assignee:
            Unassigned
            Reporter:
            Mike Cannon-Brookes
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:

              Development