[XW-814] Initialize/create OGNL ValueStack before instantiating the Action

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.0-beta2
• Fix Version/s: 1.0
• Component/s: Configuration
• Assignee: Unassigned
• Reporter: Mathias Bogaert
• Created: 23/Dec/03 17:04
• Updated: 18/Jun/12 07:29
• Resolved: 02/Feb/04 06:47

Description

PicoContainer (http://www.picocontainer.org) needs access to the ValueStack in order to put together the container to resolve Type3 (constructor based) dependencies defined as constructor arguments. When instantiating, it will look through the tree of containers trying to resolve all dependencies. Since DefaultActionInvocation only initializes/creates the ValueStack after the action is created (createContextMap), PicoContainer will throw a NPE when accessing it.

Attached is the patch which initializes/creates the stack before createAction is called. Only pushing the action and actioninvocation onto the stack were moved out of the protected createContextMap method. I'm not sure what this means in terms of portability, but I see no problems.

Issue Links

• is duplicated by: XW-946 Refactor DefaultActionInvocation for Pico Integration