[XW-750] buildValidators doesn't look for validators for every super class

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.0-beta1
• Fix Version/s: 1.0-beta1
• Component/s: Validators
• Assignee: Unassigned
• Reporter: Vincent Faidherbe
• Created: 10/Jun/03 18:06
• Updated: 18/Jun/12 07:28
• Resolved: 16/Jun/03 18:43

Description

ActionValidatorManager.buildValidators doesn't traverse up the class hierarchy looking for validators for every super class. It only get the validator for the superclass.

The current code is :
...
if (!actionClass.getSuperclass().equals(Object.class)) {
validators.addAll(buildClassValidators(actionClass.getSuperclass(), checkFile));
}

validators.addAll(buildClassValidators(actionClass, checkFile));
validators.addAll(buildAliasValidators(actionClass, invocation, checkFile));
...

I think the code should look more like this :
...
Class actionClass = invocation.getAction().getClass();

// validators for the action class
validators.addAll(buildClassValidators(actionClass, checkFile));
validators.addAll(buildAliasValidators(actionClass, invocation, checkFile));

// looking for validators for every super class
actionClass = actionClass.getSuperclass();
while (!actionClass.equals(Object.class)) {
validators.addAll(buildClassValidators(actionClass, checkFile));
actionClass = actionClass.getSuperclass();
}
...