[XW-737] ValidatorSupport turns empty defaultMessage to null causing field error to include "null" for visitor validators with empty messages

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.1.6
• Fix Version/s: 2.1.7
• Component/s: Validators
• Environment: struts 2.1.8, xwork 2.1.6, jdk 1.6
• Flags: Patch
• Assignee: Disabled - L-u-k-a-s-z Lenart - OpenSymphony
• Reporter: Haroon Rafique
• Created: 11/Nov/09 09:25
• Updated: 11/Mar/10 00:32
• Resolved: 11/Mar/10 00:32

Description

Upon upgrading to struts 2.1.8 with xwork 2.1.6, I started getting field errors which included the string null in them for field visitor validators.

Using a visitor validator as follows:

<field name="residenceRoom">

<field-validator type="visitor">

<message/>

</field-validator>

</field>

and a required string validator on the actual field as follows:

<field name="description">

<field-validator type="requiredstring">

<message>Description is required</message>

</field-validator>

</field>

I was expecting only the message "Description is required" but I end up with "nullDescription is required". Presumably this happens because of line 202 in VisitorFieldValidator.java

super.addFieldError(getFullFieldName(fieldName), message + errorMessage);

The fix for me seems to be to fix ValidatorSupport to not nullify defaultMessage when message is null or empty. I will attach a patch shortly.