[XW-667] Action validation should load class only when required

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.1
• Fix Version/s: 2.1.2
• Component/s: Configuration
• Flags: Patch
• Assignee: Unassigned
• Reporter: Musachy Barroso
• Created: 01/Dec/08 15:37
• Updated: 18/Dec/08 15:28
• Resolved: 18/Dec/08 15:28

Description

See https://issues.apache.org/struts/browse/WW-1821for background. I proposed this change:

— XmlConfigurationProvider.java (revision 1877)

+++ XmlConfigurationProvider.java (working copy)

@@ -380,8 +380,8 @@

return true;

}

try {

• Class clazz = objectFactory.getClassInstance(className);

if (objectFactory.isNoArgConstructorRequired()) {

+ Class clazz = objectFactory.getClassInstance(className);

if (!Modifier.isPublic(clazz.getModifiers()))

{ throw new ConfigurationException("Action class [" + className + "] is not publi c", loc); }

Side effect is that it would break anyone that is doing some sort of static loading on the actions (which is wrong but hey!). Opening ticket to get more feedback.