XML-RPC
  1. XML-RPC
  2. XMLRPC-132

Enabling the ability for the xml-rpc client to redirect requests

    Details

    • Type: New Feature New Feature
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 3.0, 3.1
    • Fix Version/s: 3.1
    • Component/s: Source
    • Labels:
      None

      Description

      This modification to the XMLRPCStreamTransport adds a customization point to determine if the transport needs to redirect the request before attempting to parse the response from the server. This uses a similar redirect algorithm as used in the Apache Http client to processing redirects with a Max limit to prevent a recursive loop.

      The redirect logic itself is implemented in two callback methods isRedirectRequired() and
      resetClientForRedirect()

      These callback methods are only implemented in the XmlRpcCommonsTransport which means that the other transport options won't support redirects (unless they are modified to do this by implementing these call back methods)

      1. XMLRPC-132.zip
        6 kB
        Andrew Norman
      2. XMLRPC-132-patch
        13 kB
        Andrew Norman
      3. redirects.patch
        3 kB
        Jochen Wiedmann

        Activity

        Hide
        Jochen Wiedmann added a comment -

        Closing issues which have been released.

        Show
        Jochen Wiedmann added a comment - Closing issues which have been released.
        Hide
        Jochen Wiedmann added a comment -

        It's already in the trunk.

        Show
        Jochen Wiedmann added a comment - It's already in the trunk.
        Hide
        Andrew Norman added a comment -

        Jochen,

        sorry for the delay, but I've tested your version of the patch an it works with flying colors! Lets get this committed!

        thanks for your time on this

        -Andrew

        Show
        Andrew Norman added a comment - Jochen, sorry for the delay, but I've tested your version of the patch an it works with flying colors! Lets get this committed! thanks for your time on this -Andrew
        Hide
        Jochen Wiedmann added a comment -

        Sorry for the delay, but I am really doing my best to manage my backlog.

        Please verify the attached patch, which is based on yours, but drastically minimizes the impact.

        Show
        Jochen Wiedmann added a comment - Sorry for the delay, but I am really doing my best to manage my backlog. Please verify the attached patch, which is based on yours, but drastically minimizes the impact.
        Hide
        Andrew Norman added a comment -

        this nweeds to be reviewed and commited

        Show
        Andrew Norman added a comment - this nweeds to be reviewed and commited
        Hide
        Andrew Norman added a comment -

        see submitted code

        Show
        Andrew Norman added a comment - see submitted code
        Hide
        Andrew Norman added a comment -

        an eclipse patch file of the proposed feature

        Show
        Andrew Norman added a comment - an eclipse patch file of the proposed feature
        Hide
        Andrew Norman added a comment -

        this is the proposed enhancement java files, made against the 3.0 code release and synchornized against the latest code in subversion

        Show
        Andrew Norman added a comment - this is the proposed enhancement java files, made against the 3.0 code release and synchornized against the latest code in subversion

          People

          • Assignee:
            Unassigned
            Reporter:
            Andrew Norman
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development