[XMLBEANS-206] Wrong method finding in getMethod() of InterfaceExtensionImpl

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: Version 2
• Component/s: Binding
• Environment: Doesn't relate to platform.
• Assignee: Rajiv Bala
• Reporter: Denis Anisimov
• Created: 26/Sep/05 22:06
• Updated: 28/Oct/05 03:48
• Resolved: 28/Oct/05 03:48

Description

Wrong implementation of getMethod() in InterfaceExtensionImpl class could lead to ArrayIndexOutOfBoundsException.
Old implementation :
static JMethod getMethod(JClass cls, String name, JClass[] paramTypes)
{
JMethod[] methods = cls.getMethods();
for (int i = 0; i < methods.length; i++)
{
JMethod method = methods[i];
if (!name.equals(method.getSimpleName()))
continue;

JParameter[] mParams = method.getParameters();
for (int j = 0; j < mParams.length; j++)

{ JParameter mParam = mParams[j]; if (!mParam.getType().equals(paramTypes[j])) continue; }

return method;
}
return null;
}

Correct impl-tion :

static JMethod getMethod(JClass cls, String name, JClass[] paramTypes)
{
JMethod[] methods = cls.getMethods();
for (int i = 0; i < methods.length; i++)
{
JMethod method = methods[i];
if (!name.equals(method.getSimpleName()))
continue;

JParameter[] mParams = method.getParameters();
// here was bug in possibe ArrayIndexOutOfBoundsException.
// because methods could have same names but different
// number of parameters
if ( mParams.length != paramTypes.length ){ continue; }

for (int j = 0; j < mParams.length; j++)
{ JParameter mParam = mParams[j]; if (!mParam.getType().equals(paramTypes[j])) continue; }

return method;
}
return null;
}