[XGC-25] Should never use Error to report runtime errors

• Type: Bug
• Status: Resolved
• Resolution: Fixed
• Affects Version/s: 1.3.1
• Component/s: image codecs
• Environment: Operating System: Windows XP; Platform: PC
• Assignee: XML Graphics Project Mailing List
• Reporter: Sebb
• Created: 09/May/09 03:41
• Updated: 24/Jun/15 08:50
• Resolved: 10/Apr/12 18:47

Description

See BATIK-906:

TIFFImageEncoder uses Error to report unexpected conditions, e.g.

switch(dataType) {
case DataBuffer.TYPE_BYTE:
if(sampleSize[0] != 1 && sampleSize[0] == 4 &&
sampleSize[0] != 8)

{ throw new Error("TIFFImageEncoder2"); }

break;

Using Error makes it hard to safely catch the exception, as there are some
Errors that should not be caught (e.g. ThreadDeath)

The code should use a more specific Error, e.g. RuntimeException or
IllegalArgumentException or InvalidParameterException.

There are a few other classes that use Error():

TIFF*

Glyphs
AbstractGraphics2D
TransformType

Please can these be changed to use a RuntimeError of some kind?