[XERCESJ-1107] [PATCH] Cleanup inefficient StringBuffer code

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.7.1
• Fix Version/s: 2.8.0
• Assignee: Michael Glavassevich
• Reporter: David Brosius
• Created: 22/Oct/05 15:37
• Updated: 27/Feb/06 14:32
• Resolved: 27/Feb/06 14:32

Description

StringBuffers are used through the code, but in a way that reduces their performance below, perhaps, what normal String concatenation would be.

Doing

StringBuffer s = new StringBuffer();
s.append(a + b);

is the same as

StringBuffer s = new StringBuffer();
s.append(new StringBuffer(a).append(b).toString());

So, don't do normal concatentation in an append call, since one went to the trouble to use StringBuffer's in the first place.