Uploaded image for project: 'Xerces-C++'
  1. Xerces-C++
  2. XERCESC-2100

[patch] Small fixes for warnings and errors

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.2.0
    • Fix Version/s: 3.2.0
    • Component/s: None
    • Labels:
    • Flags:
      Patch

      Description

      These patches have been sitting around for nearly a year, but I've rebased them onto the trunk and tested them again. They cover several classes of fix:

      • minor build improvements
      • minor tweaks to feature tests
      • enabling stricter compiler warnings, and then fixing those warnings
      • fixing mismatched delete/delete[] (bad)
      • adding missing virtual destructors (bad)
      • removing unused variables
      • removing unused variables conditionally when used conditionally
      • removing cast warnings with appropriate C++ const/static/reinterpret casts

      Most of the fixes are tiny one-liners to fix warnings.
      Builds:

        Attachments

        1. 0035-xercesc-CMStateSet-Suppress-cast-alignment-warnings.patch
          2 kB
          Roger Leigh
        2. 0034-xercesc-XML-Transcoder-Suppress-cast-alignment-warni.patch
          2 kB
          Roger Leigh
        3. 0033-xercesc-XSerializeEngine-Suppress-cast-alignment-war.patch
          6 kB
          Roger Leigh
        4. 0032-xercesc-XMLReader-Suppress-cast-alignment-warnings.patch
          2 kB
          Roger Leigh
        5. 0031-xercesc-DOMCasts-Suppress-cast-alignment-warnings.patch
          3 kB
          Roger Leigh
        6. 0030-xercesc-XProtoType-Suppress-cast-alignment-warning.patch
          0.9 kB
          Roger Leigh
        7. 0029-xercesc-EncodingValidator-Suppress-cast-alignment-wa.patch
          0.9 kB
          Roger Leigh
        8. 0028-xercesc-DOMLSSerializerImpl-Suppress-cast-alignment-.patch
          1.0 kB
          Roger Leigh
        9. 0027-xercesc-XMLUri-Add-missing-const_cast.patch
          0.7 kB
          Roger Leigh
        10. 0026-xercesc-QName-Add-mising-const_casts.patch
          2 kB
          Roger Leigh
        11. 0025-xercesc-BinMemInputStream-Add-missing-const_cast.patch
          0.9 kB
          Roger Leigh
        12. 0024-xercesc-PlatformUtils-Include-sys-timeb.h-conditiona.patch
          0.8 kB
          Roger Leigh
        13. 0023-tests-XSValueTest-Conditionally-define-conditionally.patch
          4 kB
          Roger Leigh
        14. 0022-tests-XSTSHarness-Remove-unused-variables.patch
          3 kB
          Roger Leigh
        15. 0021-tests-MemoryMonitor-Remove-unused-variable.patch
          1 kB
          Roger Leigh
        16. 0020-tests-DTest-Remove-unused-variables.patch
          2 kB
          Roger Leigh
        17. 0019-xercesc-DatatypeValidatorFactory-Remove-unused-varia.patch
          2 kB
          Roger Leigh
        18. 0018-xercesc-RangeToken-Conditionally-define-variable-if-.patch
          1 kB
          Roger Leigh
        19. 0017-xercesc-XMLUri-Remove-unused-variables.patch
          1 kB
          Roger Leigh
        20. 0016-xercesc-DOMLSSerializerImpl-Remove-unused-variable.patch
          0.8 kB
          Roger Leigh
        21. 0015-samples-PSVIWriterHandlers-Remove-unused-variables.patch
          2 kB
          Roger Leigh
        22. 0014-xercesc-NamespaceScope-Correct-initialisation-order.patch
          0.7 kB
          Roger Leigh
        23. 0013-xercesc-NamespaceScope-Add-missing-virtual-destructo.patch
          1 kB
          Roger Leigh
        24. 0012-xercesc-DOMParentNode-Add-missing-virtual-destructor.patch
          0.8 kB
          Roger Leigh
        25. 0011-xercesc-Don-t-warn-about-private-constructors-with-G.patch
          2 kB
          Roger Leigh
        26. 0010-tests-XSValueTest-Don-t-warn-about-integer-limit-pro.patch
          1 kB
          Roger Leigh
        27. 0009-tests-ThreadTest.cpp-Handle-all-node-types-in-switch.patch
          0.9 kB
          Roger Leigh
        28. 0008-tests-DTest.cpp-Use-correct-format-strings-to-match-.patch
          5 kB
          Roger Leigh
        29. 0007-tests-EncodingTest.cpp-Use-correct-format-strings-to.patch
          3 kB
          Roger Leigh
        30. 0006-samples-PSVIWriterHandlers.cpp-Use-delete-in-place-o.patch
          0.8 kB
          Roger Leigh
        31. 0005-cmake-Enable-extra-compiler-warnings.patch
          2 kB
          Roger Leigh
        32. 0004-cmake-XercesIntTypes-Add-a-cstdint-functional-check.patch
          1 kB
          Roger Leigh
        33. 0003-cmake-Minimum-C-standard-is-C-98-but-also-try-later-.patch
          1.0 kB
          Roger Leigh
        34. 0002-cmake-Debug-FindThreads.patch
          0.7 kB
          Roger Leigh
        35. 0001-build-Merge-MsgCatalog-Makefile.in-with-src-Makefile.patch
          5 kB
          Roger Leigh

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              rleigh Roger Leigh
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: