[XERCESC-2025] Empty line generated when fgDOMXMLDeclaration is disabled

• Type: Bug
• Status: Reopened
• Priority: Minor
• Resolution: Unresolved
• Affects Version/s: 3.0.0, 3.0.1, 3.1.0, 3.1.1, 3.1.2, 3.1.3, 3.1.4
• Component/s: DOM
• Labels: DOMLSSerializer empty line
• Assignee: Unassigned
• Reporter: Jose M. Sanchez
• Created: 06/Feb/14 10:14
• Updated: 11/Jul/17 00:26

Description

The DOMLSSerializer implementation is generating a leading empty line
in case that the generation of the XML Declaration is disabled.

The source code looks like this:

https://svn.apache.org/repos/asf/xerces/c/trunk/src/xercesc/dom/impl/DOMLSSerializerImpl.cpp

if (getFeature(XML_DECLARATION))

{ // use the version and encoding resolved *fFormatter << gXMLDecl_VersionInfo << fDocumentVersion << gXMLDecl_separator; *fFormatter << gXMLDecl_EncodingDecl << fEncodingUsed << gXMLDecl_separator; const XMLCh* st = (docu->getXmlStandalone())? XMLUni::fgYesString : XMLUni::fgNoString; *fFormatter << gXMLDecl_SDDecl << st << gXMLDecl_separator; *fFormatter << gXMLDecl_endtag; }

DOMNodeSPtr child = nodeToWrite->getFirstChild();
while( child != 0)

{ processNode(child, level); child = child->getNextSibling(); }

printNewLine();

The printNewLine() method is called even if no XML declaration was written, thus generating a leading empty line.

Issue Links

• is duplicated by: XERCESC-1902 Stray newline if pretty-printing without xml declaration