[XERCESC-2004] bit operation error in DOMNodeImpl::reverseTreeOrderBitPattern

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.1.1
• Fix Version/s: 3.1.2, 3.2.0
• Component/s: DOM
• Environment: any
• Assignee: Alberto Massari
• Reporter: 朱亚东
• Created: 24/Nov/12 14:13
• Updated: 28/Feb/15 01:08
• Resolved: 26/Nov/12 08:51

Description

code like below:
short DOMNodeImpl::reverseTreeOrderBitPattern(short pattern) const {
if(pattern & DOMNode::DOCUMENT_POSITION_PRECEDING)

{ pattern &= !DOMNode::DOCUMENT_POSITION_PRECEDING; pattern |= DOMNode::DOCUMENT_POSITION_FOLLOWING; }

I think it should be:
short DOMNodeImpl::reverseTreeOrderBitPattern(short pattern) const {
if(pattern & DOMNode::DOCUMENT_POSITION_PRECEDING)

{ pattern &= ~DOMNode::DOCUMENT_POSITION_PRECEDING; pattern |= DOMNode::DOCUMENT_POSITION_FOLLOWING; }

because !DOMNode::DOCUMENT_POSITION_PRECEDING always be 0.