[XERCESC-1993] ContentSpecNode::getMaxTotalRange: Operator precedence flaw

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Duplicate
• Affects Version/s: 3.1.1
• Component/s: Validating Parser (XML Schema)
• Labels: patch
• Environment: Not relevant, C++ syntax problem
• Assignee: Unassigned
• Reporter: Michael Gmelin
• Created: 11/Sep/12 10:34
• Updated: 11/Sep/12 10:39
• Resolved: 11/Sep/12 10:39

Description

ContentSpecType.cpp says at about line 260:

if ((fType & 0x0f) == ContentSpecNode::Choice)

{ max = max * (maxFirst > maxSecond) ? maxFirst : maxSecond; }

Thanks to operator precedence max evaluates either to maxFirst or maxSecond, but never to max*maxFirst or max*maxSecond.

Adding parenthesis makes this do the right thing:
max = max * ((maxFirst > maxSecond) ? maxFirst : maxSecond);

Patch:
— a/src/xercesc/validators/common/ContentSpecNode.cpp
+++ b/src/xercesc/validators/common/ContentSpecNode.cpp
@@ -259,7 +259,7 @@ int ContentSpecNode::getMaxTotalRange() const {
else {

if ((fType & 0x0f) == ContentSpecNode::Choice)

{ - max = max * (maxFirst > maxSecond) ? maxFirst : maxSecond; + max = max * ((maxFirst > maxSecond) ? maxFirst : maxSecond); }

else {
max = max * (maxFirst + maxSecond);