[XERCESC-1378] wrong string destruction in MemBufInputSource::~MemBufInputSource()

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.6.0
• Component/s: SAX/SAX2
• Environment: Any
• Assignee: Unassigned
• Reporter: Nikolay Ognyanov
• Created: 16/Mar/05 23:58
• Updated: 17/Mar/05 21:23
• Resolved: 17/Mar/05 20:05

Description

MemBufInputSource::~MemBufInputSource()
{
if (fAdopted)
delete [] (XMLByte*)fSrcBytes;
}

This seems terribly wrong. Constructor initializes fSrcBytes
with its argument srcDocBytes and this never changes, so the
original argument string is deleted here and not a copy of it.
Actual creation and destruction of a copy if fAdopted is set
is handled in BinMemInputStream which is instantiated in MemBufInputSource::makeStream(). Therefore the code quoted
above should be removed from the destructor and it should do
nothing.

Regards
Nikolay