[XERCESC-1304] XSValue::getActValStrings translates dt_boolean wrong

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.6.0
• Environment: Windows XP Professional
• Assignee: Unassigned
• Reporter: Patrick Frants
• Created: 01/Dec/04 15:06
• Updated: 01/Dec/04 19:23
• Resolved: 01/Dec/04 16:21

Description

In the lines (marked with BUG) where retVal->fData.fValue.f_bool is assigned a boolean value, the wrong value is assigned.

XMLUni::fgBooleanValueSpace[0] and XMLUni::fgBooleanValueSpace[2] contain the values for false.
XMLUni::fgBooleanValueSpace[1] and XMLUni::fgBooleanValueSpace[3] contain the values for true.

Does anybody actually use this code?

XSValue*
XSValue::getActValStrings(const XMLCh* const content
, DataType datatype
, Status& status
, XMLVersion version
, bool toValidate
, MemoryManager* const manager)
{
try
{
switch (datatype)
{
case XSValue::dt_boolean:
{
//do validation here more efficiently
if (XMLString::equals(content, XMLUni::fgBooleanValueSpace[0]) ||
XMLString::equals(content, XMLUni::fgBooleanValueSpace[2]) )

{ XSValue* retVal = new (manager) XSValue(dt_boolean, manager); BUG retVal->fData.fValue.f_bool = true; return retVal; }

else if (XMLString::equals(content, XMLUni::fgBooleanValueSpace[1]) ||
XMLString::equals(content, XMLUni::fgBooleanValueSpace[3]) )

{ XSValue* retVal = new (manager) XSValue(dt_boolean, manager); BUG retVal->fData.fValue.f_bool = false; return retVal; }

else

{ status = st_FOCA0002; return 0; }

}
break;